feat(webhook): gate on .pr-review.json:enabled, drop labels
This commit is contained in:
@@ -16,7 +16,6 @@ def _payload(**over):
|
||||
"number": 7,
|
||||
"title": "t",
|
||||
"body": "b",
|
||||
"labels": [{"name": "AI-REVIEW"}],
|
||||
"head": {"sha": "a" * 40},
|
||||
"base": {"ref": "main"},
|
||||
}
|
||||
@@ -26,16 +25,11 @@ def _payload(**over):
|
||||
return p
|
||||
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
# label gating
|
||||
# ---------------------------------------------------------------------------
|
||||
|
||||
|
||||
def test_labels_have_matches_dicts_and_strings():
|
||||
assert ws._labels_have([{"name": "AI-REVIEW"}], "AI-REVIEW")
|
||||
assert ws._labels_have(["AI-REVIEW"], "AI-REVIEW")
|
||||
assert not ws._labels_have([{"name": "other"}], "AI-REVIEW")
|
||||
assert not ws._labels_have(None, "AI-REVIEW")
|
||||
def _enable_repo(monkeypatch, enabled: bool = True):
|
||||
"""Patch `is_repo_enabled` to the given bool for handler tests."""
|
||||
monkeypatch.setattr(
|
||||
"webhook_server.is_repo_enabled", lambda *a, **kw: enabled
|
||||
)
|
||||
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
@@ -76,6 +70,7 @@ def test_claim_is_thread_safe():
|
||||
def test_duplicate_delivery_for_same_sha_is_not_reviewed_twice(monkeypatch):
|
||||
started = []
|
||||
monkeypatch.setattr(ws, "BOT_TOKEN", "tok")
|
||||
_enable_repo(monkeypatch)
|
||||
|
||||
class FakeThread:
|
||||
def __init__(self, target, args, daemon):
|
||||
@@ -98,6 +93,7 @@ def test_duplicate_delivery_for_same_sha_is_not_reviewed_twice(monkeypatch):
|
||||
def test_base_ref_is_passed_to_the_review_thread(monkeypatch):
|
||||
started = []
|
||||
monkeypatch.setattr(ws, "BOT_TOKEN", "tok")
|
||||
_enable_repo(monkeypatch)
|
||||
|
||||
class FakeThread:
|
||||
def __init__(self, target, args, daemon):
|
||||
@@ -115,16 +111,33 @@ def test_base_ref_is_passed_to_the_review_thread(monkeypatch):
|
||||
|
||||
def test_closed_action_is_ignored(monkeypatch):
|
||||
monkeypatch.setattr(ws, "BOT_TOKEN", "tok")
|
||||
_enable_repo(monkeypatch)
|
||||
status, msg = ws._handle_pull_request(_payload(action="closed"))
|
||||
assert status == 200
|
||||
assert "ignore" in msg
|
||||
|
||||
|
||||
def test_missing_label_is_ignored(monkeypatch):
|
||||
def test_handle_pull_request_skips_when_repo_not_enabled(monkeypatch):
|
||||
_enable_repo(monkeypatch, enabled=False)
|
||||
started = []
|
||||
monkeypatch.setattr(ws, "BOT_TOKEN", "tok")
|
||||
status, msg = ws._handle_pull_request(_payload(pr={"labels": [{"name": "wip"}]}))
|
||||
|
||||
class FakeThread:
|
||||
def __init__(self, target, args, daemon):
|
||||
self.args = args
|
||||
|
||||
def start(self):
|
||||
started.append(self.args)
|
||||
|
||||
monkeypatch.setattr(ws.threading, "Thread", FakeThread)
|
||||
ws._release(("o/r", "7", "a" * 40))
|
||||
|
||||
status, msg = ws._handle_pull_request(_payload())
|
||||
assert status == 200
|
||||
assert "AI-REVIEW" in msg
|
||||
assert "skip" in msg and "repo not opted in" in msg
|
||||
assert "opened" in msg
|
||||
assert started == []
|
||||
ws._release(("o/r", "7", "a" * 40))
|
||||
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
|
||||
Reference in New Issue
Block a user