fix: resolve review budget feedback

This commit is contained in:
Claude
2026-09-01 12:14:18 +00:00
parent 4d51e14a1a
commit 592747d98d
3 changed files with 49 additions and 13 deletions
+15 -1
View File
@@ -3,6 +3,7 @@
import os
import sys
import json
import subprocess
ROOT = os.path.abspath(os.path.join(os.path.dirname(__file__), "..", "..", ".."))
sys.path.insert(0, os.path.join(ROOT, "pilot"))
@@ -56,7 +57,20 @@ def test_process_terminates_after_step_budget():
proc = opencode_runtime._run_process(
[sys.executable, "-u", "-c", code], cwd=".", env=os.environ.copy(),
timeout=10, parse_events=parse_opencode_events, budget=budget,
budget_state=state, model="glm-5.2:cloud", runner=None,
budget_state=state, model="glm-5.2:cloud", runner=subprocess.run,
)
assert state.snapshot()["cap_reason"] == "max_steps"
assert proc.stdout.count("step_finish") == 1
def test_process_terminates_silent_child_at_duration_budget():
code = "import time; time.sleep(30)"
budget = Budget(max_steps=20, max_duration_seconds=1)
state = BudgetState(budget)
proc = opencode_runtime._run_process(
[sys.executable, "-u", "-c", code], cwd=".", env=os.environ.copy(),
timeout=10, parse_events=parse_opencode_events, budget=budget,
budget_state=state, model="glm-5.2:cloud", runner=subprocess.run,
)
assert state.snapshot()["cap_reason"] == "max_duration_seconds"
assert proc.stdout == ""