# Tasks: Vault knowledge

Rules: each task is independently testable; order = execution order. Waves run in parallel by file set.

Wave 1
- [x] 1. Pure crate `notescraft-knowledge`: tokens, chunk, passage index (BM25), caps.
      Files: `crates/knowledge/**` (new), root `Cargo.toml`, `xtask/src/layers.rs`
      Done when: `cargo test -p notescraft-knowledge` green; chunk and index tests incl. hostile inputs.
- [x] 2. Config and strings: `KnowledgeConfig`, settings paths, i18n keys for all screens.
      Files: `crates/engine/src/prefs/{knowledge_config,config,settings,mod}.rs`, `crates/i18n/locales/en.toml`, `crates/ui-egui/src/text/**`
      Done when: `settings.set session.knowledge.passages` round-trips; `cargo xtask i18n` green.

Wave 2 (after 1)
- [x] 3. Vocabulary expansion, link/tag signals, fusion ranking, evaluation set (recall@6 >= 80%).
      Files: `crates/knowledge/src/{vocab,graph,rank}.rs`, `crates/knowledge/tests/**`
      Done when: eval prints recall and passes; vocab example (reminder/notify) test passes.
- [x] 4. Engine wiring and commands `knowledge.*`, incremental updates, exclusions, status/rebuild, assistant gate plugin `knowledge`.
      Files: `crates/engine/src/knowledge/**`, `crates/engine/src/{lib,commands,vault/*}.rs`, `crates/engine/src/ai/assistant_gate.rs`, `crates/engine/tests/knowledge_commands.rs`
      Done when: commands registered; change in a note is searchable within one call; excluded folder never returned.

Wave 3 (after 3 and 4; disjoint files)
- [x] 5. MCP: `vault_context` alias, `knowledge_*` tools, parity test engine = CLI = MCP.
      Files: `crates/mcp/src/calls/**`, `crates/mcp/tests/**`
- [x] 6. Assistant auto context: add passages to the prompt within budget, store sources on the message, show them (Context card, `[n]` chips) per artboard "Assistant sources" (Knowledge page).
      Files: `crates/ui-egui/src/panels/assistant_panel/**`
- [x] 7. Related tab and right-card tab bar per artboard "Related notes" (Knowledge page) (icon-only inactive tabs).
      Files: `crates/ui-egui/src/panels/{related_panel,right_view,mod}.rs`
- [x] 8. Settings > AI assistant > Knowledge per artboard "Settings / Knowledge" (Knowledge page).
      Files: `crates/ui-egui/src/views/settings_view/categories/{knowledge,assistant}.rs`, `.../controls.rs`

Wave 4 (after 6, 7, 8)
- [x] 9. Compact layout: width class below 600 pt, bottom sheet widget, 44 pt targets; apply to tasks 6-8 screens per artboard "Mobile / Sources sheet" (Knowledge page).
      Files: `crates/ui-egui/src/widgets/bottom_sheet.rs`, `crates/ui-egui/src/style/compact.rs`, the three screens' files (touch only layout)
- [x] 10. Docs and gate: SPEC item, ROADMAP, ARCHITECTURE, HANDOVER; `cargo xtask ci` green; rebuild app.
      Files: `SPEC.md`, `ROADMAP.md`, `docs/ARCHITECTURE.md`, `HANDOVER.md`