15d7f5e873
- notescraft-lint (rules, safe fixes, learned style) and notescraft-blocks (block model and edits); engine lint.* and block.* commands with CLI and MCP parity - Lint tab, underlines, slash menu with preview in Source and Visual, block grip and menu, Settings > Editor and lint, Vim block keys - Visual view: tables, note embeds, %% comments, wrapping property chips - Vault knowledge (Related tab, assistant sources, Settings) and calendar plugin - Sidebar top padding fixed, dot grid follows PaperCraft spacing, right-card tabs no longer cover the collapse button Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
131 lines
6.7 KiB
Rust
131 lines
6.7 KiB
Rust
//! Feeds: addresses, schedule, offline cache and what never gets logged.
|
|
#![allow(clippy::unwrap_used, clippy::assert_is_empty, clippy::unnecessary_wraps)]
|
|
|
|
use std::collections::BTreeMap;
|
|
|
|
use notescraft_calendar::{CachedFeed, Feed, FeedStatus, Fetch, Fetched, due, epoch_minutes, log_line, redact, refresh};
|
|
|
|
const FEED: &str = "BEGIN:VCALENDAR\r\nBEGIN:VEVENT\r\nUID:a@x\r\nDTSTART:20261020T093000\r\nSUMMARY:Secret meeting\r\nEND:VEVENT\r\nBEGIN:VEVENT\r\nUID:b@x\r\nDTSTART:20261021\r\nSUMMARY:Holiday\r\nEND:VEVENT\r\nEND:VCALENDAR\r\n";
|
|
const SECRET: &str = "TOKEN1234SECRET";
|
|
|
|
struct Script(Vec<Result<Fetched, String>>, Vec<Option<String>>);
|
|
|
|
impl Fetch for Script {
|
|
fn fetch(&mut self, _url: &str, etag: Option<&str>) -> Result<Fetched, String> {
|
|
self.1.push(etag.map(str::to_owned));
|
|
self.0.remove(0)
|
|
}
|
|
}
|
|
|
|
fn feed() -> Feed {
|
|
Feed::new("Team calendar", &format!("webcal://calendar.example.com/team.ics?token={SECRET}&x=1"), Some(30)).unwrap()
|
|
}
|
|
|
|
fn t(text: &str) -> notescraft_calendar::EventTime {
|
|
text.parse().unwrap()
|
|
}
|
|
|
|
fn body(etag: Option<&str>) -> Result<Fetched, String> {
|
|
Ok(Fetched::Body { text: FEED.to_owned(), etag: etag.map(str::to_owned) })
|
|
}
|
|
|
|
#[test]
|
|
fn addresses_names_and_intervals_are_checked() {
|
|
let ok = feed();
|
|
assert_eq!((ok.id.as_str(), ok.refresh_minutes), ("team-calendar", 30));
|
|
assert!(ok.url.starts_with("https://calendar.example.com"), "webcal is read as https");
|
|
assert_eq!(Feed::new("x", "https://a.example/x.ics", None).unwrap().refresh_minutes, 60);
|
|
for (name, url, refresh) in [
|
|
("", "https://a.example/x.ics", None),
|
|
("x", "ftp://a.example/x.ics", None),
|
|
("x", "javascript:alert(1)", None),
|
|
("x", "https://", None),
|
|
("x", "https://a.example/a b.ics", None),
|
|
("x", "https://a.example/x.ics\n", Some(1)),
|
|
("x", "https://a.example/x.ics", Some(1)),
|
|
("x", "https://a.example/x.ics", Some(99_999_999)),
|
|
] {
|
|
assert!(Feed::new(name, url, refresh).is_err(), "{name:?} {url:?} {refresh:?}");
|
|
}
|
|
assert!(Feed::new("x", &format!("https://a.example/{}", "a".repeat(3000)), None).is_err());
|
|
assert_eq!(Feed::new("日本 語!!", "https://a.example/x.ics", None).unwrap().id, "feed");
|
|
}
|
|
|
|
#[test]
|
|
fn feeds_are_due_on_their_schedule_and_retried_sooner_after_a_failure() {
|
|
let feed = feed();
|
|
let at = |text: &str| epoch_minutes(t(text)).unwrap();
|
|
let mut statuses = BTreeMap::new();
|
|
assert_eq!(due(std::slice::from_ref(&feed), &statuses, at("2026-10-20T09:00"), false).len(), 1, "never fetched");
|
|
statuses.insert(
|
|
feed.id.clone(),
|
|
FeedStatus { attempted_at: Some("2026-10-20T09:00".into()), fetched_at: Some("2026-10-20T09:00".into()), ..FeedStatus::default() },
|
|
);
|
|
assert!(due(std::slice::from_ref(&feed), &statuses, at("2026-10-20T09:29"), false).is_empty());
|
|
assert_eq!(due(std::slice::from_ref(&feed), &statuses, at("2026-10-20T09:30"), false).len(), 1);
|
|
assert_eq!(due(std::slice::from_ref(&feed), &statuses, at("2026-10-20T09:01"), true).len(), 1, "force ignores the schedule");
|
|
statuses.get_mut(&feed.id).unwrap().error = Some("offline".into());
|
|
assert_eq!(due(std::slice::from_ref(&feed), &statuses, at("2026-10-20T09:15"), false).len(), 1, "a failing feed is retried after 15 minutes");
|
|
statuses.insert(feed.id.clone(), FeedStatus { attempted_at: Some("not a time".into()), ..FeedStatus::default() });
|
|
assert_eq!(due(&[feed], &statuses, 0, false).len(), 1, "a damaged status counts as never fetched");
|
|
}
|
|
|
|
#[test]
|
|
fn a_refresh_fills_the_cache_and_remembers_the_validator() {
|
|
let feed = feed();
|
|
let mut script = Script(vec![body(Some("v1")), Ok(Fetched::NotModified)], vec![]);
|
|
let first = refresh(&feed, None, &mut script, t("2026-10-20T09:00"));
|
|
assert_eq!((first.events.len(), first.status.events, first.status.etag.as_deref(), first.status.error.clone()), (2, 2, Some("v1"), None));
|
|
assert_eq!(first.status.fetched_at.as_deref(), Some("2026-10-20T09:00"));
|
|
let second = refresh(&feed, Some(&first), &mut script, t("2026-10-20T10:00"));
|
|
assert_eq!(script.1, [None, Some("v1".to_owned())], "the validator is sent back");
|
|
assert_eq!(
|
|
(second.events.len(), second.status.fetched_at.as_deref(), second.status.error.clone()),
|
|
(2, Some("2026-10-20T10:00"), None),
|
|
"not modified keeps the events"
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn offline_keeps_the_last_events_and_names_no_address() {
|
|
let feed = feed();
|
|
let first = refresh(&feed, None, &mut Script(vec![body(None)], vec![]), t("2026-10-20T09:00"));
|
|
let failed = refresh(&feed, Some(&first), &mut Script(vec![Err(format!("connect failed: {}", feed.url))], vec![]), t("2026-10-20T10:00"));
|
|
assert_eq!(failed.events.len(), 2, "cached events survive going offline");
|
|
assert_eq!(failed.status.fetched_at.as_deref(), Some("2026-10-20T09:00"), "the last good fetch stays");
|
|
assert_eq!(failed.status.attempted_at.as_deref(), Some("2026-10-20T10:00"));
|
|
let error = failed.status.error.clone().unwrap();
|
|
assert!(error.contains("connect failed") && !error.contains(SECRET) && !error.contains("calendar.example.com"), "{error}");
|
|
let broken =
|
|
refresh(&feed, Some(&first), &mut Script(vec![Ok(Fetched::Body { text: "not a calendar".into(), etag: None })], vec![]), t("2026-10-20T11:00"));
|
|
assert_eq!(broken.events.len(), 2, "a bad file does not wipe the cache");
|
|
assert!(broken.status.error.is_some());
|
|
}
|
|
|
|
#[test]
|
|
fn logs_and_caches_carry_neither_the_address_nor_event_text() {
|
|
let feed = feed();
|
|
let ok = refresh(&feed, None, &mut Script(vec![body(Some("e"))], vec![]), t("2026-10-20T09:00"));
|
|
let failed = refresh(&feed, Some(&ok), &mut Script(vec![Err(format!("timeout talking to {}", feed.url))], vec![]), t("2026-10-20T10:00"));
|
|
for status in [&ok.status, &failed.status] {
|
|
let line = log_line(&feed, status, t("2026-10-20T10:00"));
|
|
assert!(!line.contains(SECRET) && !line.contains("example.com") && !line.contains("Secret meeting"), "{line}");
|
|
}
|
|
let stored = serde_json::to_string(&failed.status).unwrap();
|
|
assert!(!stored.contains(SECRET), "{stored}");
|
|
let roundtrip: CachedFeed = serde_json::from_str(&serde_json::to_string(&failed).unwrap()).unwrap();
|
|
assert_eq!(roundtrip, failed);
|
|
assert_eq!(serde_json::from_str::<CachedFeed>("{}").unwrap(), CachedFeed::default());
|
|
}
|
|
|
|
#[test]
|
|
fn redaction_removes_userinfo_query_and_host() {
|
|
let url = "https://bob:hunter2@calendar.example.com/p/cal.ics?key=ABCDEF&u=bob";
|
|
let text = format!("GET {url} failed; user bob:hunter2 key ABCDEF");
|
|
let clean = redact(&text, url);
|
|
for secret in ["hunter2", "ABCDEF", "calendar.example.com"] {
|
|
assert!(!clean.contains(secret), "{secret} in {clean}");
|
|
}
|
|
assert!(redact(&"x".repeat(1000), url).chars().count() <= 200);
|
|
}
|