197 lines
9.1 KiB
Rust
197 lines
9.1 KiB
Rust
//! Real headless property fields validate drafts before emitting typed actions.
|
|
|
|
use egui::{Context, Event, Key, Modifiers, Pos2, RawInput};
|
|
use notescraft_markdown::{Document, PropType};
|
|
use notescraft_ui_egui::{
|
|
properties_view::{PropertiesAction, PropertiesState, PropertiesView, show_properties},
|
|
theme::Tokens,
|
|
};
|
|
use serde_json::{Value, json};
|
|
|
|
struct Panel {
|
|
context: Context,
|
|
tokens: Tokens,
|
|
state: PropertiesState,
|
|
doc: Document,
|
|
report: Value,
|
|
expanded: bool,
|
|
time: f64,
|
|
}
|
|
|
|
impl Panel {
|
|
fn new(kind: PropType, value: &Value) -> Option<Self> {
|
|
let theme = notescraft_themes::builtin("catppuccin-mocha")?;
|
|
let context = Context::default();
|
|
notescraft_ui_egui::motion::set_enabled(&context, false);
|
|
let source = format!("---\nfield: {value}\n---\nBody");
|
|
Some(Self {
|
|
context,
|
|
tokens: Tokens::new(theme),
|
|
state: PropertiesState::default(),
|
|
doc: notescraft_markdown::parse(&source),
|
|
report: json!({"properties":[{"key":"field", "name":kind.as_str(), "value":value}]}),
|
|
expanded: true,
|
|
time: 0.0,
|
|
})
|
|
}
|
|
|
|
fn frame(&mut self, events: Vec<Event>, read_only: bool) -> (Vec<PropertiesAction>, Vec<(String, Pos2)>) {
|
|
self.time += 0.1;
|
|
let input = RawInput {
|
|
screen_rect: Some(egui::Rect::from_min_size(Pos2::ZERO, egui::vec2(800.0, 600.0))),
|
|
time: Some(self.time),
|
|
events,
|
|
..Default::default()
|
|
};
|
|
let mut actions = Vec::new();
|
|
let mut output = self.context.run_ui(input, |ui| {
|
|
actions = show_properties(
|
|
ui,
|
|
&mut self.state,
|
|
&mut PropertiesView {
|
|
report: &self.report,
|
|
doc: &self.doc,
|
|
text: &self.doc.source,
|
|
read_only,
|
|
tokens: &self.tokens,
|
|
expanded: &mut self.expanded,
|
|
},
|
|
);
|
|
});
|
|
let labels = output
|
|
.shapes
|
|
.iter()
|
|
.filter_map(|shape| {
|
|
let egui::Shape::Text(text) = &shape.shape else { return None };
|
|
Some((text.galley.text().to_owned(), text.pos + text.galley.size() * 0.5))
|
|
})
|
|
.collect();
|
|
output.textures_delta.clear();
|
|
(actions, labels)
|
|
}
|
|
|
|
fn replace(&mut self, old: &str, text: &str, read_only: bool) -> Vec<PropertiesAction> {
|
|
let _ = self.frame(Vec::new(), read_only);
|
|
let (_, labels) = self.frame(Vec::new(), read_only);
|
|
let position = labels.iter().find_map(|(label, position)| (label == old).then_some(*position));
|
|
assert!(position.is_some(), "missing property field {old}: {labels:?}");
|
|
let Some(position) = position else { return Vec::new() };
|
|
let events = vec![
|
|
Event::PointerMoved(position),
|
|
Event::PointerButton { pos: position, button: egui::PointerButton::Primary, pressed: true, modifiers: Modifiers::NONE },
|
|
Event::PointerButton { pos: position, button: egui::PointerButton::Primary, pressed: false, modifiers: Modifiers::NONE },
|
|
];
|
|
let _ = self.frame(events, read_only);
|
|
self.frame(vec![key(Key::A, Modifiers::COMMAND), Event::Text(text.to_owned()), key(Key::Enter, Modifiers::NONE)], read_only).0
|
|
}
|
|
|
|
fn rename(&mut self, text: &str) -> Vec<PropertiesAction> {
|
|
let (_, labels) = self.frame(Vec::new(), false);
|
|
let position = labels.iter().find_map(|(label, position)| (label == "field").then_some(*position));
|
|
assert!(position.is_some(), "missing key: {labels:?}");
|
|
let Some(position) = position else { return Vec::new() };
|
|
let _ = self.frame(click(position), false);
|
|
let _ = self.frame(click(position), false);
|
|
let _ = self.frame(Vec::new(), false);
|
|
self.frame(vec![key(Key::A, Modifiers::COMMAND), Event::Text(text.to_owned()), key(Key::Enter, Modifiers::NONE)], false).0
|
|
}
|
|
}
|
|
|
|
fn key(key: Key, modifiers: Modifiers) -> Event {
|
|
Event::Key { key, physical_key: None, pressed: true, repeat: false, modifiers }
|
|
}
|
|
|
|
#[test]
|
|
fn scalar_fields_emit_exact_typed_values_on_enter() {
|
|
for (kind, before, input, expected) in [
|
|
(PropType::Text, json!("Before"), "After", json!("After")),
|
|
(PropType::Number, json!(7.5), "12.5", json!(12.5)),
|
|
(PropType::Date, json!("2026-10-15"), "2024-02-29", json!("2024-02-29")),
|
|
(PropType::DateTime, json!("2026-10-15T09:30:00"), "2026-10-16T10:30:00", json!("2026-10-16T10:30:00")),
|
|
] {
|
|
let panel = Panel::new(kind, &before);
|
|
assert!(panel.is_some());
|
|
let Some(mut panel) = panel else { return };
|
|
let old = before.as_str().map_or_else(|| before.to_string(), str::to_owned);
|
|
assert_eq!(panel.replace(&old, input, false), vec![PropertiesAction::Set { key: "field".into(), kind, value: expected }], "{kind:?}");
|
|
}
|
|
}
|
|
|
|
#[test]
|
|
fn invalid_scalar_drafts_and_read_only_fields_emit_nothing() {
|
|
for (kind, before, input) in [
|
|
(PropType::Number, json!(7.5), "NaN"),
|
|
(PropType::Number, json!(7.5), "1x"),
|
|
(PropType::Date, json!("2026-10-15"), "2025-02-29"),
|
|
(PropType::DateTime, json!("2026-10-15T09:30:00"), "2026-10-15T25:30:00"),
|
|
] {
|
|
let panel = Panel::new(kind, &before);
|
|
assert!(panel.is_some());
|
|
let Some(mut panel) = panel else { return };
|
|
let old = before.as_str().map_or_else(|| before.to_string(), str::to_owned);
|
|
assert_eq!(panel.replace(&old, input, false), []);
|
|
}
|
|
let panel = Panel::new(PropType::Text, &json!("Before"));
|
|
assert!(panel.is_some());
|
|
let Some(mut panel) = panel else { return };
|
|
assert_eq!(panel.replace("Before", "After", true), []);
|
|
}
|
|
|
|
#[test]
|
|
fn focusing_imported_scalar_lists_and_numbers_does_not_rewrite_values() {
|
|
for (kind, value, label) in [(PropType::Number, json!("7.5"), "7.5"), (PropType::Tags, json!("work"), "Add item…")] {
|
|
let Some(mut panel) = Panel::new(kind, &value) else { return };
|
|
let (_, labels) = panel.frame(Vec::new(), false);
|
|
let position = labels.iter().find_map(|(text, position)| (text == label).then_some(*position));
|
|
assert!(position.is_some(), "missing {label}: {labels:?}");
|
|
let Some(position) = position else { return };
|
|
let _ = panel.frame(click(position), false);
|
|
let actions = panel.frame(click(Pos2::new(790.0, 590.0)), false).0;
|
|
assert_eq!(actions, [], "untouched {kind:?} must keep its YAML representation");
|
|
}
|
|
}
|
|
|
|
fn click(position: Pos2) -> Vec<Event> {
|
|
vec![
|
|
Event::PointerMoved(position),
|
|
Event::PointerButton { pos: position, button: egui::PointerButton::Primary, pressed: true, modifiers: Modifiers::NONE },
|
|
Event::PointerButton { pos: position, button: egui::PointerButton::Primary, pressed: false, modifiers: Modifiers::NONE },
|
|
]
|
|
}
|
|
|
|
#[test]
|
|
fn property_rename_validates_and_escape_clears_cancelled_error() {
|
|
let Some(mut panel) = Panel::new(PropType::Text, &json!("Before")) else { return };
|
|
assert_eq!(panel.rename("renamed"), vec![PropertiesAction::Rename { from: "field".into(), to: "renamed".into() }]);
|
|
let Some(mut panel) = Panel::new(PropType::Text, &json!("Before")) else { return };
|
|
assert_eq!(panel.rename("bad:key"), []);
|
|
let (_, labels) = panel.frame(Vec::new(), false);
|
|
assert!(labels.iter().any(|(label, _)| label.starts_with("Enter a nonempty YAML key")), "{labels:?}");
|
|
assert_eq!(panel.frame(vec![key(Key::Escape, Modifiers::NONE)], false).0, []);
|
|
let (_, labels) = panel.frame(Vec::new(), false);
|
|
assert!(!labels.iter().any(|(label, _)| label.starts_with("Enter a nonempty YAML key")), "cancelled rename retained error: {labels:?}");
|
|
}
|
|
|
|
#[test]
|
|
fn raw_yaml_commits_on_blur_and_keeps_invalid_drafts_visible() {
|
|
for (raw, valid) in [("---\nfield: After\n---\n", true), ("---\nfield: [one] trailing\n---\n", false)] {
|
|
let Some(mut panel) = Panel::new(PropType::Text, &json!("Before")) else { return };
|
|
panel.state.set_raw_mode(true);
|
|
let (_, labels) = panel.frame(Vec::new(), false);
|
|
let position = labels.iter().find_map(|(label, position)| label.starts_with("---\n").then_some(*position));
|
|
assert!(position.is_some(), "missing raw editor: {labels:?}");
|
|
let Some(position) = position else { return };
|
|
let _ = panel.frame(click(position), false);
|
|
let (actions, _) = panel.frame(vec![key(Key::A, Modifiers::COMMAND), Event::Text(raw.to_owned())], false);
|
|
assert_eq!(actions, [], "raw edit must wait for blur");
|
|
let (actions, labels) = panel.frame(click(Pos2::new(790.0, 590.0)), false);
|
|
if valid {
|
|
let range = notescraft_markdown::yaml::block_range(&panel.doc.source);
|
|
assert_eq!(actions, range.map(|range| PropertiesAction::ReplaceRaw { range, text: raw.to_owned() }).into_iter().collect::<Vec<_>>());
|
|
} else {
|
|
assert_eq!(actions, [], "invalid YAML must not reach command dispatch");
|
|
assert!(labels.iter().any(|(label, _)| label == raw), "invalid draft disappeared: {labels:?}");
|
|
}
|
|
}
|
|
}
|