4806209761
Whiteboard: zoom bar and dot grid, layers panel, appear motion, sound cues, focus rings and AccessKit labels; .draw files with legacy .excalidraw still readable; notescraft-cli export whiteboard. Security: export.pdf and file.export_whiteboard_svg accept vault-relative out paths only (they are reachable by the assistant and the control channel). The CLI places absolute --out files itself via the new notescraft_engine::render_pdf; the UI export worker renders and the live session writes. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
199 lines
7.9 KiB
Rust
199 lines
7.9 KiB
Rust
//! Chrome consistency tests for the whiteboard.
|
|
//!
|
|
//! Covers P3 (border-radius + shadow tokens) and P4 (tool icons, tooltips,
|
|
//! nudge, text-editor trigger) without touching `edit.rs`/`render.rs`, which
|
|
//! are owned by concurrent agents. The unit tests over private state (nudge,
|
|
//! undo accounting) live alongside the production code in `state.rs`'s
|
|
//! `#[cfg(test)] mod tests`, since integration tests cannot reach `pub(super)`
|
|
//! fields.
|
|
|
|
use std::collections::HashSet;
|
|
|
|
use egui::{Context, Event, Key, Modifiers, PointerButton, Pos2, RawInput, Rect, Vec2};
|
|
use notescraft_ui_egui::{
|
|
icons, style,
|
|
theme::PANEL_RADIUS,
|
|
whiteboard_view::{WhiteboardTool, WhiteboardView, show_whiteboard},
|
|
};
|
|
use notescraft_whiteboard::{Element, IdGen, Whiteboard};
|
|
|
|
fn tokens() -> notescraft_ui_egui::theme::Tokens {
|
|
let theme = notescraft_themes::builtin("catppuccin-mocha").expect("mocha theme");
|
|
notescraft_ui_egui::theme::Tokens::new(theme)
|
|
}
|
|
|
|
fn make_text(id: &str, x: f64, y: f64) -> Element {
|
|
let mut element = Element::text(&mut IdGen::new(), x, y, "Hello");
|
|
id.clone_into(&mut element.id);
|
|
element.width = 120.0;
|
|
element.height = 24.0;
|
|
element
|
|
}
|
|
|
|
fn frame_input(width: f32, height: f32, events: Vec<Event>) -> RawInput {
|
|
RawInput { screen_rect: Some(Rect::from_min_size(Pos2::ZERO, Vec2::new(width, height))), events, ..RawInput::default() }
|
|
}
|
|
|
|
fn draw_frame(
|
|
ctx: &Context,
|
|
tokens: ¬escraft_ui_egui::theme::Tokens,
|
|
view: &mut WhiteboardView,
|
|
board: &mut Whiteboard,
|
|
events: Vec<Event>,
|
|
width: f32,
|
|
height: f32,
|
|
) -> Vec<egui::epaint::ClippedShape> {
|
|
let mut output = ctx.run_ui(frame_input(width, height, events), |ui| {
|
|
let _ = show_whiteboard(ui, tokens, view, board);
|
|
});
|
|
output.textures_delta.clear();
|
|
output.shapes
|
|
}
|
|
|
|
#[test]
|
|
fn arrow_keys_nudge_the_selection_one_and_ten_points() {
|
|
let tokens = tokens();
|
|
let ctx = Context::default();
|
|
let mut view = WhiteboardView::default();
|
|
let mut board = Whiteboard::new();
|
|
board.add(make_text("a", 50.0, 50.0));
|
|
view.selected_ids = vec!["a".to_owned()];
|
|
|
|
let press = |key: Key, shift: bool| Event::Key {
|
|
key,
|
|
physical_key: None,
|
|
pressed: true,
|
|
repeat: false,
|
|
modifiers: if shift { Modifiers::SHIFT } else { Modifiers::NONE },
|
|
};
|
|
let release = |key: Key, shift: bool| Event::Key {
|
|
key,
|
|
physical_key: None,
|
|
pressed: false,
|
|
repeat: false,
|
|
modifiers: if shift { Modifiers::SHIFT } else { Modifiers::NONE },
|
|
};
|
|
// Modifiers ride on the key events themselves; `RawInput` has no field for them.
|
|
let nudge = |ctx: &Context, view: &mut WhiteboardView, board: &mut Whiteboard, key: Key, shift: bool| {
|
|
let mut output = ctx.run_ui(frame_input(1440.0, 900.0, vec![press(key, shift), release(key, shift)]), |ui| {
|
|
let _ = show_whiteboard(ui, &tokens, view, board);
|
|
});
|
|
output.textures_delta.clear();
|
|
};
|
|
|
|
nudge(&ctx, &mut view, &mut board, Key::ArrowRight, false);
|
|
assert_eq!(board.elements[0].x, 51.0, "one arrow press nudges exactly 1 pt");
|
|
|
|
nudge(&ctx, &mut view, &mut board, Key::ArrowRight, true);
|
|
assert_eq!(board.elements[0].x, 61.0, "shift + arrow nudges exactly 10 pt");
|
|
|
|
nudge(&ctx, &mut view, &mut board, Key::ArrowUp, false);
|
|
assert_eq!(board.elements[0].y, 49.0, "vertical nudge moves y only");
|
|
}
|
|
|
|
#[test]
|
|
fn tool_tooltip_uses_label_and_shortcut() {
|
|
for tool in WhiteboardTool::ALL {
|
|
let expected = format!("{} ({})", tool.label(), tool.shortcut());
|
|
assert_eq!(tool.tooltip(), expected, "tooltip for {tool:?}");
|
|
}
|
|
}
|
|
|
|
#[test]
|
|
fn tool_icons_are_distinct_and_bundled() {
|
|
let mut seen = HashSet::new();
|
|
for tool in WhiteboardTool::ALL {
|
|
let icon = tool.icon();
|
|
assert!(icons::contains(icon), "icon {icon} for {tool:?} is not registered in ICONS");
|
|
assert!(seen.insert(icon.to_owned()), "duplicate icon {icon} across tools");
|
|
}
|
|
}
|
|
|
|
fn walk_shapes<F: FnMut(&egui::Shape)>(shape: &egui::Shape, visit: &mut F) {
|
|
visit(shape);
|
|
if let egui::Shape::Vec(children) = shape {
|
|
for child in children {
|
|
walk_shapes(child, visit);
|
|
}
|
|
}
|
|
}
|
|
|
|
#[test]
|
|
fn toolbar_and_style_panels_use_panel_radius() {
|
|
// egui 0.36 paints a `Frame` with `.shadow(...)` as a `Shape::Vec` of
|
|
// [shadow_rect, frame_rect]. The frame rect still carries the corner
|
|
// radius (PANEL_RADIUS). Walk the tree to find it.
|
|
let tokens = tokens();
|
|
let ctx = Context::default();
|
|
let mut view = WhiteboardView::default();
|
|
let mut board = Whiteboard::new();
|
|
board.add(make_text("a", 50.0, 50.0));
|
|
view.selected_ids = vec!["a".to_owned()];
|
|
|
|
draw_frame(&ctx, &tokens, &mut view, &mut board, Vec::new(), 1440.0, 900.0);
|
|
let shapes = draw_frame(&ctx, &tokens, &mut view, &mut board, Vec::new(), 1440.0, 900.0);
|
|
|
|
let expected_nw = style::radius_u8(PANEL_RADIUS);
|
|
let mut count = 0usize;
|
|
let mut radii = std::collections::BTreeMap::<u8, usize>::new();
|
|
for clipped in &shapes {
|
|
walk_shapes(&clipped.shape, &mut |shape| {
|
|
if let egui::Shape::Rect(rect) = shape {
|
|
*radii.entry(rect.corner_radius.nw).or_default() += 1;
|
|
if rect.corner_radius.nw == expected_nw {
|
|
count += 1;
|
|
}
|
|
}
|
|
});
|
|
}
|
|
assert!(count >= 2, "toolbar + style panel must paint at least two PANEL_RADIUS rects (looking for nw={expected_nw}); radii found: {radii:?}");
|
|
}
|
|
|
|
#[test]
|
|
fn single_click_on_text_does_not_open_overlay() {
|
|
let tokens = tokens();
|
|
let ctx = Context::default();
|
|
let mut view = WhiteboardView::default();
|
|
let mut board = Whiteboard::new();
|
|
board.add(make_text("a", 200.0, 200.0));
|
|
|
|
draw_frame(&ctx, &tokens, &mut view, &mut board, Vec::new(), 1440.0, 900.0);
|
|
|
|
let pos = Pos2::new(200.0, 200.0);
|
|
let press = Event::PointerButton { pos, button: PointerButton::Primary, pressed: true, modifiers: Modifiers::default() };
|
|
let release = Event::PointerButton { pos, button: PointerButton::Primary, pressed: false, modifiers: Modifiers::default() };
|
|
draw_frame(&ctx, &tokens, &mut view, &mut board, vec![press, release], 1440.0, 900.0);
|
|
draw_frame(&ctx, &tokens, &mut view, &mut board, Vec::new(), 1440.0, 900.0);
|
|
|
|
assert_eq!(view.selected_ids, vec!["a".to_owned()], "single click selects the text element");
|
|
assert!(!view.is_text_editor_open(), "single click must NOT open the text editor overlay");
|
|
}
|
|
|
|
#[test]
|
|
fn double_click_on_text_opens_overlay() {
|
|
let tokens = tokens();
|
|
let ctx = Context::default();
|
|
let mut view = WhiteboardView::default();
|
|
let mut board = Whiteboard::new();
|
|
board.add(make_text("a", 200.0, 200.0));
|
|
|
|
draw_frame(&ctx, &tokens, &mut view, &mut board, Vec::new(), 1440.0, 900.0);
|
|
|
|
let pos = Pos2::new(200.0, 200.0);
|
|
let press = Event::PointerButton { pos, button: PointerButton::Primary, pressed: true, modifiers: Modifiers::default() };
|
|
let release = Event::PointerButton { pos, button: PointerButton::Primary, pressed: false, modifiers: Modifiers::default() };
|
|
|
|
// First click.
|
|
draw_frame(&ctx, &tokens, &mut view, &mut board, vec![press.clone(), release.clone()], 1440.0, 900.0);
|
|
// Second click at the same position — egui fires `double_clicked` here.
|
|
draw_frame(&ctx, &tokens, &mut view, &mut board, vec![press, release], 1440.0, 900.0);
|
|
// Settling frame so show_text_editor paints the overlay.
|
|
let shapes = draw_frame(&ctx, &tokens, &mut view, &mut board, Vec::new(), 1440.0, 900.0);
|
|
|
|
assert!(view.is_text_editor_open(), "double-click on a text element must open the editor");
|
|
// The overlay's Frame uses `corner_radius(OVERLAY_RADIUS) = 12.0`. Look for
|
|
// a Rect with that radius painted on the foreground order.
|
|
let overlay = shapes.iter().any(|clipped| matches!(&clipped.shape, egui::Shape::Rect(rect) if i32::from(rect.corner_radius.nw) == 12));
|
|
assert!(overlay, "expected an OVERLAY_RADIUS frame in the painted shape list after a double-click");
|
|
}
|