mirror of
https://github.com/bherbruck/solidcraft.git
synced 2026-11-08 13:01:52 +00:00
blend.fillet_corner_p1: regenerate corner_p3's report on main's #256; box the corner input
reports/difftest/blend.fillet_corner_p3.json after the merge of main's final corner_p3: 1005 cases, 618 passed, 332 deferred, 55 rejected; against main's report exactly 58 cases move from deferred (sm_TestG1Continuity / CheckNx1Degeneracy, wired here) to pass, nothing else changes (modules.toml note updated). The runner's corner input is boxed (clippy large_enum_variant after the peek fields grew). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013tQ1k4UMUEjypQUCbTdiZ2
This commit is contained in:
@@ -162,7 +162,7 @@ enum Inputs {
|
||||
Corner {
|
||||
method: CornerMethod,
|
||||
model: Box<Model>,
|
||||
corner: CornerIn,
|
||||
corner: Box<CornerIn>,
|
||||
/// `peek`: the setters to call first (`-1` not called) and the type codes to
|
||||
/// test with `IsKindOf`.
|
||||
#[serde(default)]
|
||||
@@ -1379,7 +1379,7 @@ fn corner_case(i: &Inputs) -> Result<CornerCase<'_>, HarnessError> {
|
||||
Ok(CornerCase {
|
||||
method: *method,
|
||||
model: model.as_ref(),
|
||||
corner,
|
||||
corner: corner.as_ref(),
|
||||
peek,
|
||||
solvers,
|
||||
query: *query,
|
||||
@@ -1969,7 +1969,7 @@ fn gen_corner(rng: &mut Rng) -> Inputs {
|
||||
Inputs::Corner {
|
||||
method,
|
||||
model: Box::new(model),
|
||||
corner: CornerIn {
|
||||
corner: Box::new(CornerIn {
|
||||
kind,
|
||||
v_edge,
|
||||
v_sub,
|
||||
@@ -1990,7 +1990,7 @@ fn gen_corner(rng: &mut Rng) -> Inputs {
|
||||
},
|
||||
tol,
|
||||
tan,
|
||||
},
|
||||
}),
|
||||
peek,
|
||||
solvers,
|
||||
query,
|
||||
|
||||
+1
-1
@@ -3584,7 +3584,7 @@ tests = ["SM_API_test:TestSmFilletPreview", "SM_API_test:TestSmCircularFillet",
|
||||
status = "partial"
|
||||
claimed_by = ""
|
||||
claimed_at = ""
|
||||
notes = "14 fns; largest: SmFilletNx2Corner::AdjustTangentCorner, SmFilletCorner::Create, SmFilletCorner::CreateCornerPatch, SmFilletNx2Corner::AdjustTopology; cycle back-edges (call into later units; stub or co-port): blend.fillet_corner_p2(11), blend.fillet_geom_p2(1), blend.fillet_geom_p5(1), blend.fillet_geom_p6(1); unit-SCC #22 (220 units); 26 upstream test entry points reach this unit; PARTIAL (PR #256, built on PR #252 = #147 + #192): 1005 cases (308 upstream-file fixtures from TestFiles/pt_TestFiles/Fillet, 400 generated, 60 review cases with SmPlane user surfaces, 156 review cases with real SmLine 3x2 edge curves, 81 with real SmCircle 3x2 edge curves), 560 passed, 390 deferred (blend.fillet_corner_p1 111, blend.fillet_corner_p2 126, blend.fillet_executive_p1 6, blend.fillet_geom_p5 13, blend.fillet_geom_p6 33, intersect.surface_drop_lib_p3 78, surface.cone_p1 11, surface.surf_of_extrusion_p2 12), 55 rejected (40 of them review joins that succeed without an original face, where upstream would delete harness objects); every patch builder past its state checks is deferred (MakeAnalyticCornerSurface / CreateEndPatch / DropCurve), so no CreateCornerBlend default-patch values are compared; SmFilletSolver::SplitFilletGeomAtSideEdge (ported in blend.fillet_solver_p1 on FilletGeomRef) is stubbed in AdjustTangentCorner as UNPORTED(blend.fillet_geom_p6), its first blocker; the 3x2 curve join dispatches on the curve kind (SmLine/SmEllipse JoinWith overrides), as upstream's virtual JoinWith does; no CreateCornerPatch implementation compares surface output yet (corner_p1/p2 porters must extend the runner)"
|
||||
notes = "14 fns; largest: SmFilletNx2Corner::AdjustTangentCorner, SmFilletCorner::Create, SmFilletCorner::CreateCornerPatch, SmFilletNx2Corner::AdjustTopology; cycle back-edges (call into later units; stub or co-port): blend.fillet_corner_p2(11), blend.fillet_geom_p2(1), blend.fillet_geom_p5(1), blend.fillet_geom_p6(1); unit-SCC #22 (220 units); 26 upstream test entry points reach this unit; PARTIAL (PR #256, built on PR #252 = #147 + #192): 1005 cases (308 upstream-file fixtures from TestFiles/pt_TestFiles/Fillet, 400 generated, 60 review cases with SmPlane user surfaces, 156 review cases with real SmLine 3x2 edge curves, 81 with real SmCircle 3x2 edge curves), 560 passed, 390 deferred (blend.fillet_corner_p1 111, blend.fillet_corner_p2 126, blend.fillet_executive_p1 6, blend.fillet_geom_p5 13, blend.fillet_geom_p6 33, intersect.surface_drop_lib_p3 78, surface.cone_p1 11, surface.surf_of_extrusion_p2 12), 55 rejected (40 of them review joins that succeed without an original face, where upstream would delete harness objects); every patch builder past its state checks is deferred (MakeAnalyticCornerSurface / CreateEndPatch / DropCurve), so no CreateCornerBlend default-patch values are compared; SmFilletSolver::SplitFilletGeomAtSideEdge (ported in blend.fillet_solver_p1 on FilletGeomRef) is stubbed in AdjustTangentCorner as UNPORTED(blend.fillet_geom_p6), its first blocker; the 3x2 curve join dispatches on the curve kind (SmLine/SmEllipse JoinWith overrides), as upstream's virtual JoinWith does; no CreateCornerPatch implementation compares surface output yet (corner_p1/p2 porters must extend the runner) UPDATE 2026-10-20 (PR #266 wires sm_TestG1Continuity / SmFilletNx1Corner::CheckNx1Degeneracy): 1005 cases, 618 passed, 332 deferred (blend.fillet_corner_p1 1, blend.fillet_corner_p2 126, blend.fillet_executive_p1 6, blend.fillet_geom_p5 13, blend.fillet_geom_p6 33, intersect.surface_drop_lib_p3 80, surface.cone_p1 18, surface.sphere 8, surface.surf_of_extrusion_p2 30, topology.brep_p10 17), 55 rejected; exactly 58 deferred-to-pass transitions against main's report, no other change"
|
||||
|
||||
[[unit]]
|
||||
id = "blend.fillet_executive_p2"
|
||||
|
||||
File diff suppressed because it is too large
Load Diff
Reference in New Issue
Block a user