masi/solvecraft
1
0
Fork 0
mirror of https://github.com/bherbruck/solidcraft.git synced 2026-11-03 18:45:55 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

smlib: solidcore's planar thicken side walls opt-in is on; four opt-ins wait for the fork

Browse Source 
thicken_planar_side_walls (WR-564, solidcore#1665) is on: its fork commit, smlib@d384e86, is in
SMLIB_REV. fillet_torus_span_from_start_section (smlib@985faae), fillet_knife_edge_rounds
(smlib@b7ec55b), taper_wall_closes_at_apex (smlib@183ea65) and
revolution_round_offset_collapses (smlib@8b2090f) are past SMLIB_REV, so they go on HELD_BACK.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
This commit is contained in:
Brett Lawson
2026-10-30 13:55:13 +01:00
parent a6b280467a
commit 0bed45d82c
1 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/smlib/src/core.rs
+12 -2
View File
@@ -180,14 +180,24 @@ pub(crate) fn fixes() -> UpstreamFixes {
f.local_operation_step_walls = true;
f.edge_check_orders_tangent_faces = true;
f.revolve_arc_touching_axis_is_horn_torus = true;
f.thicken_planar_side_walls = true;
f
}
/// Opt-in fixes left off because the C++ fork (`SMLIB_REV`) does not carry them yet, so turning
/// them on would part this backend from the C++ one. `precise_properties_trim_base_v`
/// (solidcore#1664, WR-563) has no fork commit.
/// (solidcore#1664, WR-563) has no fork commit; the others' fork commits are past `SMLIB_REV`:
/// `fillet_torus_span_from_start_section` (WR-568, smlib@985faae), `fillet_knife_edge_rounds`
/// (WR-570, smlib@b7ec55b), `taper_wall_closes_at_apex` (WR-571, smlib@183ea65) and
/// `revolution_round_offset_collapses` (WR-567, smlib@8b2090f).
#[cfg(test)]
const HELD_BACK: &[&str] = &["precise_properties_trim_base_v"];
const HELD_BACK: &[&str] = &[
"precise_properties_trim_base_v",
"fillet_torus_span_from_start_section",
"fillet_knife_edge_rounds",
"taper_wall_closes_at_apex",
"revolution_round_offset_collapses",
];
fn fresh() -> Kernel {
let mut k = Kernel::new(&KernelOptions::default());