masi/solvecraft
1
0
Fork 0
mirror of https://github.com/bherbruck/solidcraft.git synced 2026-11-05 03:25:58 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

Provenance: a sweep's origins are the ones it recorded

Browse Source 
sweep_origins read a sweep_path tool's faces by the truck face order (walls in
profile order, then the start and end caps), and fell back to swept_origins,
which names a face without an edge in the profile's plane an end cap. SMLib's
sweep along lines and arcs is made piece by piece and mitred at each corner
(tangency-labs/smlib#43), so most walls start further along the path: 39 of a
44-face sweep came out as end caps (105 of 110 before the previous commit). The
sweep records each face's origin as it builds it (Body::history), and
sweep_origins now returns those, finding by geometry only a face the tool names
no origin for. swept_origins says what it holds for.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
jyviko
2026-10-29 22:11:21 -04:00
committed by Irakli Kourtis
parent 1ee5f1af30
commit 1e4b644028
1 changed files with 16 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/kernel/src/provenance.rs
+16 -25
View File
@@ -309,7 +309,10 @@ pub fn offset_origins(result: &Body, input: &Body, thickness: f64, prov: &mut Hi
/// Origins of any swept tool's faces (sweep, loft, pipe; extrude and revolve too) from where
/// they start: the face lying in the profile's plane is the start cap, a face with an edge in
/// that plane sweeps the profile segment under the edge, and the rest are end caps.
/// that plane sweeps the profile segment under the edge, and the rest are end caps. That holds
/// for a tool whose every wall runs the whole path; one swept piece by piece along its path
/// (SMLib's sweep along lines and arcs, mitred at each corner) has walls starting further on,
/// which only the tool's own history names ([`sweep_origins`]).
pub fn swept_origins(tool: &Body, plane: &Plane, regions: &[Region2]) -> Result<Vec<FaceOrigin>> {
let size = tool.size().max(1e-9);
let m = tool.mesh(&crate::MeshTolerance::chord(size * 2e-4))?;
@@ -339,32 +342,20 @@ pub fn swept_origins(tool: &Body, plane: &Plane, regions: &[Region2]) -> Result<
Ok(out)
}
/// Origins of a [`crate::sweep_path`] tool's faces. Its walls come in profile order (once for
/// smooth walls, once per station for ruled ones) followed by the start and end caps; checked
/// against the start cap lying in the profile's plane, else found as [`swept_origins`] does.
/// Origins of a [`crate::sweep_path`] tool's faces: the ones the sweep recorded as it built them
/// ([`Body::history`]: the start and end caps, each wall from the profile segment it sweeps,
/// along every piece of the path), the first of each face's; a face the tool names no origin
/// for (or a tool without a history) found as [`swept_origins`] does.
pub fn sweep_origins(tool: &Body, plane: &Plane, regions: &[Region2]) -> Result<Vec<FaceOrigin>> {
let n = tool.face_count();
let k = segments(regions).len();
let size = tool.size().max(1e-9);
if k > 0 && n >= 2 && (n - 2).is_multiple_of(k) {
let m = tool.mesh(&crate::MeshTolerance::chord(size * 2e-4))?;
let faces = face_tris(&m);
let start_flat = faces.get(n - 2).is_some_and(|f| f.tris.iter().all(|(t, _)| t.iter().all(|p| plane.height(*p).abs() <= size * 1e-6)));
if start_flat {
return Ok((0..n)
.map(|i| {
if i + 2 == n {
FaceOrigin::Cap { end: false }
} else if i + 1 == n {
FaceOrigin::Cap { end: true }
} else {
FaceOrigin::Profile { segment: i % k }
}
})
.collect());
}
let recorded: Vec<Option<FaceOrigin>> = match tool.history() {
Some(h) if h.faces.len() == tool.face_count() => h.faces.iter().map(|f| f.origins.first().copied()).collect(),
_ => vec![None; tool.face_count()],
};
if recorded.iter().all(Option::is_some) {
return Ok(recorded.into_iter().flatten().collect());
}
swept_origins(tool, plane, regions)
let found = swept_origins(tool, plane, regions)?;
Ok(recorded.into_iter().zip(found).map(|(r, f)| r.unwrap_or(f)).collect())
}
/// Replace origins on operand `operand` (a tool made by the operation) with that tool's own