masi/solvecraft
1
0
Fork 0
mirror of https://github.com/bherbruck/solidcraft.git synced 2026-11-04 11:05:56 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

kernel: a trimmed piece's side is read at a point inside it, exactly

Browse Source 
trim_keep told each piece's side of the tool from the tool's field at the
centres of its mesh triangles. Each piece now takes one point on its own
surface inside its trims (SMLib's CalculateAnInternalPoint, through
smlib_face_points), mapped to the record's face order through SMLib's
numbering of the split body; the tool's field there says the side. A piece
whose side can't be told is an error, never guessed.

(not built: base in progress; no errors in this file)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
This commit is contained in:
jyviko
2026-10-22 07:17:16 -04:00
parent c802458efa
commit 453a4dec77
1 changed files with 18 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/kernel/src/surface_trim.rs
+18 -17
View File
@@ -57,8 +57,8 @@ pub fn trim(body: &Body, tool: &SplitTool, keep: Vec3) -> Result<Body> {
/// A surface body trimmed by a tool, keeping what `keep` says. Each kept face is the face it is
/// a piece of (its history is over `[body]`).
///
/// The body is split where the tool meets it ([`crate::splitface::split_any`]) and the pieces
/// not kept are taken away ([`crate::remove_faces`]); both carry their history, so the kept
/// The body is split where the tool meets it ([`crate::splitface::split_any`]), each piece's side
/// read at a point inside it ([`face_sides`]), and the pieces not kept are taken away ([`crate::remove_faces`]); both carry their history, so the kept
/// faces are the body's own, cut.
pub fn trim_keep(body: &Body, tool: &SplitTool, keep: TrimKeep) -> Result<Body> {
body.require_brep("trim")?;
@@ -95,23 +95,24 @@ pub fn trim_keep(body: &Body, tool: &SplitTool, keep: TrimKeep) -> Result<Body>
Ok(crate::record::after(trimmed, &split, &crate::record::counts(&[body])))
}
/// The side of the tool each face of `body` (in its face order) lies on: the tool's field at
/// the centre of the face's mesh triangle where it is largest (a face lies on one side once
/// the tool has cut it; on the tool's own surface the field is the rounding of zero).
/// The side of the tool each face of `body` (in its face order) lies on: the tool's field at a
/// point inside the face, on its surface and inside its trims (SMLib's
/// `CalculateAnInternalPoint`). Once the tool has cut the body each piece lies on one side, so
/// one such point says which.
fn face_sides(body: &Body, side: &ToolSide) -> Result<Vec<f64>> {
let m = body.mesh(&crate::MeshTolerance::chord(body.size() * 2e-3))?;
let mut best = vec![0.0f64; body.face_count()];
for (t, f) in m.triangles.iter().zip(&m.tri_face) {
let Some([a, b, c]) = m.tri(t) else { continue };
let x = side.at((a + b + c) / 3.0);
if let Some(slot) = best.get_mut(*f as usize)
&& x.is_finite()
&& x.abs() > slot.abs()
{
*slot = x;
}
let (sm, order) = crate::native::smlib_body_ordered(body)?;
let order = order.ok_or_else(|| KernelError::Failed("trim: SMLib numbers the pieces' faces differently from their record".into()))?;
let points = sm.face_points().map_err(|e| KernelError::Failed(format!("SMLib trim: a point inside each piece: {e}")))?;
let mut sides = vec![f64::NAN; points.len()];
for (i, p) in points.iter().enumerate() {
let face = if order.faces.is_empty() { i } else { order.faces.get(i).copied().unwrap_or(usize::MAX) };
let slot = sides.get_mut(face).ok_or_else(|| KernelError::Failed("trim: a piece's face lies outside the body".into()))?;
*slot = side.at(Vec3::new(p[0], p[1], p[2]));
}
Ok(best)
if sides.iter().any(|x| !x.is_finite()) {
return Err(KernelError::Failed("trim: the side of a piece can't be told".into()));
}
Ok(sides)
}
/// For each point, the face of `body` nearest it (over one tessellation).