From 5140556c71b4debbebb0c596098fcbb04a0d6bcf Mon Sep 17 00:00:00 2001 From: Brett Lawson Date: Thu, 29 Oct 2026 00:07:03 +0100 Subject: [PATCH] Blend refusals name their solidcore issues (#960, #1438, #1439, #430) Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01SdcgExNEwfR9CX2RAzp2Pt --- crates/smlib/src/core/blend.rs | 8 ++++---- crates/smlib/src/core/blend_tests.rs | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/crates/smlib/src/core/blend.rs b/crates/smlib/src/core/blend.rs index 9298127fe7..f4a98fd623 100644 --- a/crates/smlib/src/core/blend.rs +++ b/crates/smlib/src/core/blend.rs @@ -14,12 +14,12 @@ //! What the capi asks of fork-only SMLib code that solidcore does not have is //! [`Error::Unsupported`], refused where the capi would first reach it, so every error before //! it is the C++ path's: -//! - a curvature-continuous blend (`SetBlendCurveAtThirds`, fork fd3b6a7); -//! - a corner left open (`SetMarkCornerPatches`, fork 60af574); -//! - a variable radius whose law has a corner (`SplitFilletFacesAtRadiusCorners`, fork 6eecf04). +//! - a curvature-continuous blend (`SetBlendCurveAtThirds`, fork fd3b6a7; solidcore#1438); +//! - a corner left open (`SetMarkCornerPatches`, fork 60af574; solidcore#1439); +//! - a variable radius whose law has a corner (`SplitFilletFacesAtRadiusCorners`, fork 6eecf04; solidcore#430, PR #1403). //! //! - a blend whose rail leaves its face, which the fork may build over the cliff -//! (`SmFilletCliffOverflow.cpp`, fork 8ba4667) and solidcore always refuses ([`blend_failure`]). +//! (`SmFilletCliffOverflow.cpp`, fork 8ba4667; solidcore#960) and solidcore always refuses ([`blend_failure`]). //! //! solidcore's own refusals of code it has not ported (`SolidError::Unported`) are //! [`Error::Unsupported`] too. diff --git a/crates/smlib/src/core/blend_tests.rs b/crates/smlib/src/core/blend_tests.rs index 4fee82a5ee..6b438108bb 100644 --- a/crates/smlib/src/core/blend_tests.rs +++ b/crates/smlib/src/core/blend_tests.rs @@ -360,7 +360,7 @@ cases!( fillet_cylinder_rim, setback_corner, fillet_variable_linear, - fillet_over_a_cliff: ignore = "solidcore: no cliff overflow (fork 8ba4667)", + fillet_over_a_cliff: ignore = "solidcore#960: no cliff overflow (fork 8ba4667)", fillet_too_large, pick_near_nothing, pick_ambiguous,