masi/solvecraft
1
0
Fork 0
mirror of https://github.com/bherbruck/solidcraft.git synced 2026-11-03 10:35:58 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

smlib: solidcore's tangent-face edge check and horn-torus revolve opt-ins are on

Browse Source 
edge_check_orders_tangent_faces (solidcore#1684, fork 5533bbb) and
revolve_arc_touching_axis_is_horn_torus (solidcore#1679, fork c4e378d) are
both in SMLIB_REV 1ccd4612. precise_properties_trim_base_v (solidcore#1664,
WR-563) stays off: the fork has no commit for it, so the C++ kernel still
starts the area integrals at the domain's lowest v. The flag test now names
what is held back.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
This commit is contained in:
Brett Lawson
2026-10-30 12:04:08 +01:00
parent f4eec76b4b
commit 5314031ba3
1 changed files with 16 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/smlib/src/core.rs
+16 -3
View File
@@ -49,8 +49,8 @@ impl Body {
/// The fixes this backend runs with: every one of solidcore's opt-in fixes of upstream SMLib
/// defects (`UpstreamFixes`, each naming its record and issue). They are all fixes; the C++ fork
/// carries most of them in its own sources. A test checks none is left off, so moving the
/// solidcore pin to a rev with a new flag fails until it is added here.
/// carries most of them in its own sources. A test checks none is left off but those in
/// `HELD_BACK`, so moving the solidcore pin to a rev with a new flag fails until it is added here.
pub(crate) fn fixes() -> UpstreamFixes {
let mut f = UpstreamFixes::default();
f.fillet_retry_radius_as_first = true;
@@ -178,9 +178,17 @@ pub(crate) fn fixes() -> UpstreamFixes {
f.torus_check_reads_v_interval = true;
f.torus_check_spindle_apex = true;
f.local_operation_step_walls = true;
f.edge_check_orders_tangent_faces = true;
f.revolve_arc_touching_axis_is_horn_torus = true;
f
}
/// Opt-in fixes left off because the C++ fork (`SMLIB_REV`) does not carry them yet, so turning
/// them on would part this backend from the C++ one. `precise_properties_trim_base_v`
/// (solidcore#1664, WR-563) has no fork commit.
#[cfg(test)]
const HELD_BACK: &[&str] = &["precise_properties_trim_base_v"];
fn fresh() -> Kernel {
let mut k = Kernel::new(&KernelOptions::default());
k.fixes = fixes();
@@ -315,7 +323,12 @@ mod tests {
#[test]
fn every_upstream_fix_is_on() {
let f = format!("{:?}", fixes());
assert!(!f.contains(": false"), "an UpstreamFixes flag is off: {f}");
let off: Vec<&str> =
f.split([',', '{', '}']).filter_map(|kv| kv.trim().strip_suffix(": false")).filter(|name| !HELD_BACK.contains(name)).collect();
assert!(off.is_empty(), "UpstreamFixes flags are off: {off:?}");
for name in HELD_BACK {
assert!(f.contains(&format!("{name}: false")), "{name} is on or gone: drop it from HELD_BACK");
}
}
#[test]