From 58aeab658d05e4e01dc4e73a99d84374f06ad3dd Mon Sep 17 00:00:00 2001 From: Thijs Damsma Date: Sat, 31 Oct 2026 05:38:08 +0100 Subject: [PATCH] plan: WR-464 addendum: the fork's test needs a test-only surface subclass Co-Authored-By: Claude Opus 5.5 (1M context) Claude-Session: https://claude.ai/code/session_01PqrY3KqUA9vpCbwBCMF1av --- ...e-inert-by-construction--addendum-2026-10-31-fork-test.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 plan/findings/general--flag-pin-wr464-missing-surface-inert-by-construction--addendum-2026-10-31-fork-test.md diff --git a/plan/findings/general--flag-pin-wr464-missing-surface-inert-by-construction--addendum-2026-10-31-fork-test.md b/plan/findings/general--flag-pin-wr464-missing-surface-inert-by-construction--addendum-2026-10-31-fork-test.md new file mode 100644 index 0000000000..5ab871ead2 --- /dev/null +++ b/plan/findings/general--flag-pin-wr464-missing-surface-inert-by-construction--addendum-2026-10-31-fork-test.md @@ -0,0 +1,5 @@ +# General: WR-464 addendum: the fork's own test needs a test-only surface subclass (2026-10-31) + +Updates: plan/findings/general--flag-pin-wr464-missing-surface-inert-by-construction.md + +The fork's capi test (758829c) makes the missing offset with `NoOffsetCylinder`, a test-only `SmCylinder` subclass whose `CreateOffsetSurface` returns no surface. The port's closed `Surface` enum cannot express that, so the test cannot be ported. Reverting the hunk on the fork does not link either: it removes `OffsetCollapses`, which the test calls.