masi/solvecraft
1
0
Fork 0
mirror of https://github.com/bherbruck/solidcraft.git synced 2026-11-04 11:05:56 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

smlib: solidcore's three new fork-carried opt-ins are on; the blend-curve revolve opt-in waits

Browse Source 
local_operation_closes_walls_to_nothing (WR-566, smlib@ccbf77a), linear_sweep_arc_to_cylinder_zero
(WR-576, smlib@fd59111) and imprint_reuses_coincident_face_edge (WR-580, smlib@81cd61a) are on:
their fork commits are in SMLIB_REV f8fd83e2. fillet_blend_curve_revolved_on_arc (WR-581,
solidcore#1759) is an own design with no fork commit yet, so it goes on HELD_BACK.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
This commit is contained in:
Brett Lawson
2026-10-30 20:15:56 +01:00
parent ccfa37a9ba
commit 8d47118ff8
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/smlib/src/core.rs
+7 -3
View File
@@ -191,15 +191,19 @@ pub(crate) fn fixes() -> UpstreamFixes {
f.approximate_surface_bezier_starter = true;
f.proto_edge_splits_at_captured_vertices = true;
f.stitch_solid_nests_cavities = true;
f.local_operation_closes_walls_to_nothing = true;
f.linear_sweep_arc_to_cylinder_zero = true;
f.imprint_reuses_coincident_face_edge = true;
f
}
/// Opt-in fixes left off because the C++ fork (`SMLIB_REV`) does not carry them yet, so turning
/// them on would part this backend from the C++ one. `precise_properties_trim_base_v`
/// (solidcore#1664, WR-563) and `bspline_trim_keeps_rational_end_spans` (solidcore#1711, WR-575)
/// have no fork commit.
/// (solidcore#1664, WR-563), `bspline_trim_keeps_rational_end_spans` (solidcore#1711, WR-575) and
/// `fillet_blend_curve_revolved_on_arc` (solidcore#1759, WR-581, an own design waiting for the
/// fork's fix) have no fork commit.
#[cfg(test)]
const HELD_BACK: &[&str] = &["precise_properties_trim_base_v", "bspline_trim_keeps_rational_end_spans"];
const HELD_BACK: &[&str] = &["precise_properties_trim_base_v", "bspline_trim_keeps_rational_end_spans", "fillet_blend_curve_revolved_on_arc"];
fn fresh() -> Kernel {
let mut k = Kernel::new(&KernelOptions::default());