masi/solvecraft
1
0
Fork 0
mirror of https://github.com/bherbruck/solidcraft.git synced 2026-11-05 03:25:58 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

Mesh convert: a reconstructed bore is one wall, so the bracket has 9 faces

Browse Source 
The L's six sides, its two caps and the bore: since tangency-labs/smlib#67 the
full circle the conversion fits extrudes to one full-turn wall, not two halves.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
jyviko
2026-10-30 16:03:31 -04:00
committed by jyviko
parent 2c19013710
commit 8ed4663ae8
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/engine/src/tests/mesh_convert.rs
+2 -1
View File
@@ -141,7 +141,8 @@ fn exported_binary_stl_with_a_bore_reconstructs_analytic_faces() {
assert!(!body.is_mesh());
assert!(body.validity().is_empty());
assert_eq!(solidcraft_kernel::measure(body).unwrap().merged.face_types.get("cylinder"), Some(&1));
assert_eq!(body.faces(0.01).unwrap().len(), 10);
// The L's six sides, the two caps and the bore, one full-turn wall.
assert_eq!(body.faces(0.01).unwrap().len(), 9);
std::fs::remove_file(path).unwrap();
}