masi/solvecraft
1
0
Fork 0
mirror of https://github.com/bherbruck/solidcraft.git synced 2026-11-04 19:15:57 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

Turn on solidcore's new fixes at 2dbd88b6e

Browse Source 
The eight UpstreamFixes flags new since adf26ddbc, all on; HELD_BACK stays
empty: none is broken by the flag rule.

Toggled on the rig on solidcore (all eight off against on, then each alone
off on the 43 cases whose volume moved): 982/1014 pass either way, no case
changes status, the largest volume change is 1.35e-8 relative.
- fillet_overflow_trim_at_creases (#2279): 19 cases, up to 1.35e-8. The
  sloped basin rounds move toward their closed forms (r4 1.24e-8 -> 2.1e-10
  off, r4 2 edges 6.1e-9 -> 4.3e-10); 4055's bar chamfer over a joined pin
  moves from 2e-11 to 1.35e-8 off its closed form, inside its tolerance.
- face_shrink_bound_on_knot (#2281): 9 cases, at most 5.7e-13.
- swap_uv_keeps_analytic_definition (#2281): 11 cases (tapered booleans,
  shells, an oblique cone rim), at most 3e-14.
- face_trim_curves_kept_where_exact (#2281): 10 cases, last bits only.
- offset_updates_result_tolerances (#2297),
  fillet_section_end_trim_at_creases (#2302, solidcore#2223),
  boolean_coincident_strip_drops_crossing (#2285),
  cone_iso_circle_at_axial_height (#2289): no rig case moves.
No boolean, shell or offset case moves by more than 5.7e-13. The tangent-peg
cases of solidcore#2256 keep their statuses, volumes and checks bit for bit.
Rig time 1433 s off, 1344 s on; 3368-two-faceted-prisms-cut-then-joined
timed out once in the flags-off rig and passes alone with them off in 152 s
at the same volume.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
This commit is contained in:
brett19
2026-11-01 19:14:46 -07:00
parent 5ec92b0ba2
commit 92618ac4c5
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/smlib/src/core.rs
+8
View File
@@ -366,6 +366,14 @@ pub(crate) fn fixes() -> UpstreamFixes {
f.fillet_surface_plane_curve_on_plane_equation = true;
f.fillet_extended_rail_end_at_side_edge_crossing = true;
f.fillet_gn_section_generator = true;
f.face_trim_curves_kept_where_exact = true;
f.swap_uv_keeps_analytic_definition = true;
f.face_shrink_bound_on_knot = true;
f.offset_updates_result_tolerances = true;
f.cone_iso_circle_at_axial_height = true;
f.boolean_coincident_strip_drops_crossing = true;
f.fillet_overflow_trim_at_creases = true;
f.fillet_section_end_trim_at_creases = true;
f
}