masi/solvecraft
1
0
Fork 0
mirror of https://github.com/bherbruck/solidcraft.git synced 2026-11-03 10:35:58 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

Tests: a round run on through an earlier one by tangent propagation is matched by the same edges together

Browse Source 
The arc part's front edge rounded r2, then its left top edge with tangent
propagation (the Fillet feature's default): that edge runs on round the first
round's end arc and down the left front upright, so three edges end up rounded
(a sphere octant at the corner where they meet), not two. Both results were
exact: 9530.77 (meshed) is the part less three r2 strips and the octant,
9591.44 − (0.858407·(39.1667 + 19 + 8) + 8(1 − π/6)) = 9530.83; 9538.79 is
two strips less their overlap, 9591.44 − (0.858407·62.1667 − 0.7670) =
9538.84. The test compares the sequential rounds with the same edges of the
part rounded together: the picks' chains and every edge of the part the second
chain carried on into.

The other pairs still fail in SMLib (1001, or SM_ERR_INVALID_INPUT at the
knife-edge tip) where a later round ends on the first round's arc.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
jyviko
2026-10-29 00:53:06 -04:00
committed by Irakli Kourtis
parent 0ec97c5708
commit 94d763c839
1 changed files with 14 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/kernel/src/curvecorner_tests.rs
+14 -7
View File
@@ -251,18 +251,25 @@ fn the_arc_rounded_after_the_back_edge_matches_both_together() {
one_then_the_other(BACK, arc_top());
}
/// The edge at `first` rounded (2), then the one at `then` as a fillet of its own, against both
/// rounded together; each with its tangent chain, as the Fillet feature rounds by default (tangent
/// propagation).
/// The edge at `first` rounded (2), then the one at `then` as a fillet of its own, each with its
/// tangent chain as the Fillet feature rounds by default (tangent propagation), against the same
/// edges of the part rounded together: the picks' chains, and every edge of the part that the
/// second round's chain carried on into across the first round (the left front upright, after
/// the front edge's round: the left top edge runs on round that round's end arc and down the
/// upright, a sphere octant at the corner where the three rounds meet).
fn one_then_the_other(first: Vec3, then: Vec3) {
let body = arc_part();
let chained = |b: &Body, pts: &[Vec3]| crate::tangent_chain(b, pts).unwrap();
let step = crate::fillet(&body, &chained(&body, &[first]), 2.0).unwrap();
let after = crate::fillet(&step, &chained(&step, &[then]), 2.0).unwrap();
let step = crate::fillet(&body, &chained(&body, &[first]), 2.0).unwrap_or_else(|e| panic!("{first:?}: {e}"));
let second = chained(&step, &[then]);
let after = crate::fillet(&step, &second, 2.0).unwrap_or_else(|e| panic!("{first:?} then {then:?}: {e}"));
let v = volume(&after);
let together = volume(&crate::fillet(&body, &chained(&body, &[first, then]), 2.0).unwrap());
// The part's own edges among the second chain's (points on an edge of the part).
let mut picks = vec![first, then];
picks.extend(second.iter().skip(1).filter(|p| crate::tangent_chain(&body, &[**p]).is_ok()));
let together = volume(&crate::fillet(&body, &chained(&body, &picks), 2.0).unwrap());
// Within the display meshes' accuracy (two different B-reps, meshed apart).
assert!((v - together).abs() < 5e-3, "{first:?} then {then:?}: {v} vs together {together}");
assert!((v - together).abs() < 5e-3, "{first:?} then {then:?}: {v} vs together {together} ({picks:?})");
}
/// Edges rounded together come out the same in any order: a round made first doesn't carry the