masi/solvecraft
1
0
Fork 0
mirror of https://github.com/bherbruck/solidcraft.git synced 2026-11-05 11:35:55 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

smlib: the solidcore tag test names what still holds it back

Browse Source 
solidcore#1568 (#1462 P1) carries a B-rep's attributes through a boolean, but the tags
`Brep::tagged` puts on the C++ body never reach solidcore: the crossing is the capi's flat
arrays, which carry no attributes (smlib.h, smlib_flat.cpp), and the history is read back
on the C++ body after the same crossing. tags_cross_a_solidcore_boolean stays ignored, its
reason now that crossing rather than solidcore.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
This commit is contained in:
Brett Lawson
2026-10-30 04:44:41 +01:00
parent 2ad118666f
commit 97d79e3b88
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/smlib/src/core/boolean_tests.rs
+1 -1
View File
@@ -367,7 +367,7 @@ mod history {
}
#[test]
#[ignore = "solidcore has no way to carry attributes through a boolean: tangency-labs/solidcore#1462"]
#[ignore = "the tags do not cross the flat arrays (smlib_flat.cpp carries no attributes), so the operands reach solidcore untagged; solidcore#1568 carries attributes through the boolean itself"]
fn tags_cross_a_solidcore_boolean() {
let (a, b) = (tagged_box([0.0; 3], 0), tagged_box([5.0; 3], 1));
let r = super::boolean(a.core().unwrap(), b.core().unwrap(), BooleanOp::Union).unwrap().unwrap();