mirror of
https://github.com/bherbruck/solidcraft.git
synced 2026-11-08 04:52:10 +00:00
Merge pull request #1849 from tangency-labs/plan/wr604-renumber-674
plan: renumber #674's record WR-583 -> WR-604 (ID collision)
This commit is contained in:
@@ -145,7 +145,7 @@ impl Caches {
|
||||
#[allow(clippy::struct_excessive_bools)]
|
||||
#[non_exhaustive]
|
||||
pub struct UpstreamFixes {
|
||||
/// `SmFilletGeom::Trim` returns the first curve/surface trim or interval-intersection error instead of dropping it and continuing with an unset interval (WR-583, #483). Earlier successful edits remain; off by default for pinned C++ parity.
|
||||
/// `SmFilletGeom::Trim` returns the first curve/surface trim or interval-intersection error instead of dropping it and continuing with an unset interval (WR-604, #483). Earlier successful edits remain; off by default for pinned C++ parity.
|
||||
pub fillet_trim_status: bool,
|
||||
/// `CalcRailIntEdgeuse`'s retry rail search holds a variable round's radius only where its first search does (at a corner calculated as constant radius), so the rail misses the arc it would meet only at that radius and the corner cuts the round off against the body; needs `fillet_nx1_end_rib_global_merge` there (WR-300, #1023).
|
||||
pub fillet_retry_radius_as_first: bool,
|
||||
|
||||
+1
-1
@@ -4,7 +4,7 @@ Updates: plan/findings/blend.fillet_geom_p1--fillet-trim-status-483.md
|
||||
|
||||
PR #674 follows the default-off `UpstreamFixes` policy. The same failing inputs
|
||||
now preserve the pinned C++ result by default. `Kernel::fixes.fillet_trim_status`
|
||||
enables the first-error behavior described in the original finding (WR-583).
|
||||
enables the first-error behavior described in the original finding (WR-604).
|
||||
Both modes preserve visitation order and successful prefix edits; neither rolls
|
||||
back. The broader boolean, sweep and offset paths in #483 remain separate work.
|
||||
|
||||
|
||||
+2
-2
@@ -1,6 +1,6 @@
|
||||
Updates: WR-583
|
||||
Updates: WR-604
|
||||
|
||||
#### WR-583 addendum (2026-10-30): opt-in error propagation
|
||||
#### WR-604 addendum (2026-10-30): opt-in error propagation
|
||||
|
||||
`Kernel::fixes.fillet_trim_status` enables first-error propagation for the primary
|
||||
rails, both other-rail lists, center line, intersections and surface trim. It is
|
||||
+1
-1
@@ -1,4 +1,4 @@
|
||||
#### WR-583. `SmFilletGeom::Trim` drops trim and intersection errors (#483)
|
||||
#### WR-604. `SmFilletGeom::Trim` drops trim and intersection errors (#483)
|
||||
- **Severity:** Wrong result
|
||||
- **Area:** Fillets and blends
|
||||
- **Location:** `source/SMLib/src/SmFilletGeom.cpp:10333`, `SmFilletGeom::Trim` at pinned v1.0.1 (`3fd5b95`).
|
||||
Reference in New Issue
Block a user