masi/solvecraft
1
0
Fork 0
mirror of https://github.com/bherbruck/solidcraft.git synced 2026-11-04 11:05:56 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

Kernel rig: threads/2369 names the tap maker's 6.8 mm drill for M8

Browse Source 
The case expected "drill 6.75 mm for M8", the major diameter less the pitch.
Since 05f1c6b9a (Tapped holes: the tap maker's drill for every form) a tabulated
size names the tap maker's drill, 6.8 mm for M8 x 1.25 (Yamawa YEU23 p.704), as
case 2115 already grades and engine thread_tests.rs asserts; major less pitch
is for a size no table lists. The refusal itself and its reason are unchanged.
The case passes and leaves threads/KNOWN_FAILING.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
jyviko
2026-10-29 22:11:16 -04:00
committed by Irakli Kourtis
parent a0a75dc781
commit beaed5b351
2 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/kernel-cases/threads/2369-m8-thread-in-6.3mm-hole-refused/expected.json
+2 -2
View File
@@ -7,7 +7,7 @@
],
"what": "a modelled thread on a hole that isn't the thread's size: refused with the size to use, never a silent change of the hole",
"source": "analytic",
"method": "Decision (#1018, #2853): a modelled thread never changes the size of the hole it is on; one that isn't the thread's size is refused, naming the size to use. A fill-to-tap-drill or turn-down option would be opt-in, off by default (see #3060), and get its own case. The refusal's numbers, from ISO 68-1 (H = P sqrt3/2, basic depth 5H/8): M8 (P 1.25): tap drill = 8 - 1.25 = 6.75 mm; basic minor diameter D1 = 8 - 2 x 5H/8 = 8 - 1.353 = 6.647 mm; a 6.3 mm hole is below the minor diameter, so the thread's teeth would fill part of the hole. Expected message: \"this 6.3 mm hole is too narrow for a modelled M8 thread (its teeth would fill the hole); drill 6.75 mm for M8\".",
"method": "Decision (#1018, #2853): a modelled thread never changes the size of the hole it is on; one that isn't the thread's size is refused, naming the size to use. A fill-to-tap-drill or turn-down option would be opt-in, off by default (see #3060), and get its own case. The refusal's numbers, from ISO 68-1 (H = P sqrt3/2, basic depth 5H/8): M8 (P 1.25): the tap drill is the tap maker's, 6.8 mm (Yamawa YEU23 p.704, as tapped holes take it since 05f1c6b9a and case 2115 grades; major minus pitch, 6.75 mm, is only for a size no table lists); basic minor diameter D1 = 8 - 2 x 5H/8 = 8 - 1.353 = 6.647 mm; a 6.3 mm hole is below the minor diameter, so the thread's teeth would fill part of the hole. Expected message: \"this 6.3 mm hole is too narrow for a modelled M8 thread (its teeth would fill the hole); drill 6.8 mm for M8\".",
"outcome": "refused",
"refusal": "this 6.3 mm hole is too narrow for a modelled M8 thread (its teeth would fill the hole); drill 6.75 mm for M8"
"refusal": "this 6.3 mm hole is too narrow for a modelled M8 thread (its teeth would fill the hole); drill 6.8 mm for M8"
}
tests/kernel-cases/threads/KNOWN_FAILING
-1
View File
@@ -2,4 +2,3 @@
# rig gate (.github/workflows/kernel-rig.yml) fails on a case that fails and is not listed here,
# and on a listed case that passes: a fix removes its line in the same pull request.
# Baseline: develop 5ada4fc8a with SMLib 90aabff (the run on 60b1c6a, aarch64 Linux).
2369-m8-thread-in-6.3mm-hole-refused refused for the right reason, but the message differs from the one the case names