masi/solvecraft
1
0
Fork 0
mirror of https://github.com/bherbruck/solidcraft.git synced 2026-11-04 02:55:54 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

smlib: solidcore's four fork-carried opt-ins are on; only the trim base v opt-in waits

Browse Source 
fillet_torus_span_from_start_section (WR-568, smlib@985faae), fillet_knife_edge_rounds (WR-570,
smlib@b7ec55b), taper_wall_closes_at_apex (WR-571, smlib@183ea65) and
revolution_round_offset_collapses (WR-567, smlib@8b2090f) are on: their fork commits are in
SMLIB_REV 985faaee. HELD_BACK keeps only precise_properties_trim_base_v, which has no fork commit.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
This commit is contained in:
Brett Lawson
2026-10-30 14:56:39 +01:00
parent b60963b12c
commit cf2a15ace8
1 changed files with 6 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/smlib/src/core.rs
+6 -11
View File
@@ -182,23 +182,18 @@ pub(crate) fn fixes() -> UpstreamFixes {
f.edge_check_orders_tangent_faces = true;
f.revolve_arc_touching_axis_is_horn_torus = true;
f.thicken_planar_side_walls = true;
f.fillet_torus_span_from_start_section = true;
f.fillet_knife_edge_rounds = true;
f.taper_wall_closes_at_apex = true;
f.revolution_round_offset_collapses = true;
f
}
/// Opt-in fixes left off because the C++ fork (`SMLIB_REV`) does not carry them yet, so turning
/// them on would part this backend from the C++ one. `precise_properties_trim_base_v`
/// (solidcore#1664, WR-563) has no fork commit; the others' fork commits are past `SMLIB_REV`:
/// `fillet_torus_span_from_start_section` (WR-568, smlib@985faae), `fillet_knife_edge_rounds`
/// (WR-570, smlib@b7ec55b), `taper_wall_closes_at_apex` (WR-571, smlib@183ea65) and
/// `revolution_round_offset_collapses` (WR-567, smlib@8b2090f).
/// (solidcore#1664, WR-563) has no fork commit.
#[cfg(test)]
const HELD_BACK: &[&str] = &[
"precise_properties_trim_base_v",
"fillet_torus_span_from_start_section",
"fillet_knife_edge_rounds",
"taper_wall_closes_at_apex",
"revolution_round_offset_collapses",
];
const HELD_BACK: &[&str] = &["precise_properties_trim_base_v"];
fn fresh() -> Kernel {
let mut k = Kernel::new(&KernelOptions::default());