masi/solvecraft
1
0
Fork 0
mirror of https://github.com/bherbruck/solidcraft.git synced 2026-11-03 10:35:58 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

Thread: a boss thread keeps clear of the plate below

Browse Source 
A regression test for the groove stopping at the plate's top: the boss loses the
closed-form volume and the plate keeps all of its 9600 mm³, with and without a runout
and a chamfered tip.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
jyviko
2026-10-27 01:14:30 -04:00
committed by Irakli Kourtis
parent 81ecc872f5
commit d1a8f0417f
1 changed files with 40 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/engine/src/thread_tests.rs
+40
View File
@@ -521,6 +521,46 @@ fn a_thread_stops_clear_of_a_shoulder() {
assert!((got - want).abs() < want * 2e-4, "{got} vs {want}");
}
/// A d10 boss (z 6..22) joined onto a 40x40x6 plate, threaded M10: the plate's top is the
/// shoulder. The groove, with or without its runout, stays on the boss: the plate keeps all of
/// its 40 40 6 (what lies below z = 6 after the boss is cut away), and without a runout the
/// boss loses (16 - w)/P turns, as at a collar.
#[test]
fn a_thread_on_a_boss_never_cuts_into_the_plate_below() {
let boss = |extra: Value| {
let mut s = Session::default();
run(&mut s, "solid.box", json!({"corner": [-20, -20, 0], "length": 40, "width": 40, "height": 6, "body_name": "Part"}));
run(&mut s, "solid.cylinder", json!({"base": [0, 0, 6], "radius": 5, "height": 16, "operation": "join", "targets": ["Part"]}));
let mut p = json!({"face": [5, 0, 14], "designation": "M10", "modeled": true});
if let (Some(p), Value::Object(e)) = (p.as_object_mut(), extra) {
p.extend(e);
}
run(&mut s, "solid.thread", p);
s
};
let plate_left = |mut s: Session| {
run(
&mut s,
"solid.box",
json!({"corner": [-30, -30, 6], "length": 60, "width": 60, "height": 30, "body_name": "Above", "operation": "new_body"}),
);
run(&mut s, "solid.combine", json!({"target": "Part", "tools": ["Above"], "operation": "cut"}));
exact_volume(&s, "Part")
};
let s = boss(json!({}));
let (p, w) = (1.5, ext_half_width(10.0, 1.5));
let want = 40.0 * 40.0 * 6.0 + PI * 25.0 * 16.0 - (16.0 - w) / p * ext_turn(10.0, p, 5.0);
let got = exact_volume(&s, "Part");
assert!((got - want).abs() < want * 2e-4, "{got} vs {want}");
assert!((plate_left(s) - 9600.0).abs() < 1e-6);
for extra in [json!({"ease_out": "standard"}), json!({"ease_out": "short", "tip": "chamfer"})] {
let s = boss(extra.clone());
assert!(s.model.state().body("Part").unwrap().body.validity().is_empty(), "{extra}");
let left = plate_left(s);
assert!((left - 9600.0).abs() < 1e-6, "{extra}: the plate below the boss lost {} mm³", 9600.0 - left);
}
}
/// Rig 602: "from the end nearest the pick" took the head end for a pick a little above the
/// middle. A thread of limited length starts at the face's only free end, wherever it is picked.
#[test]