masi/solvecraft
1
0
Fork 0
mirror of https://github.com/bherbruck/solidcraft.git synced 2026-11-05 11:35:55 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

Isocurve test: the spline face's hole is an inner loop of one face (Refs #770)

Browse Source 
The fit-point spline's extruded side is two faces split at x = 20; the hole now
lies inside one of them, so the test clips to a real inner loop.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
jyviko
2026-10-27 20:55:43 -04:00
committed by Irakli Kourtis
parent be859aa0d4
commit f042d20736
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/engine/src/cmd/sketch_inspect.rs
+6 -5
View File
@@ -571,8 +571,9 @@ mod tests {
assert_eq!(meridians, 5, "the meridians run from pole to pole");
}
/// On a trimmed B-spline face (a spline profile's extruded side, with a hole through it) the
/// isocurves are the surface's own rows and columns and stay inside the face's loops.
/// On a trimmed B-spline face (a spline profile's extruded side, with a hole through it: an
/// inner loop) the isocurves are the surface's own rows and columns and stay inside the face's
/// loops.
#[test]
fn isocurves_of_a_trimmed_spline_face_stay_inside_it() {
let mut s = Session::default();
@@ -581,8 +582,8 @@ mod tests {
s.execute("sketch.line", &json!({"points": [[40, 0], [0, 0]]})).unwrap();
s.execute("sketch.finish", &json!({})).unwrap();
s.execute("solid.extrude", &json!({"distance": 30})).unwrap();
s.execute("solid.cylinder", &json!({"radius": 3, "height": 30, "base": [20, -10, 15], "axis": "Y", "operation": "cut"})).unwrap();
let r = s.execute("inspect.isocurve", &json!({"faces": [[20, 8, 5]], "count": 12})).unwrap();
s.execute("solid.cylinder", &json!({"radius": 3, "height": 30, "base": [28, -10, 15], "axis": "Y", "operation": "cut"})).unwrap();
let r = s.execute("inspect.isocurve", &json!({"faces": [[28, 6.7, 5]], "count": 12})).unwrap();
let face = &r["faces"][0];
assert!(face["u_curves"].as_u64().unwrap() >= 12 && face["v_curves"].as_u64().unwrap() >= 12, "{face}");
let st = s.model.state();
@@ -604,7 +605,7 @@ mod tests {
.fold(f64::INFINITY, f64::min);
assert!(d < 2.0 * tol, "on the spline face: {q:?} is {d} from it");
assert!((-1e-6..=30.0 + 1e-6).contains(&q[2]) && q[1] > -1e-6, "{q:?}");
assert!((q[0] - 20.0).hypot(q[2] - 15.0) > 3.0 - 1e-3, "not in the hole: {q:?}");
assert!((q[0] - 28.0).hypot(q[2] - 15.0) > 3.0 - 1e-3, "not in the hole: {q:?}");
}
}
}