masi/solvecraft
1
0
Fork 0
mirror of https://github.com/bherbruck/solidcraft.git synced 2026-11-03 18:45:55 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

kernel: a revolution that is no analytic surface goes into SMLib as its B-spline

Browse Source 
The analytic mapping refused every revolution that is none of SMLib's plane, cylinder, cone,
sphere or torus (a profile of any other curve, a placement that is no rigid motion), which
now also kept those faces from kernel-smlib's exact rational B-spline import (da7ccba9). Such a
face now stays a revolution, so the import sends it as its B-spline; the analytic surfaces are
still taken wherever they fit.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
This commit is contained in:
jyviko
2026-10-21 08:27:56 -04:00
parent d672cfa013
commit f35f06d98a
1 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/smlib/src/import/analytic.rs
+10 -3
View File
@@ -9,8 +9,9 @@
//! domain; where the analytic surface's natural normal is the other way round, the face is turned
//! over (its loops reversed, its uses in the shells flipped), which leaves the solid as it was.
//!
//! A revolution of any other profile, or one placed by a matrix that is not a rigid motion, is
//! refused; any other spline stays a spline.
//! A revolution of any other profile, or one placed by a matrix that is not a rigid motion,
//! stays a revolution, which the import sends as its exact rational B-spline; any other spline
//! stays a spline.
use std::borrow::Cow;
use std::f64::consts::{FRAC_PI_2, TAU};
@@ -32,8 +33,14 @@ pub(super) fn analytic(brep: &b::Brep) -> R<Cow<'_, b::Brep>> {
let mut turned = Vec::new();
for (i, f) in brep.faces.iter().enumerate() {
let found = match &f.surface {
// One that is none of the analytic kinds goes as its exact rational B-spline
// (`super::revolution`).
b::Surface::PlacedRevolution { profile, origin, axis, matrix, forward } => {
Some(Revolution::new(profile, *origin, *axis, matrix, *forward)?.analytic(f.domain)?)
match Revolution::new(profile, *origin, *axis, matrix, *forward).and_then(|r| r.analytic(f.domain)) {
Ok(found) => Some(found),
Err(Unsupported::NotYet(_)) => None,
Err(e) => return Err(e),
}
}
b::Surface::RationalSpline { u_knots, v_knots, homogeneous } => {
extruded_circle(u_knots, v_knots, homogeneous, f.domain, 1e-9 * size.max(1.0))