Commit Graph

3 Commits

Author SHA1 Message Date
bherbruck 524417385c surface.cone_p1: fourth review fixes
- total_coincidence_checker converts its tolerance as upstream's const
  SmApproxTol3d parameter (fabs, SM_USE_DEFAULT -> half the zone tolerance).
- CreateIsoCircleFromPoint ignores a failed ConvertUVFromSTEPToNURBS with
  swap_uv when the polar converter wrote the sweep value, as upstream does;
  the shim and runner refuse the cases where upstream reads an unset value.
- Deviation note for Cone::apex propagating a failed generator inversion.
- review4.json adversarial fixtures (7800 cases); counts refreshed.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BY8UpXKuMci15rAWGXsbsm
2026-10-14 09:18:36 -04:00
bherbruck aaac74a272 surface.cone_p1: third review fixes
- Cone::type_string returns SmCone_TYPE / SmCylinder_TYPE (SM_COMMON #ty);
  class_string returns SmCone / SmCylinder (#cl). Both are now compared in
  the state by the shim and the runner; unit-test asserts added.
- Runner generator: fix pinned-toolchain clippy lints (unnecessary_wraps,
  match_same_arms, same_functions_in_if_condition); RNG draw order unchanged.
- Add fixtures/surface.cone_p1/review3.json (4100 adversarial cases).
- Difftest: 12894 cases, 12426 pass, 0 failed, 468 deferred; perturb 12426/12426.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-14 00:28:22 -04:00
bherbruck 767ee2bc26 surface.cone_p1: port SmCone/SmCylinder part 1 with shim, ffi, runner, fixtures
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FsWWaoeGNWKgzeGrF2Pkn5
2026-10-13 19:33:44 -04:00