Files
solvecraft/docs/render-raytrace-core.md
selune 9e6e0b8df1 Render workspace: complete experimental ribbon, resources and effects integration (#5493) (#5494)
* wip(render): reconcile completed material and image pipeline source with 0.20 (#5493)

Source-only integration reference for staged review, not a merge-ready aggregate.
Donor: 0xlillith/solidcraft@aea20b0115.
Upstream: 858e5995d6.

Retain original CPU/material contracts and explicit GPU donor provenance in
docs/render-materials-lab.md (#2067, #2191, #2780, #3306). Preserve released
format migrations and current navigation/startup/shell behavior. New saved
records use pending descriptors. The physical-card descriptor follows the
maintainer's material-engineering-cards naming request, with a legacy-lab
format-29 regression. Replace raw new panel hosts with shared containers.

Repository checks, complete workspace/all-target Clippy, and the independent
physical/resource authoring checks pass for this source. The fresh full local
CI invocation has reached test compilation and is not yet complete. Do not
transfer donor native output or prior test totals to this integration.

Generated review screenshots, video, package ZIP and machine logs remain at
the immutable personal evidence pin. Uncommitted geometric displacement is
backed up separately, not silently included. No kernel/vendor change, direct
main write, release or independent contributor-branch rewrite.

Co-authored-by: Christian Svensson <blue@cmd.nu>

* test(cli): pin the Compact camera-sample admission diagnostic (#5493)

The bounded request still refuses 1024x1024x64 samples before host initialization and writes no output. Update only the stale expected diagnostic to the existing Compact budget wording; production limits and code are unchanged. Exact-tree CLI regression suite: 14 passed, 0 failed. The full repository gate has been invoked separately and is not yet complete.

* Normalize UI container violation paths across platforms

Report repository-relative paths with forward slashes so diagnostics and the existing nested-package regression assertions agree on Windows and Unix. Keep the container detection rules unchanged.

Validation: official ui-containers gate and all seven focused xtask tests passed; rustfmt and diff checks passed. Only xtask/dependencies were compiled; no application build or heavy tests.
(cherry picked from commit 44b58d8e10)

* fix(render): preserve camera contracts and correct acceptance regressions (#5493)

Preserve Design view.apply semantics with a separate strict Render camera command. Retain existing translations when English-only aliases collide; add material-axis entries and camera-specific pitch labels. Compare complete validated engineering cards and retain job handles before cancellation.

Focused and native acceptance is pinned to tree f8a423b21f. Full CI has been invoked separately and is not claimed green. Landing follows the render integration policy in #5493.

* fix(render): resolve showcase licence and upstream resource hygiene (#5493)

Record SychPL's explicit MIT OR Apache-2.0 grant, retaining source/model bytes and the Ubuntu lettering notice. Remove 80 absent attribution rows, personal fork records, dead delivery attributes and three fork/resource-only workflows. Existing xtask assets now performs bounded offline hash checks and rejects orphan render attribution; no parallel draft CI or package installation. Original authoring reproduction remains explicit. Scoped xtask tests, assets, Clippy, formatting and prepared SELENE validation pass; no application or renderer-wide result is inferred.

* fix(render): align saved bounds and progressive sample resolution (#5493)

Address review r4364211669/r4364211677/r4364211681/r4364211691/r4364211695. Persisted light/frame domains respect the existing 1e9 document bound; related LED/rectangle/direction cases use the same bound. Workstation primary resolve shares the 4096 admission cap and film counters use checked conversions. Exact candidate: 485 CPU render tests, 21 render document tests and strict scoped Clippy pass, including positive boundary round trips and 2048/4096 end-to-end checkpoints. No released format/migration edits, relaxed test limits or full-stack acceptance claim.

* wip(render): isolate optional resources and harden sample handling (#5493)

Review work in progress: opt-in encoded render library with reproducible runtime catalog exports; native-only robust dependency through the workspace; checked bloom slices; per-sample point-light diagnostics; independent area-light spatial/film keys. Resource-module binaries in both configurations, generation, Cargo production feature graphs and attribution checks pass. Full engine/render regression and combined acceptance are pending: do not merge this donor as a constituent or treat scoped resource proof as runtime acceptance.

* fix(gpu): preserve donor allocations through the scope-safety repair (#5722)

Port the native-validated #5723 scope-cleanup correction into the experimental donor, retaining its adaptive, volume, aging, photographic and bloom allocations. Same reverse-drain helper and regression cases; the donor combination still needs its own compile/test gate and is not covered retroactively by render-base results.

* claim: #1369

* Reject unknown pending concepts after format folding (#1369)

* test(render): close bounded sampling and bloom review regressions (#5493)

Validate the optional-resource/lighting/dependency donor at its exact tree. Required Vulkan GPU 127/0/3; CPU renderer 487/0; engine Render 72/0; document render 21/0; lean library 7/0; strict scoped Clippy, assets/layers/lists/containers and lean-engine WASM pass. Preserve original failed controller/typing attempts. This is the draft donor/disposition source, not a replacement for constituent render PRs or final main acceptance.

* wip(render): preserve stable aging target validation candidate

Exact staged source from prior review work on donor 3b892eab5e. This is a recovery/review checkpoint, NOT accepted delivery. An actual command-path regression currently fails because the selected executor refuses ordered surface aging. No assertion, capability or admission limit is weakened. Native/UI/full combination acceptance remains pending. Saved/runtime split adds one pending descriptor and retains original file scope; no main/render branch is changed.

* test(render): preserve numeric setup intent at the admitted coordinate bound

Follow up jyviko review on #5494 without weakening the corrected saved-coordinate contract. The positive clicked fixture uses 1e9 instead of inadmissible 2e9; explicit out-of-range cases still refuse, and the full saved setup round-trips through JSON and the native container. Exact-source Render workspace 95/0 and strict all-target UI Clippy pass. This does not incorporate the separately failing stable-aging candidate or claim full current-render acceptance.

* test(render): use the real GPU executor for saved aging

Move successful native cold-reopen Check/Start coverage from the CPU-backed protocol fixture into the production GPU executor tests. Verify capture-index changes preserve the stable target and that enabling aging changes both PNG and raw EXR output. Retain explicit, allocation-free refusal coverage for executors without aging support. Production capabilities and admission checks are unchanged.

* fix(render): persist stable identities for targeted aging (#5493)

Separate saved RenderBodyTarget identities from captured mesh ordinals. Reject legacy ambiguous targets, resolve Check/Start after visibility changes and preserve native reopening, copies and undo. Unsupported executors still refuse; real AMD Vulkan regression completes saved aging after reordered capture.

Source tree 6b84c8ad passes document 23, engine Render 75, GPU effects 5 and Render UI 95 with no failures; scoped strict Clippy, WASM and repository gates pass. Fresh CLI/native reopen and clean/aged GPU exports pass with identical physical totals and inspected actual images. Whole current-render integration is separate.

* fix(render): reconcile combined CPU/GPU contracts on current upstream

Unify captured resources/status and CPU-vs-GPU request schemas after the real two-parent integration; remove obsolete duplicate Vulkan selector and retain combined platform-filter regression. Deduplicate only identical or superseded test definitions, retaining the stronger card metadata and reserved-executor assertions. No assertions, admission limits or feature refusals are weakened.

All targets of render dependencies, GPU, engine, UI, CLI and native app pass cargo check with raytrace-cpu and bundled-render-library at tree c70d00d1. Native executable tests and full current-source acceptance remain pending. This is a private integration rehearsal for subsequent constituent PRs, not an aggregate official render/main merge.

* test(render): retain one complete host lifetime regression set

Deduplicate byte-identical DropProbe/task-lifetime tests and retain the adapted environment/texture ownership regressions with every assertion and complete memory estimate. Keep the registered-geometry admission regression once; only struct field order differed. Replace a one-element diagnostic loop with its equivalent block, preserving all wrap/width assertions.

Test-only integration repair. Formatting and diff checks pass; refreshed executable validation is required. No production behavior, limits, assertions or ignores changed.

* fix(doc): recognize the proven format-29 card descriptor alias

Normalize only the historical format-29 physical-material-cards spelling, and only when material-engineering-cards is registered. Admission and migration de-duplication use the same identity. Unknown concepts, wrong versions and incapable readers still refuse before mutation. Six controlled-history Rust regressions and actual CLI migration/no-clobber acceptance pass. No version, released migration or CI changes. Refs #5793, #1369, #5493.

* test(render): preserve grounding refusal before explicit instance moves

Update the two Render binding fixtures for upstream first-occurrence grounding. Verify grounded movement refuses without changing document/history, then explicitly unground through the public command before the intended move. Retain every target, resource, copy and persistence assertion. Refs #5493.

---------

Co-authored-by: Christian Svensson <blue@cmd.nu>
Co-authored-by: Victor Santos Oliveira <56417388+Vittuu@users.noreply.github.com>
Co-authored-by: cfaulkingham <colin.faulkingham@gmail.com>
2026-10-24 14:21:59 +00:00

7.1 KiB
Raw Permalink Blame History

Optional CPU triangle visibility core (RT1, #1368)

This page documents the RT1 numerical core, not the complete image consumer. The RT2 image contract covers native jobs and hard shadows. The combined HDR/reflection integration extends that consumer; its capabilities do not change this core's standalone scope. See the RT2 page's current integration limits before treating historical source checks as validation of the combined revision.

solidcraft-render exposes raytrace only with the explicit raytrace-cpu feature. The feature is off by default and adds no dependencies. This page describes the core alone. The separate RT2 consumer connects it to the existing image executor; neither unit adds a worker pool or persisted settings. This numerical core alone does not render an image or implement cast shadows, progressive transport, soft shadows, textures, HDRI, glass, denoising or GPU tracing.

The source is original safe Rust using elementary slab, barycentric and binary tree mathematics. No Blender/Cycles, PBRT or other tracer source was consulted or adapted. Only L0 Vec3 geometry and the existing render cancellation token are consumed; no truck, B-rep or SolidCore interface is involved.

Geometry and hit policy

Inputs are already world-space tessellation in millimetres. Instance transforms must not be applied again. Each admitted Ray normalizes its finite nonzero direction using scaled arithmetic; its closed finite [min, max] interval is therefore measured in millimetres. Origins and triangle vertices are limited to +/-1e12 mm; maximum ray distance is 4e12 mm. Ray direction magnitudes are not subject to a fixed small-vector epsilon.

Triangle admits coincident and collinear vertices, which produce no hits. Intersection projects into the plane perpendicular to the dominant ray axis, applies a shear, and evaluates closed-edge barycentrics. Both sides can hit. Geometric normals and the front-face flag are returned separately from any future shading normal. Zero projected area is a miss, including geometry that collapses in f64 arithmetic; this is not an exact CAD predicate or a universal watertightness guarantee. No fixed determinant threshold masks small triangles. Analytic source tests cover scales from 1e-120 to 1e11 mm.

Closest-hit ties at exactly equal computed distance choose the lowest captured input ordinal. That ordinal is not a persistent CAD face identifier: the later consumer must preserve its own triangle-to-appearance mapping. Shared edges and vertices are included; no artificial half-open coverage rule is introduced. Ray origins are not offset automatically. In particular, min=0 allows a hit at the origin; RT2 must explicitly define a scale-aware self-hit policy for shadow rays without erasing thin geometry.

Boxes use closed slab overlap and special-case zero/signed-zero directions. Almost-parallel division may produce infinity, which is clipped against the finite ray interval; the implementation does not multiply zero by an infinite reciprocal. Triangle boxes expand outward by one representable floating-point step, rather than a fixed millimetre tolerance.

Bounded preparation

BvhBuilder takes ownership of a vector of admitted triangles. Input capacity, not just input length, participates in memory admission. It reserves ordinal, flat-node and pending-task buffers before constructing the hierarchy. There is no sorting copy of the scene, recursion, unbounded partition retry or hidden secondary worker. All buffer allocation is fallible.

step(operations, cancel) accepts 1–4096 operations. Each operation initializes one ordinal, scans one primitive's bounds/centroid, partitions one ordinal, or performs a constant-size state/node transition. Work and cancellation are checked before every operation. Source scanning and partitioning are resumable, so a large node does not hide a full-scene operation inside one step.

The split plane is the midpoint of the widest centroid extent, with X/Y/Z tie order. Partitioning is deterministic. An empty partition falls back to the middle of the existing ordinal range. The private task stack is bounded by depth; at the depth cap a leaf retains its remaining range. finish() refuses an incomplete builder; partial acceleration structures are not published.

Defaults allow 100,000 triangles, 128 MiB logical memory, 10 million operations, depth 32 and leaves of eight primitives. Hard admission caps are one million triangles, 512 MiB, one billion operations, depth 48 and leaf target 64. Checked arithmetic rejects overflow before allocations. Maximum node reservation is 2*N-1; empty scenes reserve no nodes. If a platform returns larger Vec capacities, those capacities are checked again before use.

The memory figure includes owned triangle capacity, ordinal/node/task capacities, fixed builder/BVH metadata and one traversal stack. It is a logical buffer bill, not allocator-overhead/RSS measurement and not an acquired host lease. The RT2 image consumer must admit these bytes through the existing host pool together with capture, output, encoding and any other job resources. No such integration is claimed here.

Queries and cancellation

closest_hit and any_hit use a fixed 49-slot traversal stack. They check the existing cancellation token and consume a caller-owned WorkBudget for every node visit and primitive test. One budget can span many rays. Budget exhaustion returns TraceError::WorkLimit; it never returns the best hit found so far as if traversal had completed. Any-hit stops at a real primitive hit. A leaf at the depth cap can be large, but each primitive still has its own work/cancel check.

These are bounded synchronous queries, not an installed cooperative browser renderer. Host scheduling, per-job wall deadlines, late-result identity and publication/cancellation policy remain responsibilities of the existing job system and the RT2 consumer. Default builds do not compile or initialize this module and ordinary modelling/opening/saving routes are unchanged by RT1.

Validation status and next unit

The source includes analytic distance/barycentric/normal tests, tiny/huge and grazing cases, shared-edge ties, slab/parallel cases, BVH-versus-brute-force seeded closest/any-hit comparisons, hostile float admission, deterministic incremental stepping, depth/degenerate termination and work/memory/cancellation checks. These are planned executable checks, not passing results until run.

Required validation before publication: project quality gates, default and feature-enabled render tests/strict Clippy, and feature-enabled wasm checking. The current source-only preparation intentionally does not run Cargo while another owner holds the shared machine's build window.

RT2 is the separate useful image unit: explicitly selected opaque CPU visibility and cast shadows, using the existing camera/scene and host ownership/accounting. That unit needs an original native scene and completed output, cancellation and two-document/late-result checks, unsupported-optics refusal and measured costs. Nothing in this core alone satisfies that visible acceptance milestone.