selune
9e6e0b8df1
* wip(render): reconcile completed material and image pipeline source with 0.20 (#5493) Source-only integration reference for staged review, not a merge-ready aggregate. Donor: 0xlillith/solidcraft@aea20b0115. Upstream:858e5995d6. Retain original CPU/material contracts and explicit GPU donor provenance in docs/render-materials-lab.md (#2067, #2191, #2780, #3306). Preserve released format migrations and current navigation/startup/shell behavior. New saved records use pending descriptors. The physical-card descriptor follows the maintainer's material-engineering-cards naming request, with a legacy-lab format-29 regression. Replace raw new panel hosts with shared containers. Repository checks, complete workspace/all-target Clippy, and the independent physical/resource authoring checks pass for this source. The fresh full local CI invocation has reached test compilation and is not yet complete. Do not transfer donor native output or prior test totals to this integration. Generated review screenshots, video, package ZIP and machine logs remain at the immutable personal evidence pin. Uncommitted geometric displacement is backed up separately, not silently included. No kernel/vendor change, direct main write, release or independent contributor-branch rewrite. Co-authored-by: Christian Svensson <blue@cmd.nu> * test(cli): pin the Compact camera-sample admission diagnostic (#5493) The bounded request still refuses 1024x1024x64 samples before host initialization and writes no output. Update only the stale expected diagnostic to the existing Compact budget wording; production limits and code are unchanged. Exact-tree CLI regression suite: 14 passed, 0 failed. The full repository gate has been invoked separately and is not yet complete. * Normalize UI container violation paths across platforms Report repository-relative paths with forward slashes so diagnostics and the existing nested-package regression assertions agree on Windows and Unix. Keep the container detection rules unchanged. Validation: official ui-containers gate and all seven focused xtask tests passed; rustfmt and diff checks passed. Only xtask/dependencies were compiled; no application build or heavy tests. (cherry picked from commit44b58d8e10) * fix(render): preserve camera contracts and correct acceptance regressions (#5493) Preserve Design view.apply semantics with a separate strict Render camera command. Retain existing translations when English-only aliases collide; add material-axis entries and camera-specific pitch labels. Compare complete validated engineering cards and retain job handles before cancellation. Focused and native acceptance is pinned to treef8a423b21f. Full CI has been invoked separately and is not claimed green. Landing follows the render integration policy in #5493. * fix(render): resolve showcase licence and upstream resource hygiene (#5493) Record SychPL's explicit MIT OR Apache-2.0 grant, retaining source/model bytes and the Ubuntu lettering notice. Remove 80 absent attribution rows, personal fork records, dead delivery attributes and three fork/resource-only workflows. Existing xtask assets now performs bounded offline hash checks and rejects orphan render attribution; no parallel draft CI or package installation. Original authoring reproduction remains explicit. Scoped xtask tests, assets, Clippy, formatting and prepared SELENE validation pass; no application or renderer-wide result is inferred. * fix(render): align saved bounds and progressive sample resolution (#5493) Address review r4364211669/r4364211677/r4364211681/r4364211691/r4364211695. Persisted light/frame domains respect the existing 1e9 document bound; related LED/rectangle/direction cases use the same bound. Workstation primary resolve shares the 4096 admission cap and film counters use checked conversions. Exact candidate: 485 CPU render tests, 21 render document tests and strict scoped Clippy pass, including positive boundary round trips and 2048/4096 end-to-end checkpoints. No released format/migration edits, relaxed test limits or full-stack acceptance claim. * wip(render): isolate optional resources and harden sample handling (#5493) Review work in progress: opt-in encoded render library with reproducible runtime catalog exports; native-only robust dependency through the workspace; checked bloom slices; per-sample point-light diagnostics; independent area-light spatial/film keys. Resource-module binaries in both configurations, generation, Cargo production feature graphs and attribution checks pass. Full engine/render regression and combined acceptance are pending: do not merge this donor as a constituent or treat scoped resource proof as runtime acceptance. * fix(gpu): preserve donor allocations through the scope-safety repair (#5722) Port the native-validated #5723 scope-cleanup correction into the experimental donor, retaining its adaptive, volume, aging, photographic and bloom allocations. Same reverse-drain helper and regression cases; the donor combination still needs its own compile/test gate and is not covered retroactively by render-base results. * claim: #1369 * Reject unknown pending concepts after format folding (#1369) * test(render): close bounded sampling and bloom review regressions (#5493) Validate the optional-resource/lighting/dependency donor at its exact tree. Required Vulkan GPU 127/0/3; CPU renderer 487/0; engine Render 72/0; document render 21/0; lean library 7/0; strict scoped Clippy, assets/layers/lists/containers and lean-engine WASM pass. Preserve original failed controller/typing attempts. This is the draft donor/disposition source, not a replacement for constituent render PRs or final main acceptance. * wip(render): preserve stable aging target validation candidate Exact staged source from prior review work on donor3b892eab5e. This is a recovery/review checkpoint, NOT accepted delivery. An actual command-path regression currently fails because the selected executor refuses ordered surface aging. No assertion, capability or admission limit is weakened. Native/UI/full combination acceptance remains pending. Saved/runtime split adds one pending descriptor and retains original file scope; no main/render branch is changed. * test(render): preserve numeric setup intent at the admitted coordinate bound Follow up jyviko review on #5494 without weakening the corrected saved-coordinate contract. The positive clicked fixture uses 1e9 instead of inadmissible 2e9; explicit out-of-range cases still refuse, and the full saved setup round-trips through JSON and the native container. Exact-source Render workspace 95/0 and strict all-target UI Clippy pass. This does not incorporate the separately failing stable-aging candidate or claim full current-render acceptance. * test(render): use the real GPU executor for saved aging Move successful native cold-reopen Check/Start coverage from the CPU-backed protocol fixture into the production GPU executor tests. Verify capture-index changes preserve the stable target and that enabling aging changes both PNG and raw EXR output. Retain explicit, allocation-free refusal coverage for executors without aging support. Production capabilities and admission checks are unchanged. * fix(render): persist stable identities for targeted aging (#5493) Separate saved RenderBodyTarget identities from captured mesh ordinals. Reject legacy ambiguous targets, resolve Check/Start after visibility changes and preserve native reopening, copies and undo. Unsupported executors still refuse; real AMD Vulkan regression completes saved aging after reordered capture. Source tree6b84c8adpasses document 23, engine Render 75, GPU effects 5 and Render UI 95 with no failures; scoped strict Clippy, WASM and repository gates pass. Fresh CLI/native reopen and clean/aged GPU exports pass with identical physical totals and inspected actual images. Whole current-render integration is separate. * fix(render): reconcile combined CPU/GPU contracts on current upstream Unify captured resources/status and CPU-vs-GPU request schemas after the real two-parent integration; remove obsolete duplicate Vulkan selector and retain combined platform-filter regression. Deduplicate only identical or superseded test definitions, retaining the stronger card metadata and reserved-executor assertions. No assertions, admission limits or feature refusals are weakened. All targets of render dependencies, GPU, engine, UI, CLI and native app pass cargo check with raytrace-cpu and bundled-render-library at treec70d00d1. Native executable tests and full current-source acceptance remain pending. This is a private integration rehearsal for subsequent constituent PRs, not an aggregate official render/main merge. * test(render): retain one complete host lifetime regression set Deduplicate byte-identical DropProbe/task-lifetime tests and retain the adapted environment/texture ownership regressions with every assertion and complete memory estimate. Keep the registered-geometry admission regression once; only struct field order differed. Replace a one-element diagnostic loop with its equivalent block, preserving all wrap/width assertions. Test-only integration repair. Formatting and diff checks pass; refreshed executable validation is required. No production behavior, limits, assertions or ignores changed. * fix(doc): recognize the proven format-29 card descriptor alias Normalize only the historical format-29 physical-material-cards spelling, and only when material-engineering-cards is registered. Admission and migration de-duplication use the same identity. Unknown concepts, wrong versions and incapable readers still refuse before mutation. Six controlled-history Rust regressions and actual CLI migration/no-clobber acceptance pass. No version, released migration or CI changes. Refs #5793, #1369, #5493. * test(render): preserve grounding refusal before explicit instance moves Update the two Render binding fixtures for upstream first-occurrence grounding. Verify grounded movement refuses without changing document/history, then explicitly unground through the public command before the intended move. Retain every target, resource, copy and persistence assertion. Refs #5493. --------- Co-authored-by: Christian Svensson <blue@cmd.nu> Co-authored-by: Victor Santos Oliveira <56417388+Vittuu@users.noreply.github.com> Co-authored-by: cfaulkingham <colin.faulkingham@gmail.com>
SELENE mechanism acceptance
This directory records the source-level acceptance contract for SELENE-showcase.solidcraft. The source is now pinned and its persisted assembly records have been inspected. The checklist binds exact source IDs and parameters; it makes no native runtime claim from that container inspection.
The source lock selects the unchanged file supplied by SychPL, matching the author's public commit byte for byte. SOURCE.md records that evidence. The functional derivative has a separate mechanism contract in MECHANISMS.md and an executable native validator in validate_native.py.
Three evidence levels
Each item in mechanism-acceptance.json separates:
- Documentation evidence: a published project description or author demonstration, linked through the source lock's references.
- Native evidence: exact identities, geometry, parentage, limits and mechanism relationships inspected in the admitted file.
- Runtime evidence: results produced by a recorded SolidCraft revision from explicit inputs and an approved starting pose.
Native evidence is inspected_container_only; source runtime evidence remains not_executed in this checklist. The bindings are tied to source SHA-256 1b0df486f30da157db27a33e0b5ed67f13d527d4dfdc6c334717a1df4e5b8677. Reading the native container confirms records, references and stored values. It does not evaluate geometry, solve a joint, drive a study or certify a derivative.
required_for_native_admission identifies the mechanisms that establish the selected combined showcase. The sampled collision demonstration and flexible-hose visibility treatment are additional review areas. Any differences in the delivered source need explicit explanation; an admission tool cannot infer identity from a count or automatically approve a substitute.
Review areas
| ID | Review area | Native and runtime questions |
|---|---|---|
| MCA-001 | Grounded structure and static modules | Which occurrences anchor the turret, dish support and other fixed modules? Do intended subsystems move without shifting the chassis? |
| MCA-002 | Four split solar actuators | Which bodies belong to each barrel and rod, including their eyes and pins? Do the pieces move together correctly? |
| MCA-003 | Actuator loops and travel stops | Do root pin, stroke slider and wing pin remain connected? Does an infeasible tilt stop with a useful reason? |
| MCA-004 | Mirrored solar tilt | Does the actual link preserve the documented opposing increments, with valid axes, offsets and limits? |
| MCA-005 | Six-wheel link chain | Are all wheels correctly driven through the chain regardless of link serialization order? |
| MCA-006 | Rack-driven helper track | Is the 38 mm coupling correctly bound and explicitly treated as demonstration geometry? |
| MCA-007 | Turret/dish gear | What are the actual driver, follower, sign, ratio and offset of the documented 24:36 pair? |
| MCA-008 | Vial-cap screw | Does the independent cap or helper follow its reported screw motion? What remains necessary for a releasable, sealed vial? |
| MCA-009 | Arm reach and drag | Do reachable and unreachable targets produce bounded, correctly reported poses within limits? |
| MCA-010 | Coordinated tour and traces | Which study keys drive the subsystems? Which traces are analysis geometry, and what defines physical time? |
| MCA-011 | Motion analysis and interference | What was sampled, which pairs were checked, and were results truncated? |
| MCA-012 | Flexible-hose visibility | Which rigid hose approximations or sketches were hidden, and how will their treatment be disclosed? |
The detailed checks cite the mechanism reference, the author's combined showcase, motion export, and motion analysis.
Source bindings and deliberate derivative changes
The unchanged source contains 47 occurrences, 49 joints, nine links and one SELENE tour study. Structure occurrence 1930 is grounded. Rigid joints 30..47 attach 18 modules to it; the joint graph reaches every source occurrence except the independent rock sample 3458. The four actuator loops use joint triples 18/19/20, 21/22/23, 24/25/26 and 27/28/29. These are persisted source facts, not evaluated degrees of freedom or a solver result.
The original helper track has a 38 mm rack radius; the functional derivative specifies 40 mm to match the modeled wheel radius. The source's 7 → 16 link couples sensor and dish azimuth at -24/36; the derivative deliberately gives those pointing systems independent controls. The source cap keeps its 1.5 mm lead and 0–6 mm axial travel. Source facts remain in the checklist so that an intentional change is visible rather than silently relabeled as the original design.
The source tour has 120 steps and nine keyed joint coordinates. Its three rigid hydraulic-hose sweeps and six associated sketches are hidden. Hiding them avoids presenting a fixed sweep as a deforming hose; flexible routing remains separate work.
Numeric planning checks
The four analytic_candidate records are original calculations from published values. They can be recomputed without a model. Passing them says nothing about the contents of a candidate native file.
Native lengths use millimeters and native angles use radians. The documented joint and study commands accept degrees or explicit angle expressions. A tool must convert once at the boundary; it must not pass a radian-valued native angle to a degree-valued command unchanged.
Actuator length and stop
The public mechanism reference supplies rounded port-side coordinates. For a planar planning example, use the common actuator X coordinate as zero:
- Hinge:
H = (0, -140, 158) mm. - Root pin:
R = (0, -91, 134) mm. - Wing pin at zero angle:
T0 = (0, -180.41, 169.71) mm. - Wing rotation: positive about X.
The candidate relation is:
T(theta) = H + Rx(theta) * (T0 - H)
L(theta) = norm(T(theta) - R)
stroke(theta) = L(theta) - L(0)
These inputs give a zero-angle length of 96.277475 mm and a stroke of -2.865953 mm at 0.3490658504 rad (20 degrees). The first positive angle reaching -6 mm stroke is approximately 0.5625425647 rad (32.231315 degrees).
The reference reports approximately -2.87 mm at 20 degrees and a stop near 32.23 degrees. The small rounding difference is expected from its published coordinate precision. These rounded points are not exact native geometry and do not define a native replay tolerance.
The source bindings now record the full-precision pin positions. They give a 20-degree stroke expectation of -2.8662098186467375 mm, used by the functional validator. Verify closure over the path, not just at the final pose. An endpoint that happens to close can hide an impossible intermediate motion.
Rack-and-pinion displacement
For the author's reported 38 mm pitch radius, the displacement magnitude is:
abs(delta_x_mm) = 38 * abs(delta_theta_rad)
One full turn gives 238.761042 mm. The direction and initial offset depend on the source's joint axes and coupling. The moving regolith track is a prescribed demonstration helper; this relation does not establish wheel traction, contact forces, slip or lunar-ground dynamics.
Gear-pair magnitude
Under the candidate interpretation that the 24 side drives the 36 side:
abs(delta_follower_rad) = (24 / 36) * abs(delta_driver_rad)
A driver increment of 1.5707963268 rad gives a follower magnitude of 1.0471975512 rad. Source inspection confirms turret azimuth drives dish azimuth with ratio -2/3 and zero offset. This historic analytic example does not apply to the independent pointing controls of the functional derivative.
Vial-cap screw
Interpreting the documented 1.5 mm screw as 1.5 mm axial lead per revolution gives:
abs(delta_axial_mm) = 1.5 * abs(delta_angle_rad) / (2*pi)
A full turn yields 1.5 mm axial travel. Source joint 49 is cylindrical about +Z, with a screw link from angular coordinate 0 to axial coordinate 1 and travel limits of 0–6 mm. This is a kinematic screw relation; it does not prove thread contact, closure sealing or capture retention.
Runtime evidence to record
Each executed acceptance case should retain the native-file SHA-256, SolidCraft code revision, exact command inputs, initial pose, selected joint IDs and axes, effective link values, solver tolerances, resolved poses and any stop or collision reports. The functional validator writes actual MCP request/response JSONL, hashes its inputs before and after, resets primary drivers before each case, and records numeric comparisons without saving its in-memory test poses to the master.
A published numerical residual is evidence of that demonstration only. The author's reported arm residual is not a guaranteed precision threshold for arbitrary poses. Select a useful tolerance for the actual model and solver, and report it with the result.
The cited inverse-kinematics work does not check contact sets during joint.reach; contact review is a separate operation. Likewise, a sampled interference run can miss motion between samples. Record spacing, work limits and any truncation; use stronger checking when the task requires continuous clearance.
The reported 121 exported tour frames are export metadata. They do not establish the native study's exact key count, duration or physically feasible actuator speeds. A time mapping must be explicit before deriving velocities or accelerations.
Limits of this acceptance
These checks establish reviewed kinematic structure and behavior. They do not establish mass properties, actuator torque, controller bandwidth, thermal limits, regolith forces, cable deformation or a feasible lunar sample throw and catch.
A vial cap that unscrews is useful source evidence. A future sample-transfer scene still needs a reviewed independent vial body, contents and closure boundaries, grasp/release rules, collision proxies, physical properties and capture behavior. No flight or collection mechanism is inferred from the demonstration.
Retain the source's provenance and record deliberate changes as new derivatives. A new source digest invalidates bindings and motion evidence; rendering quality settings cannot repair or silently retime those changes.
Prepared inspection and future dynamics inputs
preflight-commands.json is a read-only five-command inventory to run on the actual opened design. It does not create, drive or alter a joint. Save its output under ignored target/, with the source digest and executor revision.
sample-sequence.json specifies eleven future dynamics states from approach and collection through closure, release, flight, capture and storage, including a failed-catch branch. It reuses the existing kinematic authoring foundation and adds the contact, mass/inertia, actuation and event evidence needed for a physically validated animation. It is not an executable motion.study or an approved bake.