* wip(render): reconcile completed material and image pipeline source with 0.20 (#5493) Source-only integration reference for staged review, not a merge-ready aggregate. Donor: 0xlillith/solidcraft@aea20b0115. Upstream:858e5995d6. Retain original CPU/material contracts and explicit GPU donor provenance in docs/render-materials-lab.md (#2067, #2191, #2780, #3306). Preserve released format migrations and current navigation/startup/shell behavior. New saved records use pending descriptors. The physical-card descriptor follows the maintainer's material-engineering-cards naming request, with a legacy-lab format-29 regression. Replace raw new panel hosts with shared containers. Repository checks, complete workspace/all-target Clippy, and the independent physical/resource authoring checks pass for this source. The fresh full local CI invocation has reached test compilation and is not yet complete. Do not transfer donor native output or prior test totals to this integration. Generated review screenshots, video, package ZIP and machine logs remain at the immutable personal evidence pin. Uncommitted geometric displacement is backed up separately, not silently included. No kernel/vendor change, direct main write, release or independent contributor-branch rewrite. Co-authored-by: Christian Svensson <blue@cmd.nu> * test(cli): pin the Compact camera-sample admission diagnostic (#5493) The bounded request still refuses 1024x1024x64 samples before host initialization and writes no output. Update only the stale expected diagnostic to the existing Compact budget wording; production limits and code are unchanged. Exact-tree CLI regression suite: 14 passed, 0 failed. The full repository gate has been invoked separately and is not yet complete. * Normalize UI container violation paths across platforms Report repository-relative paths with forward slashes so diagnostics and the existing nested-package regression assertions agree on Windows and Unix. Keep the container detection rules unchanged. Validation: official ui-containers gate and all seven focused xtask tests passed; rustfmt and diff checks passed. Only xtask/dependencies were compiled; no application build or heavy tests. (cherry picked from commit44b58d8e10) * fix(render): preserve camera contracts and correct acceptance regressions (#5493) Preserve Design view.apply semantics with a separate strict Render camera command. Retain existing translations when English-only aliases collide; add material-axis entries and camera-specific pitch labels. Compare complete validated engineering cards and retain job handles before cancellation. Focused and native acceptance is pinned to treef8a423b21f. Full CI has been invoked separately and is not claimed green. Landing follows the render integration policy in #5493. * fix(render): resolve showcase licence and upstream resource hygiene (#5493) Record SychPL's explicit MIT OR Apache-2.0 grant, retaining source/model bytes and the Ubuntu lettering notice. Remove 80 absent attribution rows, personal fork records, dead delivery attributes and three fork/resource-only workflows. Existing xtask assets now performs bounded offline hash checks and rejects orphan render attribution; no parallel draft CI or package installation. Original authoring reproduction remains explicit. Scoped xtask tests, assets, Clippy, formatting and prepared SELENE validation pass; no application or renderer-wide result is inferred. * fix(render): align saved bounds and progressive sample resolution (#5493) Address review r4364211669/r4364211677/r4364211681/r4364211691/r4364211695. Persisted light/frame domains respect the existing 1e9 document bound; related LED/rectangle/direction cases use the same bound. Workstation primary resolve shares the 4096 admission cap and film counters use checked conversions. Exact candidate: 485 CPU render tests, 21 render document tests and strict scoped Clippy pass, including positive boundary round trips and 2048/4096 end-to-end checkpoints. No released format/migration edits, relaxed test limits or full-stack acceptance claim. * wip(render): isolate optional resources and harden sample handling (#5493) Review work in progress: opt-in encoded render library with reproducible runtime catalog exports; native-only robust dependency through the workspace; checked bloom slices; per-sample point-light diagnostics; independent area-light spatial/film keys. Resource-module binaries in both configurations, generation, Cargo production feature graphs and attribution checks pass. Full engine/render regression and combined acceptance are pending: do not merge this donor as a constituent or treat scoped resource proof as runtime acceptance. * fix(gpu): preserve donor allocations through the scope-safety repair (#5722) Port the native-validated #5723 scope-cleanup correction into the experimental donor, retaining its adaptive, volume, aging, photographic and bloom allocations. Same reverse-drain helper and regression cases; the donor combination still needs its own compile/test gate and is not covered retroactively by render-base results. * claim: #1369 * Reject unknown pending concepts after format folding (#1369) * test(render): close bounded sampling and bloom review regressions (#5493) Validate the optional-resource/lighting/dependency donor at its exact tree. Required Vulkan GPU 127/0/3; CPU renderer 487/0; engine Render 72/0; document render 21/0; lean library 7/0; strict scoped Clippy, assets/layers/lists/containers and lean-engine WASM pass. Preserve original failed controller/typing attempts. This is the draft donor/disposition source, not a replacement for constituent render PRs or final main acceptance. * wip(render): preserve stable aging target validation candidate Exact staged source from prior review work on donor3b892eab5e. This is a recovery/review checkpoint, NOT accepted delivery. An actual command-path regression currently fails because the selected executor refuses ordered surface aging. No assertion, capability or admission limit is weakened. Native/UI/full combination acceptance remains pending. Saved/runtime split adds one pending descriptor and retains original file scope; no main/render branch is changed. * test(render): preserve numeric setup intent at the admitted coordinate bound Follow up jyviko review on #5494 without weakening the corrected saved-coordinate contract. The positive clicked fixture uses 1e9 instead of inadmissible 2e9; explicit out-of-range cases still refuse, and the full saved setup round-trips through JSON and the native container. Exact-source Render workspace 95/0 and strict all-target UI Clippy pass. This does not incorporate the separately failing stable-aging candidate or claim full current-render acceptance. * test(render): use the real GPU executor for saved aging Move successful native cold-reopen Check/Start coverage from the CPU-backed protocol fixture into the production GPU executor tests. Verify capture-index changes preserve the stable target and that enabling aging changes both PNG and raw EXR output. Retain explicit, allocation-free refusal coverage for executors without aging support. Production capabilities and admission checks are unchanged. * fix(render): persist stable identities for targeted aging (#5493) Separate saved RenderBodyTarget identities from captured mesh ordinals. Reject legacy ambiguous targets, resolve Check/Start after visibility changes and preserve native reopening, copies and undo. Unsupported executors still refuse; real AMD Vulkan regression completes saved aging after reordered capture. Source tree6b84c8adpasses document 23, engine Render 75, GPU effects 5 and Render UI 95 with no failures; scoped strict Clippy, WASM and repository gates pass. Fresh CLI/native reopen and clean/aged GPU exports pass with identical physical totals and inspected actual images. Whole current-render integration is separate. * fix(render): reconcile combined CPU/GPU contracts on current upstream Unify captured resources/status and CPU-vs-GPU request schemas after the real two-parent integration; remove obsolete duplicate Vulkan selector and retain combined platform-filter regression. Deduplicate only identical or superseded test definitions, retaining the stronger card metadata and reserved-executor assertions. No assertions, admission limits or feature refusals are weakened. All targets of render dependencies, GPU, engine, UI, CLI and native app pass cargo check with raytrace-cpu and bundled-render-library at treec70d00d1. Native executable tests and full current-source acceptance remain pending. This is a private integration rehearsal for subsequent constituent PRs, not an aggregate official render/main merge. * test(render): retain one complete host lifetime regression set Deduplicate byte-identical DropProbe/task-lifetime tests and retain the adapted environment/texture ownership regressions with every assertion and complete memory estimate. Keep the registered-geometry admission regression once; only struct field order differed. Replace a one-element diagnostic loop with its equivalent block, preserving all wrap/width assertions. Test-only integration repair. Formatting and diff checks pass; refreshed executable validation is required. No production behavior, limits, assertions or ignores changed. * fix(doc): recognize the proven format-29 card descriptor alias Normalize only the historical format-29 physical-material-cards spelling, and only when material-engineering-cards is registered. Admission and migration de-duplication use the same identity. Unknown concepts, wrong versions and incapable readers still refuse before mutation. Six controlled-history Rust regressions and actual CLI migration/no-clobber acceptance pass. No version, released migration or CI changes. Refs #5793, #1369, #5493. * test(render): preserve grounding refusal before explicit instance moves Update the two Render binding fixtures for upstream first-occurrence grounding. Verify grounded movement refuses without changing document/history, then explicitly unground through the public command before the intended move. Retain every target, resource, copy and persistence assertion. Refs #5493. --------- Co-authored-by: Christian Svensson <blue@cmd.nu> Co-authored-by: Victor Santos Oliveira <56417388+Vittuu@users.noreply.github.com> Co-authored-by: cfaulkingham <colin.faulkingham@gmail.com>
6.3 KiB
Native resource admission and continuous validation
This gate connects the authored resource checks to the real public Rust APIs
in solidcraft-render. It is a development conformance tool, not a new application
importer, persistent texture format, renderer feature or GUI control. The fixed
resource branch remains isolated from the renderer implementation checkpoint.
One command
From the repository root, use Python 3.11+ in an isolated development environment:
python -m pip install -r assets/render/starter/tools/requirements.txt
python -B assets/render/starter/tools/check_all.py
The command checks the original catalog, prepared SELENE contracts, resource
manifests, original Python regression tests and exact material/HDR reproduction.
It then runs repository formatting, attribution and icon checks, all-target
Clippy for solidcraft-render, its library tests, the new native checker tests
and full native resource admission. --locked preserves the Rust dependency
resolution. No Rust dependency, application command or saved design is changed.
The runner writes uniquely named logs and a machine-readable report.json under
target/render-starter-checks/. It fingerprints its source inputs before and after
checking: a concurrent change invalidates the result instead of producing mixed
revision evidence. Native success additionally requires the complete expected
receipt inventory, correct source/decoded digest syntax and explicit non-runtime
status. A failed stage stops the gate and retains its diagnostic output.
--authoring-only explicitly omits the native/repository stages and records that
limited scope; it is never reported as a native pass. --independent-decode
additionally requires an installed FFmpeg executable and fails rather than
silently skipping a missing decoder. Neither option installs application features.
The separate Render resource gate GitHub workflow runs on relevant pull
requests, including drafts, using Ubuntu 24.04 and Windows Server 2025. It keeps
receipts/logs as workflow artifacts, not tracked assets. This targeted gate does
not replace complete cargo xtask ci or integrated application acceptance.
What the native checker exercises
The executable is an example target, outside the compiled application library:
cargo test --locked --profile ci -p solidcraft-render --example validate_starter
cargo run --locked --profile ci -p solidcraft-render --example validate_starter
Its standard output is JSON evidence; progress and failures go to standard error. It accepts no user paths and reads only the known repository-relative collection. These checks cover the fixed starter v1 inventory; changes to that inventory need an explicit update and review rather than an automatic acceptance-hash refresh.
| Resource | Native checks |
|---|---|
| 192 eight-bit maps | Exact encoded SHA-256/size, full TextureSource decode and equality with the authoring tool's decoded-pixel digest |
| 192 normalized inputs | NormalizationSource with an explicit source-sRGB declaration, independent transfer/data expectations for every channel, no unexpected clipping or orientation operation |
| 1,920 mip levels including base levels | TextureView and MipChain, ten levels per map, final 1x1 mean conservation and periodic bilinear/trilinear sampling |
| 48 height sources | Full native grayscale-16 PNG decode, little-endian sample digest and range, plus deliberate refusal by the strict eight-bit input route; no invented height role |
| 24 HDR probes | HdrSource and the cooperative HdrDecodeTask, bounded completion, full float pixel digest, primaries/exposure/correction, radiance range, spherical mean and six directional cosine integrals |
| Cancellation and hostile inputs | Source reuse after texture cancellation, consumed HDR task after cancellation, no partial mip chain, altered hashes, bounded reads, ambiguous paths, duplicate known fields and unsupported map roles |
The native HDR directional checks use pixel-center directions and exact cell
solid angles. They compare against the authored receipts with their documented
rounded precision, not an arbitrary visual similarity threshold. The uniform
comparison field must remain exactly unit radiance. The black-vacuum field has
energy owner none and must remain exactly zero: an environment-source fallback
must not accidentally add light.
Coordinate and interpretation boundaries
The authoring normal convention is OpenGL +Y, with authored V pointing up.
The existing native sampler addresses image rows with V pointing down. The
checker maps (u, v) to (u, 1-v) once, preserves the green normal component,
and renormalizes a filtered tangent-space normal. A directional synthetic fixture
checks both halves of this mapping. This is not an object tangent-frame binding:
face/definition coordinates, handedness on mirrored instances, UV ownership and
mapping onto actual CAD surfaces still require renderer acceptance.
Base color is linearized exactly once; roughness, metallic and normal channels remain linear data. The 1x1 mean check uses normalized values, not gamma-encoded averages. Generic mip filtering does not establish normal-variance compensation, anisotropic texture filtering, BRDF energy accuracy or CPU/GPU parity.
Scope and remaining work
No source texture, HDR probe, recipe or generator receipt is rewritten. Files are admitted one at a time with a 16 MiB encoded limit and fixed v1 dimensions; existing native APIs retain their own allocation/work limits. These are bounded input checks, not a whole-process RSS ceiling or a general-purpose sandbox. Run from a trusted checkout; do not race filesystem mutations against the checker.
Source metadata is checked only as needed for native conformance; the original Python validators remain mandatory for the full authoring schema and provenance. Reports identify bytes and operations, not publisher authenticity or material measurement. The light-rig generator/calibration remains covered by the Python suite; no native rig installation or measured LED output is inferred.
Remaining integration work includes persistent body/face resource ownership,
texture/height adapters, native save/reopen, actual CPU/GPU reference scenes,
capability-aware library UI, blocked LED/aperture calibration and reviewed SELENE
source admission. Every native report retains runtime_ready: false.