selune
9e6e0b8df1
* wip(render): reconcile completed material and image pipeline source with 0.20 (#5493) Source-only integration reference for staged review, not a merge-ready aggregate. Donor: 0xlillith/solidcraft@aea20b0115. Upstream:858e5995d6. Retain original CPU/material contracts and explicit GPU donor provenance in docs/render-materials-lab.md (#2067, #2191, #2780, #3306). Preserve released format migrations and current navigation/startup/shell behavior. New saved records use pending descriptors. The physical-card descriptor follows the maintainer's material-engineering-cards naming request, with a legacy-lab format-29 regression. Replace raw new panel hosts with shared containers. Repository checks, complete workspace/all-target Clippy, and the independent physical/resource authoring checks pass for this source. The fresh full local CI invocation has reached test compilation and is not yet complete. Do not transfer donor native output or prior test totals to this integration. Generated review screenshots, video, package ZIP and machine logs remain at the immutable personal evidence pin. Uncommitted geometric displacement is backed up separately, not silently included. No kernel/vendor change, direct main write, release or independent contributor-branch rewrite. Co-authored-by: Christian Svensson <blue@cmd.nu> * test(cli): pin the Compact camera-sample admission diagnostic (#5493) The bounded request still refuses 1024x1024x64 samples before host initialization and writes no output. Update only the stale expected diagnostic to the existing Compact budget wording; production limits and code are unchanged. Exact-tree CLI regression suite: 14 passed, 0 failed. The full repository gate has been invoked separately and is not yet complete. * Normalize UI container violation paths across platforms Report repository-relative paths with forward slashes so diagnostics and the existing nested-package regression assertions agree on Windows and Unix. Keep the container detection rules unchanged. Validation: official ui-containers gate and all seven focused xtask tests passed; rustfmt and diff checks passed. Only xtask/dependencies were compiled; no application build or heavy tests. (cherry picked from commit44b58d8e10) * fix(render): preserve camera contracts and correct acceptance regressions (#5493) Preserve Design view.apply semantics with a separate strict Render camera command. Retain existing translations when English-only aliases collide; add material-axis entries and camera-specific pitch labels. Compare complete validated engineering cards and retain job handles before cancellation. Focused and native acceptance is pinned to treef8a423b21f. Full CI has been invoked separately and is not claimed green. Landing follows the render integration policy in #5493. * fix(render): resolve showcase licence and upstream resource hygiene (#5493) Record SychPL's explicit MIT OR Apache-2.0 grant, retaining source/model bytes and the Ubuntu lettering notice. Remove 80 absent attribution rows, personal fork records, dead delivery attributes and three fork/resource-only workflows. Existing xtask assets now performs bounded offline hash checks and rejects orphan render attribution; no parallel draft CI or package installation. Original authoring reproduction remains explicit. Scoped xtask tests, assets, Clippy, formatting and prepared SELENE validation pass; no application or renderer-wide result is inferred. * fix(render): align saved bounds and progressive sample resolution (#5493) Address review r4364211669/r4364211677/r4364211681/r4364211691/r4364211695. Persisted light/frame domains respect the existing 1e9 document bound; related LED/rectangle/direction cases use the same bound. Workstation primary resolve shares the 4096 admission cap and film counters use checked conversions. Exact candidate: 485 CPU render tests, 21 render document tests and strict scoped Clippy pass, including positive boundary round trips and 2048/4096 end-to-end checkpoints. No released format/migration edits, relaxed test limits or full-stack acceptance claim. * wip(render): isolate optional resources and harden sample handling (#5493) Review work in progress: opt-in encoded render library with reproducible runtime catalog exports; native-only robust dependency through the workspace; checked bloom slices; per-sample point-light diagnostics; independent area-light spatial/film keys. Resource-module binaries in both configurations, generation, Cargo production feature graphs and attribution checks pass. Full engine/render regression and combined acceptance are pending: do not merge this donor as a constituent or treat scoped resource proof as runtime acceptance. * fix(gpu): preserve donor allocations through the scope-safety repair (#5722) Port the native-validated #5723 scope-cleanup correction into the experimental donor, retaining its adaptive, volume, aging, photographic and bloom allocations. Same reverse-drain helper and regression cases; the donor combination still needs its own compile/test gate and is not covered retroactively by render-base results. * claim: #1369 * Reject unknown pending concepts after format folding (#1369) * test(render): close bounded sampling and bloom review regressions (#5493) Validate the optional-resource/lighting/dependency donor at its exact tree. Required Vulkan GPU 127/0/3; CPU renderer 487/0; engine Render 72/0; document render 21/0; lean library 7/0; strict scoped Clippy, assets/layers/lists/containers and lean-engine WASM pass. Preserve original failed controller/typing attempts. This is the draft donor/disposition source, not a replacement for constituent render PRs or final main acceptance. * wip(render): preserve stable aging target validation candidate Exact staged source from prior review work on donor3b892eab5e. This is a recovery/review checkpoint, NOT accepted delivery. An actual command-path regression currently fails because the selected executor refuses ordered surface aging. No assertion, capability or admission limit is weakened. Native/UI/full combination acceptance remains pending. Saved/runtime split adds one pending descriptor and retains original file scope; no main/render branch is changed. * test(render): preserve numeric setup intent at the admitted coordinate bound Follow up jyviko review on #5494 without weakening the corrected saved-coordinate contract. The positive clicked fixture uses 1e9 instead of inadmissible 2e9; explicit out-of-range cases still refuse, and the full saved setup round-trips through JSON and the native container. Exact-source Render workspace 95/0 and strict all-target UI Clippy pass. This does not incorporate the separately failing stable-aging candidate or claim full current-render acceptance. * test(render): use the real GPU executor for saved aging Move successful native cold-reopen Check/Start coverage from the CPU-backed protocol fixture into the production GPU executor tests. Verify capture-index changes preserve the stable target and that enabling aging changes both PNG and raw EXR output. Retain explicit, allocation-free refusal coverage for executors without aging support. Production capabilities and admission checks are unchanged. * fix(render): persist stable identities for targeted aging (#5493) Separate saved RenderBodyTarget identities from captured mesh ordinals. Reject legacy ambiguous targets, resolve Check/Start after visibility changes and preserve native reopening, copies and undo. Unsupported executors still refuse; real AMD Vulkan regression completes saved aging after reordered capture. Source tree6b84c8adpasses document 23, engine Render 75, GPU effects 5 and Render UI 95 with no failures; scoped strict Clippy, WASM and repository gates pass. Fresh CLI/native reopen and clean/aged GPU exports pass with identical physical totals and inspected actual images. Whole current-render integration is separate. * fix(render): reconcile combined CPU/GPU contracts on current upstream Unify captured resources/status and CPU-vs-GPU request schemas after the real two-parent integration; remove obsolete duplicate Vulkan selector and retain combined platform-filter regression. Deduplicate only identical or superseded test definitions, retaining the stronger card metadata and reserved-executor assertions. No assertions, admission limits or feature refusals are weakened. All targets of render dependencies, GPU, engine, UI, CLI and native app pass cargo check with raytrace-cpu and bundled-render-library at treec70d00d1. Native executable tests and full current-source acceptance remain pending. This is a private integration rehearsal for subsequent constituent PRs, not an aggregate official render/main merge. * test(render): retain one complete host lifetime regression set Deduplicate byte-identical DropProbe/task-lifetime tests and retain the adapted environment/texture ownership regressions with every assertion and complete memory estimate. Keep the registered-geometry admission regression once; only struct field order differed. Replace a one-element diagnostic loop with its equivalent block, preserving all wrap/width assertions. Test-only integration repair. Formatting and diff checks pass; refreshed executable validation is required. No production behavior, limits, assertions or ignores changed. * fix(doc): recognize the proven format-29 card descriptor alias Normalize only the historical format-29 physical-material-cards spelling, and only when material-engineering-cards is registered. Admission and migration de-duplication use the same identity. Unknown concepts, wrong versions and incapable readers still refuse before mutation. Six controlled-history Rust regressions and actual CLI migration/no-clobber acceptance pass. No version, released migration or CI changes. Refs #5793, #1369, #5493. * test(render): preserve grounding refusal before explicit instance moves Update the two Render binding fixtures for upstream first-occurrence grounding. Verify grounded movement refuses without changing document/history, then explicitly unground through the public command before the intended move. Retain every target, resource, copy and persistence assertion. Refs #5493. --------- Co-authored-by: Christian Svensson <blue@cmd.nu> Co-authored-by: Victor Santos Oliveira <56417388+Vittuu@users.noreply.github.com> Co-authored-by: cfaulkingham <colin.faulkingham@gmail.com>
8.9 KiB
Authored lighting resources
This slice resolves the original 24 studio recipes into numerical authoring resources. It includes 38 calibrated finite area sources, one authored finite-angular solar source, eight passive cards, and explicit blocked or external-source states. It does not add an application command or install a rig.
The existing studio preset file remains the editable authority for names, geometry, intent, requirements and source relationships. recipe.json pins that file by SHA-256 and defines the numerical calibration settings. Edit those authorities and rebuild; do not edit exports/rigs.json by hand. The export records SHA-256 fingerprints for the recipe, upstream source and generator, so authoring-code changes require a regenerated provenance record.
All authored content and tools are original project work under MIT OR Apache-2.0.
No external light probe, IES profile, commercial template or rendering
implementation is bundled. References in the recipe identify public radiometric
definitions and equations only. These sources are relative RGB references, not
measured luminaires, spectral distributions or engineering photometry.
What is available
| Original preset | Numeric resource state |
|---|---|
| STU-001–017 | Complete finite-area source gains and passive-card transforms; runtime and subject geometry unbound |
| STU-018 | Inspection area calibrated; internal LED source blocked by incompatible calibration fixture |
| STU-019 | Entrance source blocked by incompatible calibration fixture |
| STU-020 | Uniform distant solar disk with explicit relative normal irradiance and angular radiance |
| STU-021 | Adds no light; requires one resolved existing environment sun |
| STU-022 | Adds no light; requires verification that the whole scene has zero emitted energy |
| STU-023 | Adds no light; requires one resolved environment sun for the externally supplied SELENE poses |
| STU-024 | Fill gain blocked until the existing environment sun's reference signal is measured |
There are 19 authored_numeric_unbound records, three blocked_calibration
records and two requires_existing_environment_sun records. Every record has
runtime_ready: false. The 19 numeric records include the zero-source diagnostic;
they are not 19 independently rendered or installed application presets.
The LED strip and light-guide source lie inside or intersect the prescribed
reference sphere. A closed opaque reference sphere cannot serve as their exterior
calibration receiver. The tool rejects those gains instead of moving the source,
shrinking the sphere, applying a point approximation or inventing optical output.
A separate aperture or diffuser fixture needs an explicit reviewed definition.
The editorial lunar fill likewise retains emission: null until its actual
environment-sun response is available.
Rebuild and validate
From the repository root, with Python 3.11+ and NumPy installed:
python3 -B assets/render/starter/tools/lighting.py build
python3 -B assets/render/starter/tools/lighting.py validate
python3 -B assets/render/starter/tools/test_lighting.py
With Pillow installed, python3 -B assets/render/starter/tools/lighting.py review
writes target/render-starter-review/lighting-reference.png. This ignored sheet
shows the numerical Lambertian fixture at one fixed view, with source radiance
only and a declared Reinhard-to-sRGB display transform. It deliberately excludes
passive cards and actual CAD geometry. It is not a SolidCraft screenshot, final
rig render, material preview or photometric measurement.
build writes only the known lighting export. validate recomputes the export
and compares its bytes; it does not update files or change a source pin. Inputs
reject duplicate keys, non-finite or Boolean numeric fields, oversized arrays,
degenerate frames, unsupported source types, active reflectors and hidden physical
lunar fill. The committed source pin makes a changed upstream recipe an explicit
review event. The integration and memory bounds are enforced before allocation.
Generation is deterministic in the documented Python/NumPy environment. The
export rounds numbers to 12 significant digits. The convergence diagnostic
higher_order_relative_difference first uses 12 decimal places, a reporting
resolution of 1e-12, to suppress insignificant NumPy/libm differences observed
between Linux and Windows. Convergence acceptance still compares the unrounded
full-precision result with the configured threshold; reporting precision never
relaxes that gate. Source gains, transforms and other substantive numbers retain
their existing precision. Cross-platform bit identity is not promised for every
mathematical-library version; a remaining difference must be reviewed, not
approved by replacing a stored source hash automatically.
Calibration and quantities
The numerical fixture preserves CAL-LIGHT-001: a centered Lambertian sphere
with radius 0.25B, diffuse reflectance 0.18 and B = 1000 mm, no other source,
no floor, no environment and no passive cards. Its response is the equally
weighted average of the masked disk mean in six orthographic views along the
positive and negative Cartesian axes. Values are scene-referred and linear;
no display transform, clipping, automatic exposure or camera change is applied.
For each area source, the tool integrates incident radiance over the finite
rectangle using both source and receiver cosines and squared distance. The
Lambertian outgoing radiance is reflectance times irradiance divided by pi.
The sum of the six projected view weights at a sphere normal is
(|nx| + |ny| + |nz|) / (6*pi). Surface integration of this weight reproduces
the specified six-view measurement without raster-mask aliasing.
The primary integration uses 48 Gauss-Legendre latitude nodes, 96 azimuth samples and a 12-by-12 rectangle quadrature. Every calibrated source is also evaluated with 72 latitude nodes, 144 azimuth samples and a 20-by-20 rectangle quadrature. The relative difference must be below 0.0015. The initial export's largest observed difference is approximately 0.00017489 (0.01749%). This is a convergence observation, not a rigorous error bound or runtime renderer result.
Zero reference EV targets one arbitrary response unit. The per-source radiance
gain is 2**EV / unit_radiance_response; a change of one EV doubles its reference
signal. Sources retain their distinct areas, orientations and distances. The
numbers are relative radiance, not point radiant intensity, lumens, candela,
watts or lux. Passive-card interreflection is deliberately outside per-source
calibration and must be evaluated in the completed scene.
The solar recipe has one owned uniform disk. Its authored normal irradiance
E and angular radius a give radiance E / (pi*sin(a)**2). The export records
both quantities distinctly. The neutral RGB and approximate disk size are
authoring inputs, not a measured solar spectrum or site ephemeris. The runtime
adapter must provide finite-angular sampling and visibility and must not add a
second environmental solar contribution.
The mathematical tests check an independently derived closed-form directional sphere response, six separately integrated projected disks, finite-area far-field inverse-square behavior, zero back emission, solar-disk integration, EV ratios, uniform-scale behavior, valid source frames and the source-admission failures. They are numeric authoring checks; they do not exercise SolidCraft's CPU/GPU backends or imply measured optical accuracy.
Integration requirements
Positions and sizes in the export are resolved in millimeters once for the
reference B = 1000 mm; width, height and emitting-normal axes are explicit and
orthonormal. The subject frame remains +Z up, -Y front and +X right. Each
record preserves the source's original origin, aperture, region and fit policy.
Do not apply the reference transforms directly to an unrelated subject without
resolving that policy and checking geometry clearance.
For similarly scaled finite-area sources and sphere fixtures, both source area and squared distance scale together, so the reference radiance gain is unchanged; the source's total emitted power changes with area. This does not apply to point intensity. After the explicit fit, freeze the result: camera moves and robot poses must not refit lights or alter normalization.
A future adapter must check all capability and scene preconditions, preserve undo, retain the existing camera/exposure and material state, resolve actual subject geometry, implement passive-card transport, and keep one energy owner per physical emitter. Source meshes may make an analytic source visible but must not emit a duplicate contribution. The rig is a single transaction; do not apply the calibrated subset of a blocked rig silently.
No CAD source model, articulated SELENE state, optical-guide solution, full-scene lighting render, photometric compliance or runtime installation was verified by this authoring slice.