* wip(render): reconcile completed material and image pipeline source with 0.20 (#5493) Source-only integration reference for staged review, not a merge-ready aggregate. Donor: 0xlillith/solidcraft@aea20b0115. Upstream:858e5995d6. Retain original CPU/material contracts and explicit GPU donor provenance in docs/render-materials-lab.md (#2067, #2191, #2780, #3306). Preserve released format migrations and current navigation/startup/shell behavior. New saved records use pending descriptors. The physical-card descriptor follows the maintainer's material-engineering-cards naming request, with a legacy-lab format-29 regression. Replace raw new panel hosts with shared containers. Repository checks, complete workspace/all-target Clippy, and the independent physical/resource authoring checks pass for this source. The fresh full local CI invocation has reached test compilation and is not yet complete. Do not transfer donor native output or prior test totals to this integration. Generated review screenshots, video, package ZIP and machine logs remain at the immutable personal evidence pin. Uncommitted geometric displacement is backed up separately, not silently included. No kernel/vendor change, direct main write, release or independent contributor-branch rewrite. Co-authored-by: Christian Svensson <blue@cmd.nu> * test(cli): pin the Compact camera-sample admission diagnostic (#5493) The bounded request still refuses 1024x1024x64 samples before host initialization and writes no output. Update only the stale expected diagnostic to the existing Compact budget wording; production limits and code are unchanged. Exact-tree CLI regression suite: 14 passed, 0 failed. The full repository gate has been invoked separately and is not yet complete. * Normalize UI container violation paths across platforms Report repository-relative paths with forward slashes so diagnostics and the existing nested-package regression assertions agree on Windows and Unix. Keep the container detection rules unchanged. Validation: official ui-containers gate and all seven focused xtask tests passed; rustfmt and diff checks passed. Only xtask/dependencies were compiled; no application build or heavy tests. (cherry picked from commit44b58d8e10) * fix(render): preserve camera contracts and correct acceptance regressions (#5493) Preserve Design view.apply semantics with a separate strict Render camera command. Retain existing translations when English-only aliases collide; add material-axis entries and camera-specific pitch labels. Compare complete validated engineering cards and retain job handles before cancellation. Focused and native acceptance is pinned to treef8a423b21f. Full CI has been invoked separately and is not claimed green. Landing follows the render integration policy in #5493. * fix(render): resolve showcase licence and upstream resource hygiene (#5493) Record SychPL's explicit MIT OR Apache-2.0 grant, retaining source/model bytes and the Ubuntu lettering notice. Remove 80 absent attribution rows, personal fork records, dead delivery attributes and three fork/resource-only workflows. Existing xtask assets now performs bounded offline hash checks and rejects orphan render attribution; no parallel draft CI or package installation. Original authoring reproduction remains explicit. Scoped xtask tests, assets, Clippy, formatting and prepared SELENE validation pass; no application or renderer-wide result is inferred. * fix(render): align saved bounds and progressive sample resolution (#5493) Address review r4364211669/r4364211677/r4364211681/r4364211691/r4364211695. Persisted light/frame domains respect the existing 1e9 document bound; related LED/rectangle/direction cases use the same bound. Workstation primary resolve shares the 4096 admission cap and film counters use checked conversions. Exact candidate: 485 CPU render tests, 21 render document tests and strict scoped Clippy pass, including positive boundary round trips and 2048/4096 end-to-end checkpoints. No released format/migration edits, relaxed test limits or full-stack acceptance claim. * wip(render): isolate optional resources and harden sample handling (#5493) Review work in progress: opt-in encoded render library with reproducible runtime catalog exports; native-only robust dependency through the workspace; checked bloom slices; per-sample point-light diagnostics; independent area-light spatial/film keys. Resource-module binaries in both configurations, generation, Cargo production feature graphs and attribution checks pass. Full engine/render regression and combined acceptance are pending: do not merge this donor as a constituent or treat scoped resource proof as runtime acceptance. * fix(gpu): preserve donor allocations through the scope-safety repair (#5722) Port the native-validated #5723 scope-cleanup correction into the experimental donor, retaining its adaptive, volume, aging, photographic and bloom allocations. Same reverse-drain helper and regression cases; the donor combination still needs its own compile/test gate and is not covered retroactively by render-base results. * claim: #1369 * Reject unknown pending concepts after format folding (#1369) * test(render): close bounded sampling and bloom review regressions (#5493) Validate the optional-resource/lighting/dependency donor at its exact tree. Required Vulkan GPU 127/0/3; CPU renderer 487/0; engine Render 72/0; document render 21/0; lean library 7/0; strict scoped Clippy, assets/layers/lists/containers and lean-engine WASM pass. Preserve original failed controller/typing attempts. This is the draft donor/disposition source, not a replacement for constituent render PRs or final main acceptance. * wip(render): preserve stable aging target validation candidate Exact staged source from prior review work on donor3b892eab5e. This is a recovery/review checkpoint, NOT accepted delivery. An actual command-path regression currently fails because the selected executor refuses ordered surface aging. No assertion, capability or admission limit is weakened. Native/UI/full combination acceptance remains pending. Saved/runtime split adds one pending descriptor and retains original file scope; no main/render branch is changed. * test(render): preserve numeric setup intent at the admitted coordinate bound Follow up jyviko review on #5494 without weakening the corrected saved-coordinate contract. The positive clicked fixture uses 1e9 instead of inadmissible 2e9; explicit out-of-range cases still refuse, and the full saved setup round-trips through JSON and the native container. Exact-source Render workspace 95/0 and strict all-target UI Clippy pass. This does not incorporate the separately failing stable-aging candidate or claim full current-render acceptance. * test(render): use the real GPU executor for saved aging Move successful native cold-reopen Check/Start coverage from the CPU-backed protocol fixture into the production GPU executor tests. Verify capture-index changes preserve the stable target and that enabling aging changes both PNG and raw EXR output. Retain explicit, allocation-free refusal coverage for executors without aging support. Production capabilities and admission checks are unchanged. * fix(render): persist stable identities for targeted aging (#5493) Separate saved RenderBodyTarget identities from captured mesh ordinals. Reject legacy ambiguous targets, resolve Check/Start after visibility changes and preserve native reopening, copies and undo. Unsupported executors still refuse; real AMD Vulkan regression completes saved aging after reordered capture. Source tree6b84c8adpasses document 23, engine Render 75, GPU effects 5 and Render UI 95 with no failures; scoped strict Clippy, WASM and repository gates pass. Fresh CLI/native reopen and clean/aged GPU exports pass with identical physical totals and inspected actual images. Whole current-render integration is separate. * fix(render): reconcile combined CPU/GPU contracts on current upstream Unify captured resources/status and CPU-vs-GPU request schemas after the real two-parent integration; remove obsolete duplicate Vulkan selector and retain combined platform-filter regression. Deduplicate only identical or superseded test definitions, retaining the stronger card metadata and reserved-executor assertions. No assertions, admission limits or feature refusals are weakened. All targets of render dependencies, GPU, engine, UI, CLI and native app pass cargo check with raytrace-cpu and bundled-render-library at treec70d00d1. Native executable tests and full current-source acceptance remain pending. This is a private integration rehearsal for subsequent constituent PRs, not an aggregate official render/main merge. * test(render): retain one complete host lifetime regression set Deduplicate byte-identical DropProbe/task-lifetime tests and retain the adapted environment/texture ownership regressions with every assertion and complete memory estimate. Keep the registered-geometry admission regression once; only struct field order differed. Replace a one-element diagnostic loop with its equivalent block, preserving all wrap/width assertions. Test-only integration repair. Formatting and diff checks pass; refreshed executable validation is required. No production behavior, limits, assertions or ignores changed. * fix(doc): recognize the proven format-29 card descriptor alias Normalize only the historical format-29 physical-material-cards spelling, and only when material-engineering-cards is registered. Admission and migration de-duplication use the same identity. Unknown concepts, wrong versions and incapable readers still refuse before mutation. Six controlled-history Rust regressions and actual CLI migration/no-clobber acceptance pass. No version, released migration or CI changes. Refs #5793, #1369, #5493. * test(render): preserve grounding refusal before explicit instance moves Update the two Render binding fixtures for upstream first-occurrence grounding. Verify grounded movement refuses without changing document/history, then explicitly unground through the public command before the intended move. Retain every target, resource, copy and persistence assertion. Refs #5493. --------- Co-authored-by: Christian Svensson <blue@cmd.nu> Co-authored-by: Victor Santos Oliveira <56417388+Vittuu@users.noreply.github.com> Co-authored-by: cfaulkingham <colin.faulkingham@gmail.com>
6.8 KiB
Native finishing, backgrounds and linear masters
This is the owner-directed personal render integration branch. The batch ledger records the actual validation state; this document specifies behavior, not a blanket release or complete-roadmap approval.
Three independent layers
- Transport: visible native geometry, explicit optical surfaces, light emitters and HDR environment determine scene-linear radiance. No display filter changes the path estimator or engineering materials.
- Physical stage:
render.stage.backdropsaves a finite floor/wall or an explicit 24-strip polygonal cyclorama using the captured subject bounds and saved camera azimuth. These are real nonemissive render-only surfaces. Their source geometry is not inserted into the engineering model. Existing-stage replacement requires explicit consent and the reviewed revision. - Presentation: optional camera-only gradients and finishing adjust the final PNG. They do not illuminate, appear in reflections, cast shadows or represent terrain. Raw linear masters exclude them.
The cyclorama is a polygonal approximation, not an analytic smooth CAD surface or an infinite background. The layout uses world +Z as up and at least a one-mm stage envelope, without scaling the subject. Geometry, lights, HDRs, camera, surfaces and physical properties remain independent. The eight native studio compositions resolve original authored HDR resources; broader SCENE-* specifications remain labelled as specifications rather than silently promoted to executable environments.
GPU numerical intent
The following additional fields belong to saved GpuJob options or the corresponding explicit progressive runtime request:
{
"linear_exr": true,
"finishing": {
"rgb_gain": [1.0, 1.0, 1.0],
"contrast": 1.0,
"saturation": 1.0,
"vignette": 0.0
},
"backdrop": {
"mode": "vertical",
"first_srgb": [240, 243, 248],
"second_srgb": [80, 91, 109],
"center": [0.5, 0.5],
"radius": 0.75
}
}
Omitted fields preserve neutral finishing, the existing flat background and PNG-only retention. backdrop: null keeps the old flat background. Modes are vertical, horizontal and radial; screen coordinates and radial center are normalized. Color interpolation is in linear display light. A gradient and transparent PNG are mutually exclusive; unsupported combinations are errors, not silently ignored.
The processing order is: raw sample average, optional display denoising, exposure and creative linear RGB gains, selected tone map, linear-display contrast/saturation/vignette, alpha/background composition, sRGB encoding. Contrast pivots about 18% gray; saturation uses Rec.709 linear luminance weights; the vignette is an explicitly creative screen-space attenuation, not a calibrated lens. These first finishing controls require a new render and do not retroactively modify an old completed image.
Accepted bounds are RGB gains 0.1..8, contrast 0.25..4, saturation 0..2 and vignette 0..1. Controls reject NaN/infinity and unknown fields. CPU/raster and registered executors that do not implement these operations refuse them instead of dropping them.
Raw linear EXR companion
linear_exr: true retains an additional immutable file before denoising, exposure, gains, tone mapping, backdrop or display finishing. It is not a conversion of PNG pixels. RGB remains scene-linear sRGB/D65, with coverage-premultiplied alpha. The values are relative renderer radiance, not calibrated SI photometry. Values above display white are preserved.
The original encoder writes a single-part, uncompressed, increasing-Y OpenEXR scanline image with FLOAT32 A/B/G/R channels, explicit data/display windows, pixel aspect, D65 chromaticities and descriptive metadata. It is deliberately not a half-float, compressed, multipart, deep or arbitrary-AOV implementation. No new runtime dependency is added. The implementation was written from public format documentation, not copied from a third-party codec. Independent validation uses the official OpenEXR reader outside the production dependency graph.
The additional output capacity is admitted before the GPU work starts. Encoding advances through bounded scanline groups with cancellation, and the host hashes both companions in bounded chunks. The original work reservation remains live until publication, then shrinks to the capacities of both immutable files and bounded metadata. A retained frame retains its lease. A cancelled or malformed job does not publish a partial EXR.
Export selects an exact completed job:
{"job":{"session":3,"serial":1,"generation":1},"path":"output.exr","format":"exr","overwrite":false}
Export metadata names the actual encoding and alpha convention explicitly. The frame field retains canonical job identity and PNG-companion metadata; linear_master supplies the raw file length, digest, scene-linear encoding and premultiplied coverage convention. Never compare an EXR file against frame.png_sha256.
The default export remains PNG. File suffix and explicit format must agree. Request scope, atomic create/overwrite and existing-file protections are unchanged. An old completed PNG without a raw companion cannot be exported as EXR, even if the current editor has since enabled retention. The asynchronous UI picker captures the original job, document, format and overwrite consent; it cannot silently substitute a newer result.
Shared UI
The existing shared panel/form/menu/color/checkbox/number-field controls provide presentation filters under Output, camera-only gradients under Environment, and physical backgrounds under Scene. No parallel icon set or private widget library is introduced. The original scene/camera/light controls, saved numeric intent, undo and completed-image selection stay authoritative. The export-format choice is transient destination intent; raw-master retention is saved GPU intent.
Public references and clean-room boundary
- OpenEXR file layout: https://openexr.com/en/latest/OpenEXRFileLayout.html
- Technical introduction, linear values and premultiplied channels: https://openexr.com/en/latest/TechnicalIntroduction.html
- Official validation-reader API: https://openexr.com/en/latest/python.html
Only the public file-layout and data conventions informed the original encoder. The external OpenEXR reader is a test oracle, not redistributed production code. No external scene imagery, commercial CAD artwork, GPL implementation or measured optical dataset is imported.
Still separate
Adaptive sample scheduling and improved convergence of difficult transmission paths are not implemented merely by adding EXR or presentation controls. Bloom, volumetric effects, arbitrary AOVs, EXR compression and post-hoc interactive regrading of a completed master remain separate units. None is exposed as an operational control until its producer, admission, persistence and execution tests exist.