mirror of https://github.com/bherbruck/solidcraft.git synced 2026-11-04 19:15:57 +00:00

Files

T

selune 9e6e0b8df1 Render workspace: complete experimental ribbon, resources and effects integration (#5493 ) (#5494 )

* wip(render): reconcile completed material and image pipeline source with 0.20 (#5493)

Source-only integration reference for staged review, not a merge-ready aggregate.
Donor: 0xlillith/solidcraft@aea20b0115.
Upstream: 858e5995d6.

Retain original CPU/material contracts and explicit GPU donor provenance in
docs/render-materials-lab.md (#2067, #2191, #2780, #3306). Preserve released
format migrations and current navigation/startup/shell behavior. New saved
records use pending descriptors. The physical-card descriptor follows the
maintainer's material-engineering-cards naming request, with a legacy-lab
format-29 regression. Replace raw new panel hosts with shared containers.

Repository checks, complete workspace/all-target Clippy, and the independent
physical/resource authoring checks pass for this source. The fresh full local
CI invocation has reached test compilation and is not yet complete. Do not
transfer donor native output or prior test totals to this integration.

Generated review screenshots, video, package ZIP and machine logs remain at
the immutable personal evidence pin. Uncommitted geometric displacement is
backed up separately, not silently included. No kernel/vendor change, direct
main write, release or independent contributor-branch rewrite.

Co-authored-by: Christian Svensson <blue@cmd.nu>

* test(cli): pin the Compact camera-sample admission diagnostic (#5493)

The bounded request still refuses 1024x1024x64 samples before host initialization and writes no output. Update only the stale expected diagnostic to the existing Compact budget wording; production limits and code are unchanged. Exact-tree CLI regression suite: 14 passed, 0 failed. The full repository gate has been invoked separately and is not yet complete.

* Normalize UI container violation paths across platforms

Report repository-relative paths with forward slashes so diagnostics and the existing nested-package regression assertions agree on Windows and Unix. Keep the container detection rules unchanged.

Validation: official ui-containers gate and all seven focused xtask tests passed; rustfmt and diff checks passed. Only xtask/dependencies were compiled; no application build or heavy tests.
(cherry picked from commit 44b58d8e10)

* fix(render): preserve camera contracts and correct acceptance regressions (#5493)

Preserve Design view.apply semantics with a separate strict Render camera command. Retain existing translations when English-only aliases collide; add material-axis entries and camera-specific pitch labels. Compare complete validated engineering cards and retain job handles before cancellation.

Focused and native acceptance is pinned to tree f8a423b21f. Full CI has been invoked separately and is not claimed green. Landing follows the render integration policy in #5493.

* fix(render): resolve showcase licence and upstream resource hygiene (#5493)

Record SychPL's explicit MIT OR Apache-2.0 grant, retaining source/model bytes and the Ubuntu lettering notice. Remove 80 absent attribution rows, personal fork records, dead delivery attributes and three fork/resource-only workflows. Existing xtask assets now performs bounded offline hash checks and rejects orphan render attribution; no parallel draft CI or package installation. Original authoring reproduction remains explicit. Scoped xtask tests, assets, Clippy, formatting and prepared SELENE validation pass; no application or renderer-wide result is inferred.

* fix(render): align saved bounds and progressive sample resolution (#5493)

Address review r4364211669/r4364211677/r4364211681/r4364211691/r4364211695. Persisted light/frame domains respect the existing 1e9 document bound; related LED/rectangle/direction cases use the same bound. Workstation primary resolve shares the 4096 admission cap and film counters use checked conversions. Exact candidate: 485 CPU render tests, 21 render document tests and strict scoped Clippy pass, including positive boundary round trips and 2048/4096 end-to-end checkpoints. No released format/migration edits, relaxed test limits or full-stack acceptance claim.

* wip(render): isolate optional resources and harden sample handling (#5493)

Review work in progress: opt-in encoded render library with reproducible runtime catalog exports; native-only robust dependency through the workspace; checked bloom slices; per-sample point-light diagnostics; independent area-light spatial/film keys. Resource-module binaries in both configurations, generation, Cargo production feature graphs and attribution checks pass. Full engine/render regression and combined acceptance are pending: do not merge this donor as a constituent or treat scoped resource proof as runtime acceptance.

* fix(gpu): preserve donor allocations through the scope-safety repair (#5722)

Port the native-validated #5723 scope-cleanup correction into the experimental donor, retaining its adaptive, volume, aging, photographic and bloom allocations. Same reverse-drain helper and regression cases; the donor combination still needs its own compile/test gate and is not covered retroactively by render-base results.

* claim: #1369

* Reject unknown pending concepts after format folding (#1369)

* test(render): close bounded sampling and bloom review regressions (#5493)

Validate the optional-resource/lighting/dependency donor at its exact tree. Required Vulkan GPU 127/0/3; CPU renderer 487/0; engine Render 72/0; document render 21/0; lean library 7/0; strict scoped Clippy, assets/layers/lists/containers and lean-engine WASM pass. Preserve original failed controller/typing attempts. This is the draft donor/disposition source, not a replacement for constituent render PRs or final main acceptance.

* wip(render): preserve stable aging target validation candidate

Exact staged source from prior review work on donor 3b892eab5e. This is a recovery/review checkpoint, NOT accepted delivery. An actual command-path regression currently fails because the selected executor refuses ordered surface aging. No assertion, capability or admission limit is weakened. Native/UI/full combination acceptance remains pending. Saved/runtime split adds one pending descriptor and retains original file scope; no main/render branch is changed.

* test(render): preserve numeric setup intent at the admitted coordinate bound

Follow up jyviko review on #5494 without weakening the corrected saved-coordinate contract. The positive clicked fixture uses 1e9 instead of inadmissible 2e9; explicit out-of-range cases still refuse, and the full saved setup round-trips through JSON and the native container. Exact-source Render workspace 95/0 and strict all-target UI Clippy pass. This does not incorporate the separately failing stable-aging candidate or claim full current-render acceptance.

* test(render): use the real GPU executor for saved aging

Move successful native cold-reopen Check/Start coverage from the CPU-backed protocol fixture into the production GPU executor tests. Verify capture-index changes preserve the stable target and that enabling aging changes both PNG and raw EXR output. Retain explicit, allocation-free refusal coverage for executors without aging support. Production capabilities and admission checks are unchanged.

* fix(render): persist stable identities for targeted aging (#5493)

Separate saved RenderBodyTarget identities from captured mesh ordinals. Reject legacy ambiguous targets, resolve Check/Start after visibility changes and preserve native reopening, copies and undo. Unsupported executors still refuse; real AMD Vulkan regression completes saved aging after reordered capture.

Source tree 6b84c8ad passes document 23, engine Render 75, GPU effects 5 and Render UI 95 with no failures; scoped strict Clippy, WASM and repository gates pass. Fresh CLI/native reopen and clean/aged GPU exports pass with identical physical totals and inspected actual images. Whole current-render integration is separate.

* fix(render): reconcile combined CPU/GPU contracts on current upstream

Unify captured resources/status and CPU-vs-GPU request schemas after the real two-parent integration; remove obsolete duplicate Vulkan selector and retain combined platform-filter regression. Deduplicate only identical or superseded test definitions, retaining the stronger card metadata and reserved-executor assertions. No assertions, admission limits or feature refusals are weakened.

All targets of render dependencies, GPU, engine, UI, CLI and native app pass cargo check with raytrace-cpu and bundled-render-library at tree c70d00d1. Native executable tests and full current-source acceptance remain pending. This is a private integration rehearsal for subsequent constituent PRs, not an aggregate official render/main merge.

* test(render): retain one complete host lifetime regression set

Deduplicate byte-identical DropProbe/task-lifetime tests and retain the adapted environment/texture ownership regressions with every assertion and complete memory estimate. Keep the registered-geometry admission regression once; only struct field order differed. Replace a one-element diagnostic loop with its equivalent block, preserving all wrap/width assertions.

Test-only integration repair. Formatting and diff checks pass; refreshed executable validation is required. No production behavior, limits, assertions or ignores changed.

* fix(doc): recognize the proven format-29 card descriptor alias

Normalize only the historical format-29 physical-material-cards spelling, and only when material-engineering-cards is registered. Admission and migration de-duplication use the same identity. Unknown concepts, wrong versions and incapable readers still refuse before mutation. Six controlled-history Rust regressions and actual CLI migration/no-clobber acceptance pass. No version, released migration or CI changes. Refs #5793, #1369, #5493.

* test(render): preserve grounding refusal before explicit instance moves

Update the two Render binding fixtures for upstream first-occurrence grounding. Verify grounded movement refuses without changing document/history, then explicitly unground through the public command before the intended move. Retain every target, resource, copy and persistence assertion. Refs #5493.

---------

Co-authored-by: Christian Svensson <blue@cmd.nu>
Co-authored-by: Victor Santos Oliveira <56417388+Vittuu@users.noreply.github.com>
Co-authored-by: cfaulkingham <colin.faulkingham@gmail.com>

2026-10-24 14:21:59 +00:00

7.8 KiB

Raw Permalink Blame History

Clean-room authorship and asset admission

This contribution

All catalog descriptions, selection criteria, preset numbers, UX flows, analytic fixtures, validation tooling and implementation plans were authored for this SolidCraft contribution from the user's requirements, general rendering and engineering principles, public specifications, scientific facts and the project's own public contracts. Their provenance identifier is ORIGINAL-2026-10-CATALOG.

No material library, texture, HDR panorama, template, shader implementation, help passage, screenshot, icon, font or UI artwork was extracted from a commercial CAD or rendering product. No commercial CAD application was driven or automated. No GPL, LGPL or AGPL implementation was read, copied, linked or used as an implementation reference. Product comparison names describe the intended quality bar; they do not authorize borrowing their implementations or content.

The public OpenPBR surface specification was consulted for the existence and scope of a layered material model. This package contains original requirements and prose, not a copy of its specification, artwork, source code or example shaders. A future implementation must independently review the specification and any proposed dependency against the repository policy.

NASA pages were consulted for limited scientific facts. No NASA imagery, terrain file, animation, logo or texture is bundled. The procedural lunar concepts are original proposed scenes, not reconstructed NASA datasets or certified locations. A future terrain or ephemeris import requires its own source, version, rights and coordinate record.

The user's original v7 SELENE model repository remains a pinned historical reference; that legacy file and its demonstration media are not bundled. The current package retains the owner-supplied improved SELENE-showcase.solidcraft unchanged under assets/render/selene/source/. SOURCE.md records its byte identity, author lineage and reviewed notices. Original rover and emblem attribution and the separate Ubuntu Font Licence 1.0 notice for modeled Ubuntu Light lettering accompany the source and must remain with its derivatives. The author's showcase branch does not separately declare a file-specific license for its additions; the source lock preserves that distinction.

The continuation adds original numerical appearance recipes, an analytic-box swatch script, scene/role/shot specifications and native geometry and mechanism authoring tools under assets/render/selene/. Tangency's own public mechanism documentation and PR discussions explain the improved variant's documented behavior. Published demonstration media remain reference material and are not copied into this package. The supplied native source has its own pinned identity and retained notices; each separately named derivative must record its own hash and runtime evidence.

The UI continuation uses SolidCraft's own implemented shell, UI kit, theme and accepted SVGs as its design authority. It records a read-only comparison between the fixed integration base and upstream 728f753b8094e1a54c5cc8b7e453982afa028023 in ui-integration.json. Original integration prose and metadata are added; no icon master, palette, acceptance hash, commercial reference or application UI implementation is copied or changed. Temporary previews of existing project icons stay outside the shipped resource package.

What was inspected

SolidCraft's own AGENTS.md, CONTRIBUTING.md, architecture, render settings, render workspace, render backend and physical-material-card documentation at the pinned integration base.
SolidCraft's own attribution, asset validation and CI selection rules to place this contribution correctly.
SELENE's README, attribution, model statistics and models/Rover-v7.solidcraft at the pinned source revision.
Tangency Labs' own mechanism reference and public showcase, motion export and motion analysis discussions, identified in the prepared source lock.
The owner-supplied SELENE-showcase.solidcraft, its matching author-published Git blob, retained font notice, and official authoring-runtime identity, as recorded in the native package's source lock.
Public scientific and specification pages identified in SOURCES.md.

The local-only plan/ directory was absent from the isolated public checkout. This contribution neither invents its contents nor commits a replacement. The user's explicit destination is the personal render/materials fork, so this work targets that branch through a dedicated PR instead of the upstream product repository.

Resource lifecycle

concept → authored → bound → validated → published.

A concept contains an intended appearance or environment and its requirements. An authored resource adds actual parameter values, maps or geometry. A bound resource resolves those values against a named executor and resource schema. A validated resource passes recorded visual, numeric, performance and provenance checks. A published resource is admitted to a versioned user-facing pack. No transition follows automatically from generation or import.

Future procedural and AI-assisted assets

For each authored resource retain:

Stable ID, resource version, authoring method, author/reviewer and creation date.
Source URLs and revisions, acquired files and hashes, permissions and retained notices where external input exists.
Generator version, deterministic seed, parameters and build instructions for procedural work.
For AI-assisted work: generator/model version when available, prompt, supplied input rights, output hash, human edits and review outcome. Do not state that the model's training data has been independently audited.
Intended map roles, color space, physical scale, orientation, normal convention, tiling policy and resolution.
Executor requirements, fallback status, preview evidence and regression scene IDs.

AI-generated material images may contain baked highlights or shadows, inconsistent normal/height information, misleading scale or invented markings. Treat an attractive image as a candidate source, then reconstruct and inspect the surface maps. Never use a single generated beauty image as proof of an energy-consistent material. An AI-generated panorama is not automatically a calibrated HDR light probe; declare its radiance assumptions and verify highlight energy before allowing it to illuminate a physical scene.

Use descriptive physical or manufacturing language for materials. Brand names, certifications, standardized color matches, measured optical constants and space qualification require the corresponding evidence. Appearance presets may suggest a manufactured finish without asserting alloy composition, fire rating, vacuum compatibility, structural strength or flight readiness.

Attribution and licensing

Original contribution files follow this repository's MIT OR Apache-2.0 license choice. Exact non-Markdown resource and tooling paths are recorded in the root ATTRIBUTION.md; the source ledger records the limited purpose of external references. A reference link does not relicense the referenced work. External content added in a future PR must carry its own explicit license assessment and notice before admission.

Review checklist

Review the diff for copied passages, brand assets, untracked binary inputs and unintended source URLs.
Verify that every shipped external file has provenance and an applicable license; original descriptions are not evidence for third-party map rights.
Keep concept availability separate from executor support and visual validation.
Confirm that CAD geometry, engineering properties and the original SELENE source remain unchanged unless a separate, explicit derivative is part of the reviewed task.
Record actual checks and unresolved limitations in the PR. Do not turn a planning document into a claim of runtime implementation.

7.8 KiB Raw Permalink Blame History