* wip(render): reconcile completed material and image pipeline source with 0.20 (#5493) Source-only integration reference for staged review, not a merge-ready aggregate. Donor: 0xlillith/solidcraft@aea20b0115. Upstream:858e5995d6. Retain original CPU/material contracts and explicit GPU donor provenance in docs/render-materials-lab.md (#2067, #2191, #2780, #3306). Preserve released format migrations and current navigation/startup/shell behavior. New saved records use pending descriptors. The physical-card descriptor follows the maintainer's material-engineering-cards naming request, with a legacy-lab format-29 regression. Replace raw new panel hosts with shared containers. Repository checks, complete workspace/all-target Clippy, and the independent physical/resource authoring checks pass for this source. The fresh full local CI invocation has reached test compilation and is not yet complete. Do not transfer donor native output or prior test totals to this integration. Generated review screenshots, video, package ZIP and machine logs remain at the immutable personal evidence pin. Uncommitted geometric displacement is backed up separately, not silently included. No kernel/vendor change, direct main write, release or independent contributor-branch rewrite. Co-authored-by: Christian Svensson <blue@cmd.nu> * test(cli): pin the Compact camera-sample admission diagnostic (#5493) The bounded request still refuses 1024x1024x64 samples before host initialization and writes no output. Update only the stale expected diagnostic to the existing Compact budget wording; production limits and code are unchanged. Exact-tree CLI regression suite: 14 passed, 0 failed. The full repository gate has been invoked separately and is not yet complete. * Normalize UI container violation paths across platforms Report repository-relative paths with forward slashes so diagnostics and the existing nested-package regression assertions agree on Windows and Unix. Keep the container detection rules unchanged. Validation: official ui-containers gate and all seven focused xtask tests passed; rustfmt and diff checks passed. Only xtask/dependencies were compiled; no application build or heavy tests. (cherry picked from commit44b58d8e10) * fix(render): preserve camera contracts and correct acceptance regressions (#5493) Preserve Design view.apply semantics with a separate strict Render camera command. Retain existing translations when English-only aliases collide; add material-axis entries and camera-specific pitch labels. Compare complete validated engineering cards and retain job handles before cancellation. Focused and native acceptance is pinned to treef8a423b21f. Full CI has been invoked separately and is not claimed green. Landing follows the render integration policy in #5493. * fix(render): resolve showcase licence and upstream resource hygiene (#5493) Record SychPL's explicit MIT OR Apache-2.0 grant, retaining source/model bytes and the Ubuntu lettering notice. Remove 80 absent attribution rows, personal fork records, dead delivery attributes and three fork/resource-only workflows. Existing xtask assets now performs bounded offline hash checks and rejects orphan render attribution; no parallel draft CI or package installation. Original authoring reproduction remains explicit. Scoped xtask tests, assets, Clippy, formatting and prepared SELENE validation pass; no application or renderer-wide result is inferred. * fix(render): align saved bounds and progressive sample resolution (#5493) Address review r4364211669/r4364211677/r4364211681/r4364211691/r4364211695. Persisted light/frame domains respect the existing 1e9 document bound; related LED/rectangle/direction cases use the same bound. Workstation primary resolve shares the 4096 admission cap and film counters use checked conversions. Exact candidate: 485 CPU render tests, 21 render document tests and strict scoped Clippy pass, including positive boundary round trips and 2048/4096 end-to-end checkpoints. No released format/migration edits, relaxed test limits or full-stack acceptance claim. * wip(render): isolate optional resources and harden sample handling (#5493) Review work in progress: opt-in encoded render library with reproducible runtime catalog exports; native-only robust dependency through the workspace; checked bloom slices; per-sample point-light diagnostics; independent area-light spatial/film keys. Resource-module binaries in both configurations, generation, Cargo production feature graphs and attribution checks pass. Full engine/render regression and combined acceptance are pending: do not merge this donor as a constituent or treat scoped resource proof as runtime acceptance. * fix(gpu): preserve donor allocations through the scope-safety repair (#5722) Port the native-validated #5723 scope-cleanup correction into the experimental donor, retaining its adaptive, volume, aging, photographic and bloom allocations. Same reverse-drain helper and regression cases; the donor combination still needs its own compile/test gate and is not covered retroactively by render-base results. * claim: #1369 * Reject unknown pending concepts after format folding (#1369) * test(render): close bounded sampling and bloom review regressions (#5493) Validate the optional-resource/lighting/dependency donor at its exact tree. Required Vulkan GPU 127/0/3; CPU renderer 487/0; engine Render 72/0; document render 21/0; lean library 7/0; strict scoped Clippy, assets/layers/lists/containers and lean-engine WASM pass. Preserve original failed controller/typing attempts. This is the draft donor/disposition source, not a replacement for constituent render PRs or final main acceptance. * wip(render): preserve stable aging target validation candidate Exact staged source from prior review work on donor3b892eab5e. This is a recovery/review checkpoint, NOT accepted delivery. An actual command-path regression currently fails because the selected executor refuses ordered surface aging. No assertion, capability or admission limit is weakened. Native/UI/full combination acceptance remains pending. Saved/runtime split adds one pending descriptor and retains original file scope; no main/render branch is changed. * test(render): preserve numeric setup intent at the admitted coordinate bound Follow up jyviko review on #5494 without weakening the corrected saved-coordinate contract. The positive clicked fixture uses 1e9 instead of inadmissible 2e9; explicit out-of-range cases still refuse, and the full saved setup round-trips through JSON and the native container. Exact-source Render workspace 95/0 and strict all-target UI Clippy pass. This does not incorporate the separately failing stable-aging candidate or claim full current-render acceptance. * test(render): use the real GPU executor for saved aging Move successful native cold-reopen Check/Start coverage from the CPU-backed protocol fixture into the production GPU executor tests. Verify capture-index changes preserve the stable target and that enabling aging changes both PNG and raw EXR output. Retain explicit, allocation-free refusal coverage for executors without aging support. Production capabilities and admission checks are unchanged. * fix(render): persist stable identities for targeted aging (#5493) Separate saved RenderBodyTarget identities from captured mesh ordinals. Reject legacy ambiguous targets, resolve Check/Start after visibility changes and preserve native reopening, copies and undo. Unsupported executors still refuse; real AMD Vulkan regression completes saved aging after reordered capture. Source tree6b84c8adpasses document 23, engine Render 75, GPU effects 5 and Render UI 95 with no failures; scoped strict Clippy, WASM and repository gates pass. Fresh CLI/native reopen and clean/aged GPU exports pass with identical physical totals and inspected actual images. Whole current-render integration is separate. * fix(render): reconcile combined CPU/GPU contracts on current upstream Unify captured resources/status and CPU-vs-GPU request schemas after the real two-parent integration; remove obsolete duplicate Vulkan selector and retain combined platform-filter regression. Deduplicate only identical or superseded test definitions, retaining the stronger card metadata and reserved-executor assertions. No assertions, admission limits or feature refusals are weakened. All targets of render dependencies, GPU, engine, UI, CLI and native app pass cargo check with raytrace-cpu and bundled-render-library at treec70d00d1. Native executable tests and full current-source acceptance remain pending. This is a private integration rehearsal for subsequent constituent PRs, not an aggregate official render/main merge. * test(render): retain one complete host lifetime regression set Deduplicate byte-identical DropProbe/task-lifetime tests and retain the adapted environment/texture ownership regressions with every assertion and complete memory estimate. Keep the registered-geometry admission regression once; only struct field order differed. Replace a one-element diagnostic loop with its equivalent block, preserving all wrap/width assertions. Test-only integration repair. Formatting and diff checks pass; refreshed executable validation is required. No production behavior, limits, assertions or ignores changed. * fix(doc): recognize the proven format-29 card descriptor alias Normalize only the historical format-29 physical-material-cards spelling, and only when material-engineering-cards is registered. Admission and migration de-duplication use the same identity. Unknown concepts, wrong versions and incapable readers still refuse before mutation. Six controlled-history Rust regressions and actual CLI migration/no-clobber acceptance pass. No version, released migration or CI changes. Refs #5793, #1369, #5493. * test(render): preserve grounding refusal before explicit instance moves Update the two Render binding fixtures for upstream first-occurrence grounding. Verify grounded movement refuses without changing document/history, then explicitly unground through the public command before the intended move. Retain every target, resource, copy and persistence assertion. Refs #5493. --------- Co-authored-by: Christian Svensson <blue@cmd.nu> Co-authored-by: Victor Santos Oliveira <56417388+Vittuu@users.noreply.github.com> Co-authored-by: cfaulkingham <colin.faulkingham@gmail.com>
9.5 KiB
Presets: quality, studio, environment and complete scenes
Four independent recipe types
| Recipe | Owns | Must preserve unless explicitly included |
|---|---|---|
Quality (Q-*) |
Resolution, integrator intent, convergence budget, image output | Appearance, rig, environment, camera pose and CAD geometry |
Studio (STU-*) |
Sources, passive cards, flags and source normalization | Engineering properties, model scale, output quality and camera |
Environment (ENVSET-*) |
Stage geometry, ground, ambient field, sky/Sun policy | Subject geometry, engineering material and locked shot fields |
Scene (SCENE-*) |
A reviewed composition of the above plus material roles | User locks and unrelated document state |
All four are future specifications with status specified_unbound. Numeric values are original starting points for calibration. They are not accepted runtime JSON commands, measured photometry or a guarantee that the current executor can render them.
baseline-setup-commands.json is deliberately a different file and shape: it contains six examples of the currently documented render.settings.set command. Those examples store builtin preview dimensions, background and documented exposure/environment fields. They omit the camera to preserve it. They were checked against the published contract, not executed in an application in this contribution. A saved field must not be assumed to affect shading unless the selected backend implements it.
Quality targets
The sample columns are minimum and maximum samples per pixel for a future path-tracing adapter. Error targets refer to a versioned relative standard-error estimator on scene-linear luminance with an explicitly defined dark-signal floor. The adapter must bind the estimator before use; these numbers are not interchangeable with another renderer's “noise” slider.
| ID | Name | Resolution | Samples min–max | Relative error target | Total / transmission depth | Denoising |
|---|---|---|---|---|---|---|
| Q-001 | Interactive Draft | 960 × 540 | 8–64 | 0.12 | 4 / 2 | Off |
| Q-002 | Balanced Product | 1600 × 900 | 32–512 | 0.035 | 8 / 6 | On, retain raw |
| Q-003 | Product Portfolio | 2560 × 1440 | 64–2048 | 0.015 | 12 / 10 | On, retain raw |
| Q-004 | Glass and Layers | 2560 × 1440 | 128–4096 | 0.010 | 20 / 16 | On, retain raw |
| Q-005 | LED Optical Study | 2560 × 1440 | 128–4096 | 0.010 | 20 / 16 | Off |
| Q-006 | Lunar Hero Master | 3840 × 2160 | 256–8192 | 0.005 | 24 / 20 | Off |
| Q-007 | Lunar Sample Macro | 3072 × 3072 | 256–8192 | 0.005 | 24 / 20 | Off |
| Q-008 | Animation Preview | 1280 × 720 | 16–256 | 0.060 | 8 / 6 | Off |
| Q-009 | Animation Final | 3840 × 2160 | 128–4096 | 0.012 | 16 / 12 | Off |
| Q-010 | Reference Convergence | 2048 × 2048 | 1024–16384 | 0.002 | 32 / 24 | Off |
Q-006 and Q-007 are initial maximum-quality demonstration targets with bounded work. Hitting the maximum sample count before convergence must produce an unconverged result and diagnostics, not a “maximum quality complete” badge. Finite path depth is still a truncation; compensated Russian roulette does not remove that separate approximation. A higher-resolution output needs a resource admission check and potentially tiled rendering.
Q-008 and Q-009 request motion blur from an approved bake, using a half-frame shutter centered on the frame time and initial temporal stratification counts of 8 and 32 respectively. Each camera path samples one time within the shutter; the strata count does not multiply the per-pixel path budget. Bind a positive finite shot frame rate before execution: shutter duration is 0.5 / frame_rate_hz seconds. Physics solver substeps are independent of both quantities. Temporal denoising is not required by these profiles; any later enablement requires a motion-stability comparison against raw frames.
No target makes a frame-rate or render-time promise. Report executor, version, device, memory, scene complexity, preparation time, elapsed render time and remaining error. Quality profiles requiring EXR depend on an actual linear encoder; the current contract's ability to store the string exr is insufficient.
Coordinates and scale
Studio rigs use a selected subject's maximum positive bounding-box extent B. Their position_b, target_b and size_b values are dimensionless multiples of B. Resolve these once to millimeters after an explicit fit action. The source origin is the subject center unless a preset explicitly uses an optical aperture. +Z is up, -Y is front and +X is right. Camera motion never rotates a fixed rig. Animated arm poses must not refit lights every frame.
Environment geometry has explicit millimeter dimensions. An environment may reposition a support or reframe a camera on request; it cannot silently rescale the subject or stretch a room. If the subject exceeds the preset's declared clearance, preflight offers a different stage or an explicit stage resize. Texture scale also stays physical: a 0.2 mm print layer must not turn into a 20 mm ridge when a part grows.
All stored angles use radians. UI labels may display degrees using a reversible conversion. Sun direction is a direction at effectively infinite distance, separate from a nearby area-light position.
Source normalization and color
Studio source intensities use reference_contribution_ev against CAL-LIGHT-001, whose definition is in lighting-guide.md. This is an authoring calibration convention, not a claim of measured lumens, candela or watts. The runtime adapter must resolve it for source type, area, distance, spectral/color assumptions and applied scale, then store the resolved physical units. Do not equate identical numeric values across point, area and emissive-mesh sources.
Source RGB values and passive-card reflectances declare a linear working space. A neutral RGB emitter is not automatically a specified blackbody spectrum. Spectral LED studies need an independently sourced spectral distribution; RGB appearance alone cannot establish optical efficiency, phosphor behavior or spectral dispersion.
The scene-linear output, exposure, view transform and output encoding remain distinct. Bloom is a camera treatment and does not illuminate the scene. A visible emissive surface and an analytic sampling representation share one energy owner. Any proxy must be an implementation of that contribution, not an additional lamp.
Composition and ownership
The resolver proceeds in this order:
- Resolve resource versions and hashes, subject binding and explicit material roles.
- Validate units, geometry clearance, stage size, required capabilities and memory admission.
- Combine owners for Sun, ambient field, subject emitters and source proxies.
- Resolve explicit composition overrides, inherited values and user locks; show conflicts before mutation.
- Produce an immutable request with source and resolved values, then apply atomically through one engine command.
The supplied studio scene combinations explicitly set environment_overrides.ambient_scale to zero because their studio ratios assume no unaccounted ambient source. They also use scene geometry for the visible stage background. These are visible composition choices, not hidden alterations performed by the lighting rig. An environment used on its own retains its declared ambient field.
Physical lunar combinations use the environment-owned Sun with a pass-through rig. STU-020 is an alternative single-Sun owner for separately authored scenes; it cannot be merged with another enabled Sun. STU-022 intentionally requires a zero-source night audit. The supplied full-shadow environment instead retains a Sun behind occluding terrain; do not confuse absence of direct illumination at the subject with removal of the Sun.
Physical lunar recipes have no atmospheric scattering or artificial sky dome. Reflection from terrain, rover surfaces, a properly resolved Earth and actual hardware lights may illuminate shadows when included. An editorial fill, star overlay or decoupled background changes the scene's mode and saved fidelity label. A nearly black physical result is a valid diagnostic outcome, not an invitation to secretly add fill.
Material role binding
A scene names roles such as rover_structure, vial_glass, lunar_mare_regolith or pcb_solder_mask, then maps them to catalog IDs. A material ID resolves to a concept at this stage; before application it must resolve further to a versioned authored resource. Never guess face assignments solely from a fuzzy body-name match.
SELENE's inspected component and body-name references are stored in selene-bindings.json. Validate the native-file hash and the expected occurrence graph before offering automatic assignment. Unmatched or ambiguous geometry produces a selection task for the user; it does not receive a guessed appearance.
Current-contract setup examples
The six examples are Draft 720p, Presentation 1080p, Square Detail, Portrait Product, Technical Review and Dark Detail. They remain within the published 4096-per-axis and 4,194,304-total-pixel limits and use backend: builtin, mode: preview, format: png. They introduce six named setups and may replace an existing setup with the same name, following the command's behavior. The caller must inspect the existing setup count and reject a combined total above the documented maximum of 32.
Do not send the larger Q-006, Q-007 or Q-009 resolutions through the current settings examples. Do not pass quality, rig or environment recipe objects to render.settings.set. Future integration needs typed contracts and capability-aware adapters first.