selune
9e6e0b8df1
* wip(render): reconcile completed material and image pipeline source with 0.20 (#5493) Source-only integration reference for staged review, not a merge-ready aggregate. Donor: 0xlillith/solidcraft@aea20b0115. Upstream:858e5995d6. Retain original CPU/material contracts and explicit GPU donor provenance in docs/render-materials-lab.md (#2067, #2191, #2780, #3306). Preserve released format migrations and current navigation/startup/shell behavior. New saved records use pending descriptors. The physical-card descriptor follows the maintainer's material-engineering-cards naming request, with a legacy-lab format-29 regression. Replace raw new panel hosts with shared containers. Repository checks, complete workspace/all-target Clippy, and the independent physical/resource authoring checks pass for this source. The fresh full local CI invocation has reached test compilation and is not yet complete. Do not transfer donor native output or prior test totals to this integration. Generated review screenshots, video, package ZIP and machine logs remain at the immutable personal evidence pin. Uncommitted geometric displacement is backed up separately, not silently included. No kernel/vendor change, direct main write, release or independent contributor-branch rewrite. Co-authored-by: Christian Svensson <blue@cmd.nu> * test(cli): pin the Compact camera-sample admission diagnostic (#5493) The bounded request still refuses 1024x1024x64 samples before host initialization and writes no output. Update only the stale expected diagnostic to the existing Compact budget wording; production limits and code are unchanged. Exact-tree CLI regression suite: 14 passed, 0 failed. The full repository gate has been invoked separately and is not yet complete. * Normalize UI container violation paths across platforms Report repository-relative paths with forward slashes so diagnostics and the existing nested-package regression assertions agree on Windows and Unix. Keep the container detection rules unchanged. Validation: official ui-containers gate and all seven focused xtask tests passed; rustfmt and diff checks passed. Only xtask/dependencies were compiled; no application build or heavy tests. (cherry picked from commit44b58d8e10) * fix(render): preserve camera contracts and correct acceptance regressions (#5493) Preserve Design view.apply semantics with a separate strict Render camera command. Retain existing translations when English-only aliases collide; add material-axis entries and camera-specific pitch labels. Compare complete validated engineering cards and retain job handles before cancellation. Focused and native acceptance is pinned to treef8a423b21f. Full CI has been invoked separately and is not claimed green. Landing follows the render integration policy in #5493. * fix(render): resolve showcase licence and upstream resource hygiene (#5493) Record SychPL's explicit MIT OR Apache-2.0 grant, retaining source/model bytes and the Ubuntu lettering notice. Remove 80 absent attribution rows, personal fork records, dead delivery attributes and three fork/resource-only workflows. Existing xtask assets now performs bounded offline hash checks and rejects orphan render attribution; no parallel draft CI or package installation. Original authoring reproduction remains explicit. Scoped xtask tests, assets, Clippy, formatting and prepared SELENE validation pass; no application or renderer-wide result is inferred. * fix(render): align saved bounds and progressive sample resolution (#5493) Address review r4364211669/r4364211677/r4364211681/r4364211691/r4364211695. Persisted light/frame domains respect the existing 1e9 document bound; related LED/rectangle/direction cases use the same bound. Workstation primary resolve shares the 4096 admission cap and film counters use checked conversions. Exact candidate: 485 CPU render tests, 21 render document tests and strict scoped Clippy pass, including positive boundary round trips and 2048/4096 end-to-end checkpoints. No released format/migration edits, relaxed test limits or full-stack acceptance claim. * wip(render): isolate optional resources and harden sample handling (#5493) Review work in progress: opt-in encoded render library with reproducible runtime catalog exports; native-only robust dependency through the workspace; checked bloom slices; per-sample point-light diagnostics; independent area-light spatial/film keys. Resource-module binaries in both configurations, generation, Cargo production feature graphs and attribution checks pass. Full engine/render regression and combined acceptance are pending: do not merge this donor as a constituent or treat scoped resource proof as runtime acceptance. * fix(gpu): preserve donor allocations through the scope-safety repair (#5722) Port the native-validated #5723 scope-cleanup correction into the experimental donor, retaining its adaptive, volume, aging, photographic and bloom allocations. Same reverse-drain helper and regression cases; the donor combination still needs its own compile/test gate and is not covered retroactively by render-base results. * claim: #1369 * Reject unknown pending concepts after format folding (#1369) * test(render): close bounded sampling and bloom review regressions (#5493) Validate the optional-resource/lighting/dependency donor at its exact tree. Required Vulkan GPU 127/0/3; CPU renderer 487/0; engine Render 72/0; document render 21/0; lean library 7/0; strict scoped Clippy, assets/layers/lists/containers and lean-engine WASM pass. Preserve original failed controller/typing attempts. This is the draft donor/disposition source, not a replacement for constituent render PRs or final main acceptance. * wip(render): preserve stable aging target validation candidate Exact staged source from prior review work on donor3b892eab5e. This is a recovery/review checkpoint, NOT accepted delivery. An actual command-path regression currently fails because the selected executor refuses ordered surface aging. No assertion, capability or admission limit is weakened. Native/UI/full combination acceptance remains pending. Saved/runtime split adds one pending descriptor and retains original file scope; no main/render branch is changed. * test(render): preserve numeric setup intent at the admitted coordinate bound Follow up jyviko review on #5494 without weakening the corrected saved-coordinate contract. The positive clicked fixture uses 1e9 instead of inadmissible 2e9; explicit out-of-range cases still refuse, and the full saved setup round-trips through JSON and the native container. Exact-source Render workspace 95/0 and strict all-target UI Clippy pass. This does not incorporate the separately failing stable-aging candidate or claim full current-render acceptance. * test(render): use the real GPU executor for saved aging Move successful native cold-reopen Check/Start coverage from the CPU-backed protocol fixture into the production GPU executor tests. Verify capture-index changes preserve the stable target and that enabling aging changes both PNG and raw EXR output. Retain explicit, allocation-free refusal coverage for executors without aging support. Production capabilities and admission checks are unchanged. * fix(render): persist stable identities for targeted aging (#5493) Separate saved RenderBodyTarget identities from captured mesh ordinals. Reject legacy ambiguous targets, resolve Check/Start after visibility changes and preserve native reopening, copies and undo. Unsupported executors still refuse; real AMD Vulkan regression completes saved aging after reordered capture. Source tree6b84c8adpasses document 23, engine Render 75, GPU effects 5 and Render UI 95 with no failures; scoped strict Clippy, WASM and repository gates pass. Fresh CLI/native reopen and clean/aged GPU exports pass with identical physical totals and inspected actual images. Whole current-render integration is separate. * fix(render): reconcile combined CPU/GPU contracts on current upstream Unify captured resources/status and CPU-vs-GPU request schemas after the real two-parent integration; remove obsolete duplicate Vulkan selector and retain combined platform-filter regression. Deduplicate only identical or superseded test definitions, retaining the stronger card metadata and reserved-executor assertions. No assertions, admission limits or feature refusals are weakened. All targets of render dependencies, GPU, engine, UI, CLI and native app pass cargo check with raytrace-cpu and bundled-render-library at treec70d00d1. Native executable tests and full current-source acceptance remain pending. This is a private integration rehearsal for subsequent constituent PRs, not an aggregate official render/main merge. * test(render): retain one complete host lifetime regression set Deduplicate byte-identical DropProbe/task-lifetime tests and retain the adapted environment/texture ownership regressions with every assertion and complete memory estimate. Keep the registered-geometry admission regression once; only struct field order differed. Replace a one-element diagnostic loop with its equivalent block, preserving all wrap/width assertions. Test-only integration repair. Formatting and diff checks pass; refreshed executable validation is required. No production behavior, limits, assertions or ignores changed. * fix(doc): recognize the proven format-29 card descriptor alias Normalize only the historical format-29 physical-material-cards spelling, and only when material-engineering-cards is registered. Admission and migration de-duplication use the same identity. Unknown concepts, wrong versions and incapable readers still refuse before mutation. Six controlled-history Rust regressions and actual CLI migration/no-clobber acceptance pass. No version, released migration or CI changes. Refs #5793, #1369, #5493. * test(render): preserve grounding refusal before explicit instance moves Update the two Render binding fixtures for upstream first-occurrence grounding. Verify grounded movement refuses without changing document/history, then explicitly unground through the public command before the intended move. Retain every target, resource, copy and persistence assertion. Refs #5493. --------- Co-authored-by: Christian Svensson <blue@cmd.nu> Co-authored-by: Victor Santos Oliveira <56417388+Vittuu@users.noreply.github.com> Co-authored-by: cfaulkingham <colin.faulkingham@gmail.com>
9.4 KiB
Renderer capability and quality plan
The quality bar
The objective is a production renderer that can hold up in demanding CAD visualization and product imagery, with the control expected from a general-purpose renderer. A large library helps users begin; believable geometry, transport, optics, color and reproducibility determine the final image. Comparison with established CAD tools or Blender is an outcome to demonstrate with independent scenes and timed tasks, not a feature count or a claim made by this specification.
The 120 records in capabilities.json separate physical transport, geometry, light sources, camera, image processing, output, execution and CAD integration. A bloom slider, a new material thumbnail and a convergent glass transport model are different kinds of work and need different evidence.
Foundation before effects
| Foundation | Why it matters | Required evidence |
|---|---|---|
| Scene geometry and precision | CAD parts range from tiny gaps and wires to large assemblies. | No cracks, lost small parts or self-shadow artifacts in mixed-scale references. |
| Global light transport | Contact, indirect illumination and reflected color anchor a product. | Analytic and converged reference scenes with no unexplained ambient term. |
| Layered appearance | Paint, oxide, coatings and dirt need distinct optical roles. | Coated conductor, dielectric substrate and masked wear tests with plausible energy. |
| Physical mapping | Wood grain, brushing and print layers communicate manufacturing scale. | Stable millimeter-scale detail across body, instance and scene size changes. |
| Color pipeline | An image cannot be assessed if map decoding, exposure and display mapping are confused. | Declared working space and matching preview/export transforms. |
| Camera and framing | Perspective, focus and lens behavior establish the photographed object. | Repeatable saved shots, clear units and verified depth-of-field references. |
| Execution contract | Users need predictable results on their selected device. | The same request is preflighted and executed, with bounded memory and cancellation. |
Use a layered appearance abstraction informed by public specifications such as OpenPBR, while independently implementing behavior allowed by repository policy. The catalog does not mandate a third-party implementation or permit otherwise prohibited dependencies. The public specification describes a common surface authoring model; specialized optics and granular surface response still need their own validated treatment.
Effects and specialized features
Light transport and sources. Progressive path tracing, multiple importance sampling, adaptive sampling, explicit bounce limits, compensated termination, area/point/spot/Sun sources, importance-sampled HDR environments, sampled emissive meshes and many-light acceleration. Add IES/LDT only with documented units, orientation and normalization. Light groups can rebalance fixed linear contributions; arbitrary recoloring or linking is an identified artistic operation.
Surfaces. Dielectric and conductor Fresnel, roughness, anisotropy, independent coats, fibers, flakes, layered masks, decals and wear. A gold-colored polymer is not a conductor. Painted metal remains a dielectric outer layer until wear reveals the substrate. Oxide, dust and contamination need their own layers. Avoid a single metalness control that silently treats every surface of an aerospace assembly as metal.
Optics. Smooth/rough transmission, path-length absorption, nested media, subsurface transport and refractive caustics. LED and sample-vial shots make geometry thickness and medium ownership especially important. Later spectral dispersion, thin-film interference, polarization and measured BSDF import require dedicated reference fixtures and explicit model limits. They should not delay a robust opaque product workflow.
Geometry detail. Stable tessellation, render-only microbevel, normal/bump detail, displacement, texture filtering, instancing, terrain level of detail and contact tracks. A microbevel must not alter the engineering B-rep. Dust that changes silhouette needs geometry or a declared approximation; normal mapping cannot provide a missing contact shape.
Environment. Procedural terrestrial sky and Sun, three-dimensional stages with parallax, physical ground and optional atmosphere/weather. Keep background visibility and illumination linked by default; expose intentional decoupling. Lunar vacuum scenes exclude atmospheric effects but still need reflected illumination and geometric occlusion.
Camera and finishing. Perspective/orthographic views, depth of field, aperture shape, lens shift, calibrated backplates, motion blur and additional projections where justified. Exposure, white balance, view transforms and clipping diagnostics come before bloom, flare, vignette, distortion, chromatic aberration, grain and sharpening. Effects remain independently reversible, with an untouched linear master where supported.
Production. Raw/denoised comparison, EXR and presentation encoders, diagnostic passes, object masks, Cryptomatte or a verified interoperable equivalent, queues, variants, resumable jobs, portable packs and resource manifests. Denoising must preserve circuit traces, labels, fine machining and dust detail. An image sequence must retain consistent resources, color treatment and motion across frames.
CAD behavior. Face/body/instance scopes, engineering/appearance separation, explicit overrides, one-action undo, nondestructive staging, section/exploded presentation, shared UI/CLI/MCP commands and strict capability errors. A render library becomes trustworthy when changing an appearance cannot corrupt the design or unexpectedly change assembly mass.
Asset production
Prefer deterministic procedural construction for machining, brushing, print layers, repeated fibers, surface noise and stage geometry. Use original or properly admitted source imagery for irregular grain, reference surfaces or specialized maps. AI can accelerate concept exploration, but material maps need independent review for baked lighting, seams, map consistency, scale and unsupported physical claims.
Use a common appearance test object with a smooth region, sharp edge, bevel, curved region, thickness variation and a known-size mark. Add domain tests: flakes on a curved panel, grain around a wood joint, traces on a PCB, a light guide and LED diffuser, glass with a closed sample, and dust on a wheel. A material pack is published only when its actual resource, preview, dependencies and provenance agree.
Catalog parameters should expose meaningful manufacturing choices: brushed direction and scratch scale; print layer height and wall orientation; wood species family and grain direction; paint coat and flake density; textile weave; polymer translucency; contamination amount. Color variations belong to a parameterized family when they do not justify a separate optical model. Distinct manufacturing processes and layered structures justify distinct entries.
Reference suite
| Reference | What it isolates |
|---|---|
| Diffuse box and area emitter | Direct/indirect energy and convergence. |
| Conductor/dielectric angular strip | Fresnel, roughness and coating response. |
| Brushed cylinder and rotated instances | Tangent orientation and anisotropy. |
| Paint panel with sparse flakes | Coats, sparkle filtering and temporal stability. |
| Hollow glass vial with closed sample | Thickness, interfaces, absorption and nested media. |
| LED bar with diffuser and light guide | Source ownership, transmitted light and difficult paths. |
| PCB with labels and thin traces | Geometry precision, map decoding and denoising preservation. |
| FDM part with known layer scale | Physical mapping, silhouette and view-distance transitions. |
| Wood corner joint and coated board | Grain orientation, pores, coat and mapping continuity. |
| Aerospace foil and solar-cell assembly | Layered surfaces, repeated detail and meaningful optical limits. |
| SELENE on procedural lunar terrain | Scale, ground contact, Sun ownership, terrain and shadows. |
| Baked vial release/catch sequence | Shutter-time motion, contact continuity and frame stability. |
Each reference records scene version, resources, camera, exposure, display transform, executor and tolerance. For numeric cases compare with analytic values or independently produced reference data that passes clean-room policy. For artistic judgments use fixed-camera A/B review with raw images, annotated defects and multiple viewpoints. Do not compare screenshots taken under different tone mapping and call the difference a transport result.
Performance and success criteria
Record time to first useful preview, preparation time, time to an agreed error or perceptual threshold, peak memory, interruption latency and recovery behavior. Report hardware and scene size. Use a quality/time curve rather than a single samples-per-second figure. Set platform-specific targets after profiling the actual implementation; this document does not invent device performance.
The first release gate is a reliable product workflow and a small verified resource pack. The next gate is glass/LED/aerospace optics and consistent production output. The SELENE lunar still then becomes a demanding integrated reference. Future simulation and animation add new acceptance criteria; a beautiful still does not validate dynamics.