mirror of https://github.com/bherbruck/solidcraft.git synced 2026-11-06 20:02:16 +00:00

Files

T

selune 9e6e0b8df1 Render workspace: complete experimental ribbon, resources and effects integration (#5493 ) (#5494 )

* wip(render): reconcile completed material and image pipeline source with 0.20 (#5493)

Source-only integration reference for staged review, not a merge-ready aggregate.
Donor: 0xlillith/solidcraft@aea20b0115.
Upstream: 858e5995d6.

Retain original CPU/material contracts and explicit GPU donor provenance in
docs/render-materials-lab.md (#2067, #2191, #2780, #3306). Preserve released
format migrations and current navigation/startup/shell behavior. New saved
records use pending descriptors. The physical-card descriptor follows the
maintainer's material-engineering-cards naming request, with a legacy-lab
format-29 regression. Replace raw new panel hosts with shared containers.

Repository checks, complete workspace/all-target Clippy, and the independent
physical/resource authoring checks pass for this source. The fresh full local
CI invocation has reached test compilation and is not yet complete. Do not
transfer donor native output or prior test totals to this integration.

Generated review screenshots, video, package ZIP and machine logs remain at
the immutable personal evidence pin. Uncommitted geometric displacement is
backed up separately, not silently included. No kernel/vendor change, direct
main write, release or independent contributor-branch rewrite.

Co-authored-by: Christian Svensson <blue@cmd.nu>

* test(cli): pin the Compact camera-sample admission diagnostic (#5493)

The bounded request still refuses 1024x1024x64 samples before host initialization and writes no output. Update only the stale expected diagnostic to the existing Compact budget wording; production limits and code are unchanged. Exact-tree CLI regression suite: 14 passed, 0 failed. The full repository gate has been invoked separately and is not yet complete.

* Normalize UI container violation paths across platforms

Report repository-relative paths with forward slashes so diagnostics and the existing nested-package regression assertions agree on Windows and Unix. Keep the container detection rules unchanged.

Validation: official ui-containers gate and all seven focused xtask tests passed; rustfmt and diff checks passed. Only xtask/dependencies were compiled; no application build or heavy tests.
(cherry picked from commit 44b58d8e10)

* fix(render): preserve camera contracts and correct acceptance regressions (#5493)

Preserve Design view.apply semantics with a separate strict Render camera command. Retain existing translations when English-only aliases collide; add material-axis entries and camera-specific pitch labels. Compare complete validated engineering cards and retain job handles before cancellation.

Focused and native acceptance is pinned to tree f8a423b21f. Full CI has been invoked separately and is not claimed green. Landing follows the render integration policy in #5493.

* fix(render): resolve showcase licence and upstream resource hygiene (#5493)

Record SychPL's explicit MIT OR Apache-2.0 grant, retaining source/model bytes and the Ubuntu lettering notice. Remove 80 absent attribution rows, personal fork records, dead delivery attributes and three fork/resource-only workflows. Existing xtask assets now performs bounded offline hash checks and rejects orphan render attribution; no parallel draft CI or package installation. Original authoring reproduction remains explicit. Scoped xtask tests, assets, Clippy, formatting and prepared SELENE validation pass; no application or renderer-wide result is inferred.

* fix(render): align saved bounds and progressive sample resolution (#5493)

Address review r4364211669/r4364211677/r4364211681/r4364211691/r4364211695. Persisted light/frame domains respect the existing 1e9 document bound; related LED/rectangle/direction cases use the same bound. Workstation primary resolve shares the 4096 admission cap and film counters use checked conversions. Exact candidate: 485 CPU render tests, 21 render document tests and strict scoped Clippy pass, including positive boundary round trips and 2048/4096 end-to-end checkpoints. No released format/migration edits, relaxed test limits or full-stack acceptance claim.

* wip(render): isolate optional resources and harden sample handling (#5493)

Review work in progress: opt-in encoded render library with reproducible runtime catalog exports; native-only robust dependency through the workspace; checked bloom slices; per-sample point-light diagnostics; independent area-light spatial/film keys. Resource-module binaries in both configurations, generation, Cargo production feature graphs and attribution checks pass. Full engine/render regression and combined acceptance are pending: do not merge this donor as a constituent or treat scoped resource proof as runtime acceptance.

* fix(gpu): preserve donor allocations through the scope-safety repair (#5722)

Port the native-validated #5723 scope-cleanup correction into the experimental donor, retaining its adaptive, volume, aging, photographic and bloom allocations. Same reverse-drain helper and regression cases; the donor combination still needs its own compile/test gate and is not covered retroactively by render-base results.

* claim: #1369

* Reject unknown pending concepts after format folding (#1369)

* test(render): close bounded sampling and bloom review regressions (#5493)

Validate the optional-resource/lighting/dependency donor at its exact tree. Required Vulkan GPU 127/0/3; CPU renderer 487/0; engine Render 72/0; document render 21/0; lean library 7/0; strict scoped Clippy, assets/layers/lists/containers and lean-engine WASM pass. Preserve original failed controller/typing attempts. This is the draft donor/disposition source, not a replacement for constituent render PRs or final main acceptance.

* wip(render): preserve stable aging target validation candidate

Exact staged source from prior review work on donor 3b892eab5e. This is a recovery/review checkpoint, NOT accepted delivery. An actual command-path regression currently fails because the selected executor refuses ordered surface aging. No assertion, capability or admission limit is weakened. Native/UI/full combination acceptance remains pending. Saved/runtime split adds one pending descriptor and retains original file scope; no main/render branch is changed.

* test(render): preserve numeric setup intent at the admitted coordinate bound

Follow up jyviko review on #5494 without weakening the corrected saved-coordinate contract. The positive clicked fixture uses 1e9 instead of inadmissible 2e9; explicit out-of-range cases still refuse, and the full saved setup round-trips through JSON and the native container. Exact-source Render workspace 95/0 and strict all-target UI Clippy pass. This does not incorporate the separately failing stable-aging candidate or claim full current-render acceptance.

* test(render): use the real GPU executor for saved aging

Move successful native cold-reopen Check/Start coverage from the CPU-backed protocol fixture into the production GPU executor tests. Verify capture-index changes preserve the stable target and that enabling aging changes both PNG and raw EXR output. Retain explicit, allocation-free refusal coverage for executors without aging support. Production capabilities and admission checks are unchanged.

* fix(render): persist stable identities for targeted aging (#5493)

Separate saved RenderBodyTarget identities from captured mesh ordinals. Reject legacy ambiguous targets, resolve Check/Start after visibility changes and preserve native reopening, copies and undo. Unsupported executors still refuse; real AMD Vulkan regression completes saved aging after reordered capture.

Source tree 6b84c8ad passes document 23, engine Render 75, GPU effects 5 and Render UI 95 with no failures; scoped strict Clippy, WASM and repository gates pass. Fresh CLI/native reopen and clean/aged GPU exports pass with identical physical totals and inspected actual images. Whole current-render integration is separate.

* fix(render): reconcile combined CPU/GPU contracts on current upstream

Unify captured resources/status and CPU-vs-GPU request schemas after the real two-parent integration; remove obsolete duplicate Vulkan selector and retain combined platform-filter regression. Deduplicate only identical or superseded test definitions, retaining the stronger card metadata and reserved-executor assertions. No assertions, admission limits or feature refusals are weakened.

All targets of render dependencies, GPU, engine, UI, CLI and native app pass cargo check with raytrace-cpu and bundled-render-library at tree c70d00d1. Native executable tests and full current-source acceptance remain pending. This is a private integration rehearsal for subsequent constituent PRs, not an aggregate official render/main merge.

* test(render): retain one complete host lifetime regression set

Deduplicate byte-identical DropProbe/task-lifetime tests and retain the adapted environment/texture ownership regressions with every assertion and complete memory estimate. Keep the registered-geometry admission regression once; only struct field order differed. Replace a one-element diagnostic loop with its equivalent block, preserving all wrap/width assertions.

Test-only integration repair. Formatting and diff checks pass; refreshed executable validation is required. No production behavior, limits, assertions or ignores changed.

* fix(doc): recognize the proven format-29 card descriptor alias

Normalize only the historical format-29 physical-material-cards spelling, and only when material-engineering-cards is registered. Admission and migration de-duplication use the same identity. Unknown concepts, wrong versions and incapable readers still refuse before mutation. Six controlled-history Rust regressions and actual CLI migration/no-clobber acceptance pass. No version, released migration or CI changes. Refs #5793, #1369, #5493.

* test(render): preserve grounding refusal before explicit instance moves

Update the two Render binding fixtures for upstream first-occurrence grounding. Verify grounded movement refuses without changing document/history, then explicitly unground through the public command before the intended move. Retain every target, resource, copy and persistence assertion. Refs #5493.

---------

Co-authored-by: Christian Svensson <blue@cmd.nu>
Co-authored-by: Victor Santos Oliveira <56417388+Vittuu@users.noreply.github.com>
Co-authored-by: cfaulkingham <colin.faulkingham@gmail.com>

2026-10-24 14:21:59 +00:00

12 KiB

Raw Permalink Blame History

Render studio UI implementation batch - 2026-10-22

Owner-directed continuation of #1/#2 and draft PR #7 from ecffc20fd9bc08d250c7a1822f819f06b9103990. No upstream refresh, source-model mutation or release. Repository text is English; localization retains its own language. The owner requested coordinated implementation before expensive compilation.

Acceptance target for this batch

Deliver the native Render workspace's end-to-end user interface for the capabilities actually implemented: model/library navigation, context-owned resource browser and inspector, scene composition, appearances, lighting, environments, camera, output, preflight, progress/cancellation and exact completed-result export. Use the existing shell, tokens, shared controls and single RENDER ribbon tab. Keep all authored catalogs inspectable, with executable projections, unbound concepts and blocked advanced capabilities identified separately.

Replace the long undifferentiated inspector with local Scene, Appearance, Lighting, Environment, Camera, Output and Diagnostics sections. Keep an explicit All controls view for dense expert inspection and existing interaction regressions. Never add a global expertise or render-mode system.
Extend the existing Browser card with a local Model/Library selector, preserving both shell layouts, selection and model visibility. Preserve per-category query/page/selection; provide bounded favorites/recent collections, availability filters and source/omission details. Original source-map previews must be labelled as source maps, not measured or path-traced material thumbnails.
Add reviewed native studio compositions through shared read-only resolve / atomic apply commands. Their identities are separate from unbound SCENE-* specifications. Explicit lighting/stage replacement, revision checks and conservative product clearance are mandatory. Preserve camera, appearances, engineering assignments and geometry.
Make fixed-sample PNG projections of compatible quality specifications explicitly opt-in. Do not turn adaptive stopping, independent transmission-depth limits, raw buffers or EXR into implemented promises. Applying a sampling budget must preserve lighting, optical bindings and camera.
Complete accessible numeric camera, environment, stage and output controls; pin Check/Render/Cancel/Export outside scrolling bodies. Check and Start must use the same request. Retain completed images and exact export identities across later edits and failures.
Add bounded shot duplication/rename/removal through the engine, with conflict rejection and one undo. Switching away from a dirty draft requires Save/Discard/Keep editing; library inspection never commits a preset.
Consolidate type/lint checks, focused engine/UI tests and one native application build after the coordinated changes. Inspect actual application screenshots in both themes and both layouts with a small public-safe fixture. Do not claim interaction or visual acceptance from source-only checks.

Explicit boundaries

This UI batch does not claim adaptive sampling, a new transmission estimator, EXR/linear masters, unrestricted nested media, volumes, displacement, spectral transport, dynamics, a render queue or completed whole-project CI. Missing capabilities remain visible and cannot emit unsupported parameters. The reviewed 4K SELENE export and its renderer/model hashes remain unchanged. No new icon artwork, external assets or dependencies are required.

Execution ledger

Initial state: clean local/remote integration branch; published physical resources at 32eda023, SELENE master at cf8e6510. Local plan/ files are absent, so committed issue objectives, UX.md, UI_INTEGRATION.md and the actual source define this batch. Implementation and validation results are recorded below as they happen; this initial plan is not completion evidence.

Grouped source checkpoint

The coordinated source batch now contains the contextual inspector and existing Browser-card integration; bounded category navigation/favorites/recent inspection; original source-map previews; complete native composition resolve/apply; saved-shot lifecycle/dirty-draft consent; exact opaque appearance editing; CPU point/spot/rectangular lights; GPU sky/lighting/camera/output controls; explicit fixed-sample quality projections; and captured preflight/job diagnostics. The source catalog lookup still verifies 216 original assets without changing source bytes or readiness flags. New English/Spanish UI text uses the existing English fallback for other locales rather than unreviewed translations.

Focused regression sources cover seven inspector journeys, five engine contract groups and two browser-state groups; existing dense-control interactions explicitly select the public All controls page. No GPU/application binary has been linked for this batch yet. Initial grouped type/lint checks identified a JSON macro-expression syntax issue, the existing f32 sky contract and two strict lint findings; all are corrected in source without suppressing diagnostics. Native execution and visual acceptance remain pending.

First consolidated execution and grouped corrections

On cca1175f, strict whole-workspace/all-target Clippy passed. One grouped engine/UI test-artifact build completed, then the engine render suite ran 66 tests (64 passed, 2 failed) and the UI suite ran 67 (65 passed, 2 failed). All seven new contextual-inspector journeys and both new library-state tests passed, including native scene application through real UI controls and fixed job actions across both themes/layouts.

The failures identified one stale physical-reference fixture (SURF-013 gained references in the published 59-profile package), one incorrect test expectation for animation-only Q-009, and two legacy UI assumptions after moving the camera into its context page. The source now tests a genuinely unbound MAT-009 without manufacturing missing properties, refuses Q-008/Q-009 as animated profiles, restores camera actions to All controls, and exercises the new visible Camera navigation in the existing save/restore test. No renderer boundary or numerical assertion is weakened.

Grouped refinements also retain readable names in bounded favorites/recent collections, separate collection search from per-category queries, expose native GPU preparation/refusal in context, and expand the existing Browser when explicitly opening a category. A fail-closed SOLIDCRAFT_SETTINGS_DIR desktop profile override permits actual hardware GUI review without adopting or modifying personal settings; normal startup remains unchanged. The post-correction execution and native visual review are still pending.

Nathan shared-kit integration and native review findings

The owner's explicit request is to reuse Nathan's existing components, not introduce a competing Render design system. The implemented foundation is Nathan-Dane's merged #3627 stack (8e77d9fd): token-owned shell/cards, form rows, segmented controls, shared menu/search rows, confirmation dialogs, multi-tone SVGs and light/dark roles. Current upstream #4533/#3822/#4608 were inspected for scope, but are not silently merged into the frozen personal branch. The open corner-radius work is not treated as released behavior.

A fresh native hardware application at 3e3ef3d4 compiled and was launched under an isolated settings profile. Five actual application captures exercised light/dark and docked/floating Render pages with a public-safe three-body command-created fixture. Review identified clipped scope notices and inefficient stacked output fields. The grouped refinement reuses the kit's wrapping Note/Error text and aligned numeric rows, and the existing two-line MenuItem search rows for visible resource identity/availability. Favorites/recent inspection retain the source availability state rather than turning specifications into executable resources. Physical-reference navigation now follows the same bounded category history.

Editor-only output aspect lock uses a fixed rational anchor, checked integer arithmetic and atomic refusal when a coupled axis exceeds the selected method's hard bound. Explicit presets, orientation swaps and loaded shot dimensions reanchor the ratio; no mode, sample budget, light, camera or saved document changes merely by enabling the lock. The temporary-map adapter now forwards the reviewed physical scale and mapping plane, matching the persistent-map path instead of silently falling back to XY/unit scale.

Seven additional regression groups cover rational rounding/refusal, explicit reanchoring, actual lock/orientation controls, readable notes, bounded availability history, physical-reference navigation and exact temporary map projection/optical exclusivity. These are source checkpoints until grouped native tests and final GUI inspection complete. No adaptive estimator, EXR exporter, source-map BRDF thumbnail or full-project CI success is implied.

Full-master acceptance repair batch

The existing contextual UI at 592e0ddd had already passed grouped engine/UI/shared-kit and WASM checks. Its actual protected-profile Windows review exposed two additional acceptance blockers: the live product preview rejected the unchanged full SELENE scene at the old 128 MiB expanded-vertex cap, and a normal requested application shutdown overflowed the main-thread stack. The retained crash event is EXCEPTION_STACK_OVERFLOW; matching native symbol inspection locates the fault in geometry destruction. Those observations are not counted as a successful whole-master UI review.

This owner-directed continuation preserves Nathan-Dane/Nateaux's shared ui_kit panel/card/form/menu/icon/token resources. It does not import another upstream UI snapshot, invent new icon art or change transport sampling. The Environment page now uses the existing environment_map master. The eight contextual pages and established native resource/shot workflows remain the interface authority.

The coordinated repair implements an exact expanded-vertex admission plan, one fallible reservation per output buffer, a native 64-bit 512 MiB vertex-payload ceiling (128 MiB on restricted targets), and the existing actual-device upload chunking. Captured source triangles, appearances and visibility are not simplified. Rejected captures are cached until their identity changes or the user explicitly retries; the shared kit supplies a wrapped, theme-owned failure card readable even over an opposite-color scene background. Diagnostics reports vertex payload separately from total device/process memory.

Naming origins retain older model states, whose bodies retain older origins; default recursive Arc destruction is not bounded by the naming-computation depth limit. The document-layer repair iteratively releases uniquely owned naming ancestors and placed-copy chains while preserving shared snapshots. It does not change kernel geometry or naming semantics. Regression sources include 20,000-level small-stack ancestry/copy destruction, concurrent final owners, exact preview accounting, original source identity, hostile counts and repeated-refusal behavior.

Whole-workspace/all-target Clippy with -D warnings passes for the grouped source. Native unit execution, fresh-application full-master preview and normal shutdown acceptance are pending at this recovery checkpoint. The source is saved as WIP rather than claiming full CI or final native acceptance.

Follow-on acceptance closure

The full-master application check is now completed on the exact f8e0b07b code checkpoint: the rebuilt native app displays the unchanged full visible SELENE in light/docked and dark/floating layouts and exits normally with code 0, without process termination or preference changes. The full document suite completed 301 passes / 0 failures / 1 explicit ignore. Exact binary/source hashes and the separate new finishing/background/linear-output work are recorded in FINISHING-BATCH-2026-10-22.md. This closes the earlier unresolved preview/shutdown item; it does not make the subsequent new features accepted before their own execution gates.

12 KiB Raw Permalink Blame History