Files
Brett Lawson 230d9c837f Pin Rust 1.99.1: G2 fillets run 2-3x faster than on 1.98 (#15063)
* Claim: pin Rust 1.99.1

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEtwSrdwZxqTQp5MfnU

* Pin Rust 1.99.1 everywhere 1.98.0 was pinned

Code built by 1.98.0 (LLVM 22) runs the G2 and curvature fillet path 2-3x slower
than 1.99.1 (LLVM 23), at the ci and release profiles alike. Move both
rust-toolchain.toml files, every workflow's dtolnay/rust-toolchain step, the FreeBSD
rustup install, the web Dockerfile and the docs to 1.99.1.

Clippy 1.99 lints fixed in solidcore: explicit_iter_loop in procedural_blend/corner.rs
(loop over `&mut self.sides`), and mut_mut on set_props_stage2_mut's `&mut &mut Brep`
argument, which the generic stage needs (`FaceBrep` is implemented for `&mut Brep`
only), allowed on that method with the reason. The new pedantic assert_is_empty lint
(only in tests) joins the workspace's justified pedantic allows.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEtwSrdwZxqTQp5MfnU

* Pin Rust 1.99.1 in the FreeBSD release job main added since

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEtwSrdwZxqTQp5MfnU

* solidcore: iterate the Mixed corner's sides through the slice, so it still builds on Rust 1.85-1.98

`for s in &mut self.sides` over a `Box<[Side; 4]>` needs `IntoIterator for &mut Box<[T; N]>`,
which Rust 1.99 added; solidcore declares rust-version 1.85, and 1.98 fails with E0277.
`&mut *self.sides` iterates the array on every version and satisfies clippy's
explicit_iter_loop on 1.99.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEtwSrdwZxqTQp5MfnU

* Pin Rust 1.99.1 in the release icons job main added since

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEtwSrdwZxqTQp5MfnU

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Brett Lawson <brett@casonix.com>
2026-11-13 02:39:21 +00:00

43 lines
1.5 KiB
YAML

# Nightly import checks on real-world STEP files (#1397): the external corpus in
# tests/external-corpus.toml is downloaded (hash-verified), imported headless, and checked
# against tolerance-based expectations — body counts, total volume and area, time and memory
# budgets. It is not part of `cargo xtask ci`: it downloads from the internet.
#
# Import results should improve over time (healing, edge merging, meshing). When a check fails
# because the numbers moved for the better (or the source changed upstream), re-record with
# `cargo xtask external-corpus --bless "why"` in a pull request, never by editing numbers.
name: External corpus
on:
schedule:
- cron: '40 3 * * *'
workflow_dispatch:
inputs:
only:
description: "Run only this corpus entry name (empty = every entry)"
type: string
default: ""
permissions:
contents: read
jobs:
corpus:
name: Import the external STEP corpus
runs-on: ubuntu-24.04
timeout-minutes: 120
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
- uses: dtolnay/rust-toolchain@1.99.1
- name: Build the CLI
run: cargo build --profile ci -p solidcraft-cli
- name: Import and check every entry
env:
ONLY: ${{ inputs.only }}
run: |
if [ -z "$ONLY" ]; then
cargo run -q -p xtask -- external-corpus --cli target/ci/solidcraft-cli
else
cargo run -q -p xtask -- external-corpus --cli target/ci/solidcraft-cli --only "$ONLY"
fi