mirror of
https://github.com/bherbruck/solidcraft.git
synced 2026-11-22 00:20:58 +00:00
6cc9d44fa5
* PR checks: a kernel change that edits existing test or golden lines must say why A new "Test change check" job in pr-checks.yml fails a pull request that changes kernel source (Rust under solidcore/ or crates/smlib/, not tests or goldens) and also changes or deletes existing lines of a test file or golden expectation, unless the description has a line `Test change: <reason>`. Added tests pass, as do imports, comments, blank lines and lines that were only moved or re-indented, and the shrink-only known-failing and quarantine ledgers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test change check: count re-added lines one for one, skip block comments, treat *.test.js as tests Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
102 lines
3.9 KiB
YAML
102 lines
3.9 KiB
YAML
# Four quick checks on every pull request (CONTRIBUTING.md, "Sending a change"): no second open PR
|
|
# for an issue a lower-numbered one already closes, the "Changes a default:" line is filled in, a PR
|
|
# adding to the showcase shows a picture, and a kernel fix that changes or deletes existing test or
|
|
# golden lines says why on a "Test change:" line. None is a required status check. The logic is in scripts/pr-checks/pr-checks.js (tested in ci.yml).
|
|
name: PR checks
|
|
|
|
on:
|
|
# pull_request, never pull_request_target: nothing here checks out or runs the PR's code, and the
|
|
# token is read-only for fork PRs. Only scripts/pr-checks from the PR's own merge commit is run.
|
|
pull_request:
|
|
types: [opened, edited, synchronize, reopened, ready_for_review, labeled, unlabeled]
|
|
|
|
permissions:
|
|
contents: read
|
|
pull-requests: read
|
|
|
|
concurrency:
|
|
group: pr-checks-${{ github.event.pull_request.number }}
|
|
cancel-in-progress: true
|
|
|
|
jobs:
|
|
duplicate:
|
|
name: Duplicate PR check
|
|
runs-on: ubuntu-24.04
|
|
timeout-minutes: 5
|
|
steps:
|
|
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
|
|
with:
|
|
sparse-checkout: scripts/pr-checks
|
|
- uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0
|
|
with:
|
|
script: |
|
|
const checks = require('./scripts/pr-checks/pr-checks.js');
|
|
const r = await checks.checkDuplicate({ github, context, core });
|
|
core.info(JSON.stringify(r));
|
|
|
|
defaults:
|
|
name: Defaults line check
|
|
runs-on: ubuntu-24.04
|
|
timeout-minutes: 5
|
|
steps:
|
|
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
|
|
with:
|
|
sparse-checkout: scripts/pr-checks
|
|
- uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0
|
|
with:
|
|
script: |
|
|
const checks = require('./scripts/pr-checks/pr-checks.js');
|
|
const r = await checks.checkDefaults({ github, context, core });
|
|
core.info(JSON.stringify(r));
|
|
|
|
picture:
|
|
name: Picture check
|
|
runs-on: ubuntu-24.04
|
|
timeout-minutes: 5
|
|
steps:
|
|
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
|
|
with:
|
|
sparse-checkout: scripts/pr-checks
|
|
- uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0
|
|
with:
|
|
script: |
|
|
const checks = require('./scripts/pr-checks/pr-checks.js');
|
|
const r = await checks.checkPicture({ github, context, core });
|
|
core.info(JSON.stringify(r));
|
|
|
|
test-change:
|
|
name: Test change check
|
|
runs-on: ubuntu-24.04
|
|
timeout-minutes: 5
|
|
steps:
|
|
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
|
|
with:
|
|
sparse-checkout: scripts/pr-checks
|
|
- uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0
|
|
with:
|
|
script: |
|
|
const checks = require('./scripts/pr-checks/pr-checks.js');
|
|
const r = await checks.checkTestChange({ github, context, core });
|
|
core.info(JSON.stringify(r));
|
|
|
|
# Labelling needs write access, which a fork PR's token never has, so it is its own job and best
|
|
# effort: a fork PR just doesn't get the `changes-default` label from here.
|
|
label:
|
|
name: Label changes-default
|
|
if: github.event.pull_request.head.repo.full_name == github.repository
|
|
runs-on: ubuntu-24.04
|
|
timeout-minutes: 5
|
|
continue-on-error: true
|
|
permissions:
|
|
contents: read
|
|
pull-requests: write
|
|
steps:
|
|
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
|
|
with:
|
|
sparse-checkout: scripts/pr-checks
|
|
- uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0
|
|
with:
|
|
script: |
|
|
const checks = require('./scripts/pr-checks/pr-checks.js');
|
|
await checks.syncDefaultLabel({ github, context, core });
|