solidcore's main at c0d3cc0124, rewritten to one commit per same-author run per PR (2,800 commits, author credit kept; tree identical). Full original history: tangency-labs/solidcore archive/full-history. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> git-subtree-dir: solidcore git-subtree-mainline:44525da669git-subtree-split:c440e5f892
3.4 KiB
Vendored
intersect.point_class (SmPointClassification)
-
Review fixes (PR #21). The constructor takes an
SmZoneTol3d, already converted, and stores it as is (converting again turned-SM_USE_DEFAULTinto the system tolerance).MergeIntoObjectrunsSmVertex::SetTolerancein the reference build (SM_USE_OLDTOL); it is anUNPORTED(topology.vertex)stub. Topology kinds without their ownGetTolerance(region, faceuse, loop, loopuse, vertexuse) useSmTopology::GetTolerance(SM_ZONE_TOL_3D), and a faceuseSmTopology::IsConnectedTo(FALSE); loop, loopuse and vertexuse do overrideIsConnectedToand stay stubs. The shim now builds realSmEllipse/SmCirclecurves,SetClassObject(class, NULL)is accepted for every class, and loads may read up to the last solution parameter. -
SM_PC_POINTstores anSmPoint3d*cast toSmObject*. Upstream then calls virtualSmObjectmembers on it inComputePointParameters(SmTol::GetZoneTol3d(m_pObject)),GetGap3dwith a surface andSmTol::GetObjZoneTol3d/GetXSectTol3d(the same call),IsConnectedToandMergeIntoObject(GetType): undefined behaviour. The port treats a point like any other non-topology object (system zone tolerance, not connected, not mergeable); the shim and the runner never send those ops for a point classification. -
GetGap3d(pSurface)returnsSM_ERRas the gap value (1001.0) when the object point has no single drop point on the surface; the port does the same. Callers must not read it as a distance. -
Release-build behaviour. The reference build has no
SM_DEBUG_CODE, soSetTParam'sbSnapToIvldoes nothing andSetClassObjectaccepts any object for any class.FindObjPoint3d'sSM_CAST_PTRstill checks the kind, so a mismatched class and object givesSM_ERR_NULL_POINTER(ported as such). Scripts only pair a class with an object of its kind. -
Stand-in objects. The shim builds vertices, edges and faces without a B-rep and
SmObjectstand-ins for volumes, regions, edgeuses and "other" objects. Upstream dereferences a stand-in inFindObjPoint3d/GetGap3d(volume, edgeuse),ComputePointParameters,GetBrepandGetCurveObject(edgeuse) andMergeIntoObject(region, face, edge), so those ops are rejected at run time on both sides and dropped by the generator. A stand-in region's zone tolerance is the system one upstream (it does not answerIsKindOf(SmTopology_TYPE)); the port askstopology.shell(deferred). -
Deferred (356 of 2479 cases): the surface point solve of
ComputePointParametersandGetGap3d(surface.surface_p4256;SmSurface::EvaluateNormal, which follows it, was wired bysurface.surface_p7, PR #24) and every topology member (topology.vertex41,topology.edge27,topology.face_p221,topology.face_p45,topology.shell3,topology.edgeuse_p13). The volume branch (SmVolume::GlobalPointSolve/EvaluatePoint,surface.volume_p2) is wired (Volume::global_point_solvewith compounding,Volume::evaluate_point) but not exercised: the shim has no real volume to classify to. A found answer with an empty solution array (upstream readssSolutionArray[0]past the end) isSM_ERR. -
SmSpaceBend/SmSpaceUnbendtype queries are compared through the staticGetClassType/GetClassTypeString(an instance needs the unported bend units); theIsKindOfchains are unit-tested only.