mirror of
https://github.com/bherbruck/solidcraft.git
synced 2026-11-18 22:50:56 +00:00
916b91e8d0
solidcore's main at c0d3cc0124, rewritten to one commit per same-author run per PR (2,800 commits, author credit kept; tree identical). Full original history: tangency-labs/solidcore archive/full-history. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> git-subtree-dir: solidcore git-subtree-mainline:44525da669git-subtree-split:c440e5f892
13 lines
5.7 KiB
TOML
Vendored
13 lines
5.7 KiB
TOML
Vendored
id = "audit.recursion"
|
|
upstream = []
|
|
rust_module = "(crate-wide)"
|
|
depends_on = ["blend.fillet_corner_p2", "blend.fillet_corner_p3", "blend.hcr", "boolean.api_brep", "heal.heal_data_p3", "intersect.curve_class_p8", "intersect.surface_drop_curve", "intersect.surface_intersector_p5", "intersect.surface_silhouette", "mass.integrator", "offset.offset_executive_p2", "primitive.api_curves", "primitive.api_primitives", "query.api_queries", "query.tess", "surface.b_spline_volume_n_lib", "surface.cone_p3", "surface.srf_in_volume", "surface.surf_of_extrusion_p2", "surface.surface_point_solve_p3", "sweep.api_brep", "sweep.api_surfaces"]
|
|
soft_depends_on = []
|
|
est_lines = 0
|
|
layer = 65
|
|
tests = []
|
|
status = "green"
|
|
claimed_by = ""
|
|
claimed_at = ""
|
|
notes = "GREEN for the merged snapshot through main ed6d93d8 audited in PR #273, with every unit green or partial (final re-audits: #541 topology-solver face point classification, which does not re-enter the solver, and #572 offset face-cache solves, no new recursion; before that 21 PRs incl. #441 topology.brep_p4, #463 intersect.surface_drop_lib_p3, #244 blend.fillet_executive_p3, #280 topology.brep_p7 and #554 CrvOnSurf over any surface, whose surface child the shared walker now follows, and main's depth-aware volume transform append, moved to the shared bound; before that 18 PRs incl. #466 blend.fillet_solver_p2, #531 fillet batch, #535 topology.brep_p6 closure split and main's evaluation-copy walker, now one shared bound; before that #522, #523, #517; before that 24 more PRs incl. #208 blend.fillet_solver_p5, #211 boolean.topology_intersector_p3, #490 SurfaceKind::SurfOfExtrusion and #514 MAX_SOLVE_BRANCHES, kept alongside the depth counter; before that 22 PRs; incl. #439 blend.fillet_standard_solver_p2, #236 blend.fillet_solver_p3, #213 primitive.primitive_creation_p1, #242 blend.fillet_geom_p3, topology.brep_p3/p8, #436 SurfaceKind::Sphere/Torus and #462 per-unit plan; before that 19 PRs incl. #201 offset.offset_executive_p2, #247/#264 blend.fillet_geom_p6/p5, #329 query.brep, #222 sweep.topology_sweep, #233/#250 primitive.primitive_creation_p3/p2 and #308, which lowered read nesting to 32; earlier: re-audited after #282, #284-#287, #289, #291, #293, #298, #229 boolean.merge_p2, #239 topology.face_p4, and the 31 PRs through 7e3f324e incl. #267 blend.fillet_executive_p2, #363 topology.brep_p6, #281/#317 co-ports, #313 surface dispatch with SurfaceKind::Cone: no new unbounded recursion); the remaining open PRs (#563, #178, #270) add no units and need the same review when they land; not a standalone port/runner. Geometry ownership depth bounded at 32 (= MAX_READ_NESTING since #308) across Curve/Surface/Volume, solver traversal at MAX_SOLVE_DEPTH = 1000 tree levels (checked up front in solve_it) plus a per-call counter allowing 1001 nested calls, spatial rebuild at 1 and tessellation build re-entry rejected. Review closes ProjectedCurve::set_canonical and CompositeCurve segment-mutation bypasses. Follow-up review of 77 changed kernel files and eight newly ported units found no new unbounded recursion path. Local merged-tree tests: 1554 solidcore, 31 difftest and float-roundtrip integration passing. CI at e8520b7c passed all checks, including C++-feature clippy and difftest: 228 units, 114 passed, 114 partial, 0 failed (run 39362924279). Current selection: 236 port runners (114 green, 122 partial); new-head C++ validation in PR checks. Pre-merge 222-unit summaries matched baseline, not complete numeric reports; no standalone audit cases/deferred count. All direct dependencies are green or partial. Future ports and deferred paths need follow-up review. Native guards and wasm compile check do not measure worst-case wasm runtime stack use. Source-only delta review for PR #835 of the fillet/heal/topology wave 2ca17d8e9..f1ac1f4c1 (44 changed kernel files): no new input-driven recursion or unbounded mutual re-entry; the new session/classification/finalization stages iterate executive-owned vectors and arenas, stitch uses an explicit marked face stack, and the existing MAX_MATE_DEPTH bound and lent-context nested-edit refusal still cover the wired callers. This does not re-certify the crate, change status or measure wasm stack use; follow-ups are the smooth-sequence collector progress contract and the stage-loop no-append invariant. See plan/findings.md (audit.recursion: source review of the fillet/heal/topology wave). Re-audited after main's 92454ca6..4427b2fa7 advance (273 merged PRs, 215 kernel files, 112 recursion/loop/reader-signal files, all triaged, PR #1204): no bound changed in the range (the 64->32 nesting reductions predate it), three new recursive paths, all bounded (refine_cci_to_surfaces: MAX_REFINE_RECURSION = 5, explicit counter, single tail call; glue_with_notification_identity: one re-entry; has_seam_problem_mut <-> FaceProps::set_props_stage2_with: depth 2 because prop_stage is set to Stage2A before the seam callback, an ordering invariant with no counter); an LLVM-IR call-graph cross-check of both ends (370 -> 394 recursive SCCs; all 43 new or grown ones traced: new instantiations of existing bounds, the same healing cycle through with_editing_enabled under MAX_TARGET_UPDATE_DEPTH, writer depth + 1 at every nesting site, and nested-geometry cycles that descend owned geometry under the unchanged check_geometry_nesting sites) found no unbounded path; the three new memos (NurbMemo, BoundaryMemoEntry, CurveMemoEntry) hold geometry outside check_geometry_nesting and add a constant number of levels (argued, not tested; open question Q5), the S1 writer threads an explicit depth (check_depth -> InvalidInput past MAX_GEOMETRY_NESTING) and the S1 part reader recurses only through Curve::read_from_db's own nesting with checked file counts; see plan/findings/audit.recursion--re-audit-through-main-4427b2fa7-pr-1204.md."
|