mirror of
https://github.com/bherbruck/solidcraft.git
synced 2026-11-18 22:50:56 +00:00
916b91e8d0
solidcore's main at c0d3cc0124, rewritten to one commit per same-author run per PR (2,800 commits, author credit kept; tree identical). Full original history: tangency-labs/solidcore archive/full-history. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> git-subtree-dir: solidcore git-subtree-mainline:44525da669git-subtree-split:c440e5f892
13 lines
8.3 KiB
TOML
Vendored
13 lines
8.3 KiB
TOML
Vendored
id = "query.api_queries"
|
|
upstream = ["source/SM_API/src/SmApiQueries.cpp"]
|
|
rust_module = "query::api_queries"
|
|
depends_on = ["curve.curve_p2", "geom.extent1d", "geom.extent3d", "geom.object", "geom.solution_array", "geom.tol", "geom.vector2d", "geom.vector3d", "intersect.point_class", "intersect.topology_solver_p2", "query.brep", "query.edge", "topology.brep_p1", "topology.edge"]
|
|
soft_depends_on = ["curve.curve_p1", "geom.tools", "query.face_p1", "query.face_p2", "query.face_p3", "surface.surface_p2", "surface.surface_p5", "topology.brep_p2", "topology.edgeuse_p1", "topology.face_p2", "topology.face_p4", "topology.loopuse", "topology.shell", "topology.vertex"]
|
|
est_lines = 843
|
|
layer = 49
|
|
tests = ["SM_API_test:TestSmIntersectCurveSurface", "SM_API_test:TestSmGetClosestPoint", "SM_API_test:TestSmGetEdges", "SM_API_test:TestSmGetFaces", "SM_API_test:TestSmFindFaces", "SM_API_test:TestSmFindEdge"]
|
|
status = "green"
|
|
claimed_by = ""
|
|
claimed_at = ""
|
|
notes = "PR #1447 (fixes #1436): SmApiBrepMaterialCensus ported as query::api_queries::brep_material_census; shim/FFI op 27, kinds 14-16 (box minus inner box, two disjoint boxes, nested boxes merged), fixtures/query.api_queries/material_census.json (88 cases: boxes, sheets, wires, empty B-rep, face with hole, void-flag rewrites incl. UNSURE): 88/88 pass. PR #1328 (2026-10-27), pinned v1.0.1: PASS query.api_queries cases=1203 passed=1203 failed=0 deferred=0 with_values=1203 max_rel_err=0. The 16 previously deferred touching, interpenetrating and coincident relationship/distance cases now compare: the shared B-rep classifier's boundary solve uses its retained owner-preserving copy and existing face-aware live services, rather than an unprepared read-only adapter. Previous v1.0.1 baseline: 1187 passed, 16 deferred at `SmFace handle of a surface's face`. main CI e33985411 (2026-10-23): PARTIAL query.api_queries cases=1203 passed=988 failed=0 deferred=215 blocked_by=topology.edge(31),topology.edgeuse_p3(27),topology.face_p2(157). 27 fns; largest: SmApiBrepRelationship, SmApiSurfaceClosestPoint, SmApiFaceGetBoundaryLoops, SmApiFaceClosestPoint; entry points: SmApiBrepBoundingBox, SmApiBrepClosestPoint, SmApiBrepClosestPointAll, SmApiBrepDistance, SmApiBrepIsManifoldSolid, SmApiBrepRelationship, SmApiCurveClosestPoint, SmApiCurveClosestPointAll, SmApiEdgeBoundingBox, SmApiEdgeClassifyParameter, SmApiEdgeClosestPoint, SmApiEdgeParameterRange, SmApiEdgeTangent, SmApiFaceBoundingBox, SmApiFaceClassifyUV, SmApiFaceClosestPoint, SmApiFaceGetBoundaryLoops, SmApiFaceInternalPoint, SmApiFindEdge, SmApiFindFaces, SmApiGetClosestPoint, SmApiGetEdges, SmApiGetFaces, SmApiSurfaceClosestPoint, SmApiVertexGetPoint; 24 upstream test entry points reach this unit PORTED (PR #125): public query orchestration and structured results in query::api_queries, including the wired query.face_p2 classifier. Native SmApi* oracle on concrete lines, circles, ellipses, cubic/C0 B-splines, planes, patches, rational cylinders/spheres, analytic surfaces of revolution, boxes, vertex loops and holed faces. Difftest: 1203 cases (403 fixed + 800 fixed-seed generated), 587 pass bit-identical, 0 failed, 616 deferred: query.brep 335, query.face_p1 12, query.face_p3 45, surface.surface_point_solve_p3 61, topology.brep_p1 114, topology.brep_p2 42, topology.edgeuse_p3 7. No absolute floors; perturb detects 587/587. The 25 native null contracts are FFI tests, not synthetic Rust differential passes. Five FFI tests cover layout/constructor safety, null contracts and missing-curve guards; 396 isolated missing-curve probes finish without a crash or timeout. Two core tests cover GetPoint parameter advances and ignored ordinary evaluation failures. Face closest-point adapter builds caches after validating its face handle. Cases cover all five B-rep relationship classes, operand reversal, C0 left tangents, zero-edge loops, holes and 21 fully compared analytic seam/axis drops. Topology imports restore exact native types, upward face-use links, trim flags and ownership. Curve/B-rep solves retain SM_ZONE_TOL_3D; surface grouping uses the surface zone tolerance and caller Kernel. No incoming UNPORTED(query.api_queries) sites. Re-run after merging PR #106 (surface.surface_point_solve_p3 wired, 2026-10-15): 1203 cases, 646 pass, 557 deferred (query.brep 335, query.face_p1 12, query.face_p3 45, surface.surface_p8 2, topology.brep_p1 114, topology.brep_p2 42, topology.edgeuse_p3 7), 0 failed, max_rel_err 0. UPDATE after topology.brep_p1 (PR #145): SmBrep::GetVertices/GetEdges/GetFaces wired; the shim export now carries the B-rep's native face/edge/vertex list order and the runner imports it (SmApiGetEdges/GetFaces indices, the cause of the 14 permutation disagreements seen when wiring). Re-run 1203 cases, 731 pass (83 more than main's 648), 0 fail, 472 deferred (query.brep 335, query.face_p3 45, topology.brep_p2 42, curve.curve_p6 31: the FindEdge cases now reach geom.tools' own DropPoint stub, query.face_p1 12, topology.edgeuse_p3 7). Re-run in PR #238 (query.face_p1 wired into face_bounding_box; after merging main with #145): 1203 cases, 743 pass, 460 deferred (query.brep 335, query.face_p3 45, topology.brep_p2 42, curve.curve_p6 31, intersect.surface_drop_lib_p3 7), 0 failed. Re-run after merging query.face_p3 (PR #132: SmFace::CalculateTightBoundingBox wired, 2026-10-20): 1203 cases, 748 pass, 0 failed, 455 deferred (query.brep 335, topology.brep_p2 42, curve.curve_p6 31, intersect.surface_drop_lib_p3 28, curve.crv_on_surf 10, topology.face_p2 9), max_rel_err 0. UPDATE after topology.brep_p2 (PR #149) wired SmBrep::IsManifoldSolid: 1203 cases, 773 pass, 0 fail, 430 deferred (query.brep 335, query.face_p3 45, curve.curve_p6 31, query.face_p1 12, topology.edgeuse_p3 7), max_rel_err 0. Re-run in PR #149 (merge with main through 39ceb995, #283): 1203 cases, 785 pass, 0 fail, 418 deferred (query.brep 335, query.face_p3 45, curve.curve_p6 31, intersect.surface_drop_lib_p3 7): main's 42 topology.brep_p2 deferrals (SmBrep::IsManifoldSolid) pass. UPDATE 2026-10-23 (branch claude/edge-handles): the 110 curve.curve_p2 SmCurve::GetNaturalInterval deferrals (IdenticalSolutions in CcGlobalSolver / CpGlobalSolver on the runner's Object curve handles) resolve through the curve solvers' tree-owner ParameterDomains; most now stop at the next blocker: PARTIAL query.api_queries cases=1203 passed=988 failed=0 deferred=215 max_rel_err=0e0 with_values=988 no_values=0 vacuous=0 blocked_by=topology.edge(31),topology.edgeuse_p3(27),topology.face_p2(157). The 31 topology.edge are SmEdge::GetCurve through query::face::p2::WithMadeTrimCurves, which does not forward topology_entity (Codex-owned file). UPDATE (owning-face caches for the topology solver): closest point (ops 4-6), FindFaces and FaceClosestPoint solve on the B-rep mutably through LiveBrepObjects, whose surface context the point/face, curve/face and face/face solves now use (GlobalCurveSolve / GlobalSurfaceSolve with a context, solutions' operands resolved for IdenticalSolutions): PARTIAL query.api_queries cases=1203 passed=1066 failed=0 deferred=137 blocked_by=topology.edge(31),topology.face_p2(106). The 106 left are BrepRelationship / BrepDistance (ops 7, 8), which still run on the read-only view because the containment tests read the B-reps after the solve; with the mutable solve they compare, and 6 containment cases disagree (the target's Point3DClassify puts interior points in the void region), so they stay deferred until that is root-caused. UPDATE (BrepRelationship / BrepDistance on a live B-rep): ops 7 and 8 solve through the runner's live objects (brep_relationship_solve, then brep_relationship_classify on the B-reps). Two causes kept them from comparing: the runner cloned the second B-rep, and the shared-target point classification (BrepClassifier) fired its rays on a clone; Brep's Clone is the copy constructor, which resets every curve and surface owner, so the B-rep cache made from the clone held no curve or surface (build_trees keeps only geometry owned by its edge/face), the boundary solve found only vertex pairs and the ray fires hit nothing, so even the centre of a unit box classified into the void region. The classifier's copy is now Brep::clone_standing_for_self (exact geometry copies keeping their owners, surfaces sharing cache slots) and the runner passes the second B-rep mutably: PASS query.api_queries cases=1203 passed=1203 failed=0 deferred=0 max_rel_err=0e0 with_values=1203."
|