mirror of
https://github.com/bherbruck/solidcraft.git
synced 2026-11-22 08:30:58 +00:00
916b91e8d0
solidcore's main at c0d3cc0124, rewritten to one commit per same-author run per PR (2,800 commits, author credit kept; tree identical). Full original history: tangency-labs/solidcore archive/full-history. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> git-subtree-dir: solidcore git-subtree-mainline:44525da669git-subtree-split:c440e5f892
13 lines
6.8 KiB
TOML
Vendored
13 lines
6.8 KiB
TOML
Vendored
id = "surface.surface_p2"
|
|
upstream = ["source/SMLib/inc/SmSurface.h", "source/SMLib/src/SmSurface.cpp"]
|
|
rust_module = "surface::surface::p2"
|
|
depends_on = ["geom.a_object", "geom.assert_array", "geom.extent1d", "geom.extent2d", "geom.extent3d", "geom.geom_utility_p1", "geom.object", "geom.solution_array", "geom.tol", "geom.vector2d", "geom.vector3d"]
|
|
soft_depends_on = ["curve.curve_cache", "curve.curve_p2", "curve.curve_p3", "curve.curve_p7", "curve.curve_p8", "geom.axis2_placement", "geom.polar_box", "geom.polynomial", "geom.tree", "nurbs.b_spline_curve_n_lib", "nurbs.b_spline_curve_p1", "nurbs.b_spline_surface_n_lib_p2", "nurbs.b_spline_surface_p1", "nurbs.b_spline_surface_p2"]
|
|
est_lines = 2398
|
|
layer = 21
|
|
tests = ["SM_API_test:TestSmPrincipalDirectionPairing", "prog_test:my_test_extent3d", "prog_test:my_test_vector2d", "prog_test:my_test_surface_closest_point", "prog_test:my_test_drop_point", "prog_test:my_test_matrix"]
|
|
status = "partial"
|
|
claimed_by = ""
|
|
claimed_at = ""
|
|
notes = "[2026-11-06 (local operation): PARTIAL, 2 known mismatches: the drop traces a piece once, not again from across the seam, so two ssi_adv rev_rev curves report the gap of one trace as their deviation (within two ulps at the part scale; curves bit-identical; their results are the goldens in crates/goldens/expected/surface.surface_p2.jsonl)] Cone DropPointFast + torus GSI special cases (area 6b, 2026-10-22): the Cone arm of DropPointFast runs the inherited SmSurfOfRevolution::DropPointFast with the cone EvaluateSTEPPoint/LocalPointSolve; the torus GlobalSurfaceIntersect runs the inherited IntersectWithSphere/Cone/SurfOfRevolution with the torus ConvertUVFromNURBSToSTEP (surf_of_revolution::p3::intersect_revolved, Revolved for Torus); 16688 cases, 16676 pass, 12 deferred (intersect.surface_drop_lib_p3 11, surface.surface_p2 1), 0 failed, max_rel_err 0 (unchanged); SSI corpus rust DEFERRED 21 -> 9, parity 110/110 identical; topology.edgeuse_p1 deferred 50 -> 0. #76 kernel-aware Surface dispatch (PR #313, 2026-10-21): 16626 cases, 16616 pass, 0 failed, 10 deferred (surface.sphere 10), max_rel_err 0; before 859 pass / 10 deferred. surface.surface_p10 (PR #93): LsiGlobalSolver gained the borrowed fields `surface_cache` and `kernel` its LocalSolve reads (None from LsiGlobalSolver::new); local_solve now calls LsiGlobalSolver::local_solve_branch (surface::surface::p10). PARTIAL: difftest 869 cases (69 fixture: Surface.sms / DropCurveSurface.sms / offset_nurb.sms queries, evaluation, knots, edits, copies, SmSurfaceEval, ReadFromDB; base SmSurface() defaults; TestSmPrincipalDirectionPairing; + 800 generated), 790 pass bit-identical, 79 deferred after surface.plane_p2 wired the plane dispatch, PR #40 (surface.surface_p5 36, surface.surface_p1 31, surface.cone_p2 10, intersect.adv_surface_intersector 1, topology.trimming_tools 1; the 18 surface.surface_p7 cases moved to surface.surface_p1 with PR #24); wired UNPORTED(surface.surface_p2) in nurbs.b_spline_surface_p1 (IsKindOf), curve.curve_p2, curve.tangent_field, nurbs.b_spline_curve_n_lib, curve.iso_curve, curve.crv_on_surf (ReadFromDB, lift co-ports), nurbs.b_spline_surface_n_lib_p2 (GetDerivativeLimit co-port); geom.grid now blocked on surface.surface_cache_p1; geom.solution_array keeps 2 handle-lookup markers; 91 fns; largest: SmDerivSurfDefinition::CreateCrossSectionCurves, smsurf_EvaluateGeometric, smsurf_DropVectors, sm_CCLocalSolve; cycle back-edges (call into later units; stub or co-port): intersect.curve_class_p1(5), intersect.point_class(3), intersect.surface_intersector_p1(3), intersect.adv_surface_intersector(2), surface.cone_p1(2), surface.surface_cache_p1(2), topology.trimming_tools(2), intersect.curve_class_p2(1), intersect.curve_class_p8(1), intersect.surface_intersector_p4(1), intersect.surface_intersector_p5(1), surface.curve_bounded_surface(1), surface.offset_surface(1), surface.plane_p2(1), surface.sphere(1), surface.srf_in_volume(1), surface.surf_of_extrusion_p2(1), surface.surf_of_revolution_p3(1), surface.surface_p1(1), surface.torus(1); unit-SCC #22 (220 units); 320 upstream test entry points reach this unit intersect.surface_intersector_p5 wired (PR #82): base_global_surface_intersect runs DoIntersection, whose surface caches defer at SmSurface::CalculateContinuities (surface.surface_p6); now 869 cases, 808 pass, 61 deferred (surface.surface_p5 36, surface.surface_p4 13, surface.cone_p2 10, surface.surface_p6 1, topology.trimming_tools 1). [surface.surface_p6 wired (PR #92): 869 cases, 808 pass, 61 deferred (surface.cone_p2 10, surface.surface_p4 13, surface.surface_p5 36, surface.surface_p8 1, topology.trimming_tools 1)] Re-run with surface.surface_p5's back-edges wired (PR #50): cases=869 passed=807 failed=0 deferred=62 max_rel_err=0e0 blocked_by=intersect.adv_surface_intersector(1),surface.plane_p2(11),surface.surface_p3(36),surface.surface_p4(13),topology.trimming_tools(1). Re-run (PR #52, after merging surface_p4/#49 and surface_p5/#50): 869 cases, 844 pass, 25 deferred (surface.surface_point_solve_p3 13, surface.cone_p2 10, surface.surface_p8 1, topology.trimming_tools 1); the generator skips CreateExtendedSurface cases whose in-place N_SrfExtendByDist would be retried on half-written arrays (upstream UB-107, plan/findings.md). surface.surface_point_solve_p3 (PR #106): clone_for_evaluation preserves the owner and exact B-spline/revolution NURBS data for temporary solver evaluation instead of the upstream copy constructor knot fix-up. Re-run after merging PR #106 (surface.surface_point_solve_p3 wired, 2026-10-15): 869 cases, 857 pass, 12 deferred (surface.cone_p2 10, surface.surface_p8 1, topology.trimming_tools 1), 0 failed, max_rel_err 0. [topology.trimming_tools wired (PR #124): CreatePlaneWith3DCurves calls the ported OrderCurvesIntoLoops/FindOuterLoops; re-run after merging main with PR #106: 869 cases, 858 pass, 11 deferred (surface.cone_p2 10, surface.surface_p8 1), 0 failed, max_rel_err 0] [surface.cone_p2 wired (PR #153): Surface::copy_and_add_analytics takes the kernel; 869 cases, 859 pass, 10 deferred (surface.sphere 10), 0 failed] Wired SmAdvSurfaceIntersector::FindInteriorCurves' ComputePointValues and TraceCurve (base bodies; ComputeSingularityPoint dispatches via the advanced flag): 16688 cases, 16672 pass, 16 deferred -> 16688 cases, 16676 pass, 0 failed, 12 deferred (intersect.surface_drop_lib_p3 11, surface.surface_p2 1). GREEN (2026-10-23, PR #587): difftest PASS surface.surface_p2 cases=16688 passed=16688 failed=0 deferred=0 max_rel_err=0e0 with_values=16688 no_values=0 vacuous=0; the former 12 deferrals (intersect.surface_drop_lib_p3 11, surface.surface_p2 1) no longer occur on main 9fd1c67c5 (drop_lib_p3 ones wired by #463); local rerun and CI run 39923812958 agree. UPDATE (2026-11-04): CreateExtendedSurface's port deleted with the fitted surface extension; difftest ops extend / extend_dir removed (5 fixtures, generator arms and the in-place-retry skip, shim ops 12/13). difftest 17585 cases, all pass."
|