mirror of
https://github.com/bherbruck/solidcraft.git
synced 2026-11-15 13:10:45 +00:00
PaddleStroke
216388bab9
* claim: #9366 * Windows MSI: install before removing the old version, so Start menu pins survive updates (#9366) The MSI major upgrade removed the old version (solidcraft.exe and the Start menu shortcut) before installing the new one, and Windows drops a Start menu or taskbar pin whose target disappears. Schedule RemoveExistingProducts afterInstallExecute so both stay at their path through an update; set REINSTALLMODE=amus so a pre-release or nightly of the same X.Y.Z (same file version) still replaces solidcraft.exe; skip the folder page on an update so components keep their folder. Packaging lint checks both settings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Windows MSI: a non-advertised Start menu shortcut, so its app ID and pin survive updates (#9366) An advertised shortcut targets C:\Windows\Installer\{ProductCode}, so its Start menu app ID changes with every build and Windows drops the pin. Diagnosis by SamD98. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Windows MSI: name the Start menu shortcut SolidCraft CAD, so removing an older release keeps it (#9366) Releases before this change advertised SolidCraft.lnk, and an advertised shortcut is removed with its feature by file name. With the old product removed after the new one is installed, that removal deleted the new non-advertised SolidCraft.lnk, leaving no Start menu entry. A different file name leaves the old removal only its own file. Packaging lint checks the name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Windows MSI: use the installed app icon for Start shortcuts Keep the shortcut icon outside the per-ProductCode Windows Installer cache. Add an executable-icon authoring guard and regression coverage. Packaging-only WiX 5.0.2 and ICE50 checks pass; Start-pin persistence awaits an upgrade test. --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>