Files
solvecraft/docs/render-environment.md
selune 9e6e0b8df1 Render workspace: complete experimental ribbon, resources and effects integration (#5493) (#5494)
* wip(render): reconcile completed material and image pipeline source with 0.20 (#5493)

Source-only integration reference for staged review, not a merge-ready aggregate.
Donor: 0xlillith/solidcraft@aea20b0115.
Upstream: 858e5995d6.

Retain original CPU/material contracts and explicit GPU donor provenance in
docs/render-materials-lab.md (#2067, #2191, #2780, #3306). Preserve released
format migrations and current navigation/startup/shell behavior. New saved
records use pending descriptors. The physical-card descriptor follows the
maintainer's material-engineering-cards naming request, with a legacy-lab
format-29 regression. Replace raw new panel hosts with shared containers.

Repository checks, complete workspace/all-target Clippy, and the independent
physical/resource authoring checks pass for this source. The fresh full local
CI invocation has reached test compilation and is not yet complete. Do not
transfer donor native output or prior test totals to this integration.

Generated review screenshots, video, package ZIP and machine logs remain at
the immutable personal evidence pin. Uncommitted geometric displacement is
backed up separately, not silently included. No kernel/vendor change, direct
main write, release or independent contributor-branch rewrite.

Co-authored-by: Christian Svensson <blue@cmd.nu>

* test(cli): pin the Compact camera-sample admission diagnostic (#5493)

The bounded request still refuses 1024x1024x64 samples before host initialization and writes no output. Update only the stale expected diagnostic to the existing Compact budget wording; production limits and code are unchanged. Exact-tree CLI regression suite: 14 passed, 0 failed. The full repository gate has been invoked separately and is not yet complete.

* Normalize UI container violation paths across platforms

Report repository-relative paths with forward slashes so diagnostics and the existing nested-package regression assertions agree on Windows and Unix. Keep the container detection rules unchanged.

Validation: official ui-containers gate and all seven focused xtask tests passed; rustfmt and diff checks passed. Only xtask/dependencies were compiled; no application build or heavy tests.
(cherry picked from commit 44b58d8e10)

* fix(render): preserve camera contracts and correct acceptance regressions (#5493)

Preserve Design view.apply semantics with a separate strict Render camera command. Retain existing translations when English-only aliases collide; add material-axis entries and camera-specific pitch labels. Compare complete validated engineering cards and retain job handles before cancellation.

Focused and native acceptance is pinned to tree f8a423b21f. Full CI has been invoked separately and is not claimed green. Landing follows the render integration policy in #5493.

* fix(render): resolve showcase licence and upstream resource hygiene (#5493)

Record SychPL's explicit MIT OR Apache-2.0 grant, retaining source/model bytes and the Ubuntu lettering notice. Remove 80 absent attribution rows, personal fork records, dead delivery attributes and three fork/resource-only workflows. Existing xtask assets now performs bounded offline hash checks and rejects orphan render attribution; no parallel draft CI or package installation. Original authoring reproduction remains explicit. Scoped xtask tests, assets, Clippy, formatting and prepared SELENE validation pass; no application or renderer-wide result is inferred.

* fix(render): align saved bounds and progressive sample resolution (#5493)

Address review r4364211669/r4364211677/r4364211681/r4364211691/r4364211695. Persisted light/frame domains respect the existing 1e9 document bound; related LED/rectangle/direction cases use the same bound. Workstation primary resolve shares the 4096 admission cap and film counters use checked conversions. Exact candidate: 485 CPU render tests, 21 render document tests and strict scoped Clippy pass, including positive boundary round trips and 2048/4096 end-to-end checkpoints. No released format/migration edits, relaxed test limits or full-stack acceptance claim.

* wip(render): isolate optional resources and harden sample handling (#5493)

Review work in progress: opt-in encoded render library with reproducible runtime catalog exports; native-only robust dependency through the workspace; checked bloom slices; per-sample point-light diagnostics; independent area-light spatial/film keys. Resource-module binaries in both configurations, generation, Cargo production feature graphs and attribution checks pass. Full engine/render regression and combined acceptance are pending: do not merge this donor as a constituent or treat scoped resource proof as runtime acceptance.

* fix(gpu): preserve donor allocations through the scope-safety repair (#5722)

Port the native-validated #5723 scope-cleanup correction into the experimental donor, retaining its adaptive, volume, aging, photographic and bloom allocations. Same reverse-drain helper and regression cases; the donor combination still needs its own compile/test gate and is not covered retroactively by render-base results.

* claim: #1369

* Reject unknown pending concepts after format folding (#1369)

* test(render): close bounded sampling and bloom review regressions (#5493)

Validate the optional-resource/lighting/dependency donor at its exact tree. Required Vulkan GPU 127/0/3; CPU renderer 487/0; engine Render 72/0; document render 21/0; lean library 7/0; strict scoped Clippy, assets/layers/lists/containers and lean-engine WASM pass. Preserve original failed controller/typing attempts. This is the draft donor/disposition source, not a replacement for constituent render PRs or final main acceptance.

* wip(render): preserve stable aging target validation candidate

Exact staged source from prior review work on donor 3b892eab5e. This is a recovery/review checkpoint, NOT accepted delivery. An actual command-path regression currently fails because the selected executor refuses ordered surface aging. No assertion, capability or admission limit is weakened. Native/UI/full combination acceptance remains pending. Saved/runtime split adds one pending descriptor and retains original file scope; no main/render branch is changed.

* test(render): preserve numeric setup intent at the admitted coordinate bound

Follow up jyviko review on #5494 without weakening the corrected saved-coordinate contract. The positive clicked fixture uses 1e9 instead of inadmissible 2e9; explicit out-of-range cases still refuse, and the full saved setup round-trips through JSON and the native container. Exact-source Render workspace 95/0 and strict all-target UI Clippy pass. This does not incorporate the separately failing stable-aging candidate or claim full current-render acceptance.

* test(render): use the real GPU executor for saved aging

Move successful native cold-reopen Check/Start coverage from the CPU-backed protocol fixture into the production GPU executor tests. Verify capture-index changes preserve the stable target and that enabling aging changes both PNG and raw EXR output. Retain explicit, allocation-free refusal coverage for executors without aging support. Production capabilities and admission checks are unchanged.

* fix(render): persist stable identities for targeted aging (#5493)

Separate saved RenderBodyTarget identities from captured mesh ordinals. Reject legacy ambiguous targets, resolve Check/Start after visibility changes and preserve native reopening, copies and undo. Unsupported executors still refuse; real AMD Vulkan regression completes saved aging after reordered capture.

Source tree 6b84c8ad passes document 23, engine Render 75, GPU effects 5 and Render UI 95 with no failures; scoped strict Clippy, WASM and repository gates pass. Fresh CLI/native reopen and clean/aged GPU exports pass with identical physical totals and inspected actual images. Whole current-render integration is separate.

* fix(render): reconcile combined CPU/GPU contracts on current upstream

Unify captured resources/status and CPU-vs-GPU request schemas after the real two-parent integration; remove obsolete duplicate Vulkan selector and retain combined platform-filter regression. Deduplicate only identical or superseded test definitions, retaining the stronger card metadata and reserved-executor assertions. No assertions, admission limits or feature refusals are weakened.

All targets of render dependencies, GPU, engine, UI, CLI and native app pass cargo check with raytrace-cpu and bundled-render-library at tree c70d00d1. Native executable tests and full current-source acceptance remain pending. This is a private integration rehearsal for subsequent constituent PRs, not an aggregate official render/main merge.

* test(render): retain one complete host lifetime regression set

Deduplicate byte-identical DropProbe/task-lifetime tests and retain the adapted environment/texture ownership regressions with every assertion and complete memory estimate. Keep the registered-geometry admission regression once; only struct field order differed. Replace a one-element diagnostic loop with its equivalent block, preserving all wrap/width assertions.

Test-only integration repair. Formatting and diff checks pass; refreshed executable validation is required. No production behavior, limits, assertions or ignores changed.

* fix(doc): recognize the proven format-29 card descriptor alias

Normalize only the historical format-29 physical-material-cards spelling, and only when material-engineering-cards is registered. Admission and migration de-duplication use the same identity. Unknown concepts, wrong versions and incapable readers still refuse before mutation. Six controlled-history Rust regressions and actual CLI migration/no-clobber acceptance pass. No version, released migration or CI changes. Refs #5793, #1369, #5493.

* test(render): preserve grounding refusal before explicit instance moves

Update the two Render binding fixtures for upstream first-occurrence grounding. Verify grounded movement refuses without changing document/history, then explicitly unground through the public command before the intended move. Retain every target, resource, copy and persistence assertion. Refs #5493.

---------

Co-authored-by: Christian Svensson <blue@cmd.nu>
Co-authored-by: Victor Santos Oliveira <56417388+Vittuu@users.noreply.github.com>
Co-authored-by: cfaulkingham <colin.faulkingham@gmail.com>
2026-10-24 14:21:59 +00:00

6.0 KiB

Runtime sun and environment lighting

These runtime controls extend progressive image jobs without changing the saved design or viewport lighting. Numerical sky/studio options and embedded HDR can also be saved in a typed setup; see saved HDR resources for atomic capture, byte ownership and reopening without the original file.

An original artistic sky is available without downloading an image:

{
  "progressive": true,
  "samples": 256,
  "max_depth": 8,
  "environment": {
    "kind": "sky",
    "gradient": {"zenith": [0.16, 0.32, 0.7], "horizon": [0.8, 0.9, 1.0], "ground": [0.12, 0.1, 0.08]},
    "intensity": 1,
    "rotation_rad": 0
  },
  "lighting": {
    "sun": {"direction": [-0.4, -0.6, 0.7], "angular_radius_rad": 0.02, "radiance": [1000, 950, 850]}
  },
  "tone_map": "aces_fitted"
}

The gradient is an original horizon-to-zenith/ground interpolation, sampled to 512x256. It is an artistic environment, not a calibrated atmospheric model. Sun direction points toward the light. Its finite angular disk has uniform linear RGB radiance and supports radii 0.001..pi/2 radians. Increasing radius at fixed radiance increases total illumination; the cone's solid angle is 4*pi*sin(radius/2)^2. The sun is a separate additive emitter, so a sun already present in an HDR image is not automatically removed.

For a captured Radiance HDR file, replace the environment object with:

{"kind": "hdr", "path": "original-studio.hdr", "assume_linear_srgb": true, "rotation_rad": 0.3, "intensity": 1}

Input is bounded to 16 MiB encoded, 2048x1024, 2:1 equirectangular and the standard -Y +X orientation. Header exposure and channel corrections are applied by the existing decoder. Declared primaries must be sRGB/D65. A source without primaries requires explicit assume_linear_srgb: true; this is an interpretation choice, not colour conversion. Other declared primaries are rejected even when that flag is set. No HDR values are tone mapped before lighting. Intensity is 0..100 and rotation is a finite bounded angle in radians about Z.

Equirectangular +Z is the north pole, -Z the south pole. Column zero begins at +X; columns run toward +Y. Positive rotation turns the image about +Z. Horizontal coordinates wrap; polar rows do not repeat. Map radiance replaces the constant lighting.environment when a map is supplied. Rectangle and sun emitters remain additive. The camera backplate remains the request's background; environment radiance appears through surface lighting, reflections and refractions.

The CLI accepts --progressive --environment FILE.json; that small JSON file contains the environment object above. --lighting FILE.json supplies the sun and/or rectangle lighting object. The engine captures bounded file bytes through its scoped VFS. Queued jobs own immutable shared bytes and never reopen paths. Preflight reports source SHA-256, dimensions and colour policy. A file request's optional expected_sha256 rejects a changed source on both Check and Start. Without that guard, each Start captures the current file. Runtime {kind:"embedded_hdr",resource:<saved SHA-256>,rotation_rad,intensity,assume_linear_srgb} instead uses the document's immutable bytes and does not read a path.

Sampling and bounded preparation

The worker uses the existing cooperative HDR decoder, then builds an alias table from luminance times exact texel solid angle. A row's solid angle per texel is (2*pi/width)*(cos(theta_top)-cos(theta_bottom)), evaluated with a stable sine identity near the poles. Within a selected texel, azimuth and cosine of polar angle are sampled uniformly. The directional density is texel probability divided by solid angle. Radiance uses the same piecewise-constant texel mapping. A black image uses a uniform distribution with zero emitted radiance. Independent random variates select the alias bucket and coin; sharing one 24-bit variate would bias large maps.

The sun samples its cone uniformly. Environment and sun are sampled separately, and each escaped BSDF ray receives each emitter's radiance with its own matching power-heuristic weight. The existing opaque-branch, delta-event and final-bounce rules apply. Thin-sheet branch densities multiply the competing BSDF density; connections that exhaust the remaining depth use NEE only. Enabled straight solid-shadow connections also use NEE only, with their transmitted emitter hits suppressed to avoid double counting, as described in render-glass-shadows.md. This extends the original estimator from PBRT fourth edition, sections 12.5 and 13.4; no PBRT source or images are copied.

GPU storage uses one additional binding, 32 bytes per texel plus a 16-byte header. Admission conservatively adds retained encoded-buffer capacity, 160 bytes per texel and 64 KiB to the job's existing estimate for decoded/table/work/staging/device buffers. Device binding limits and the existing 512 MiB job limit also apply. Preparation checks cancellation while decoding, generating rows, building tables and staging uploads. CPU image methods reject this progressive GPU environment contract explicitly. CPU ray tracing keeps its separate captured HDR input and sampling contract, documented in render-environment-sampling.md.

Tests use original in-memory RGBE fixtures and the generated gradient. They cover colour policy, malformed inputs, cancellation, polar/seam lookup, PDF normalization, unequal-mass sampling frequencies, resource admission, furnace consistency, sun cone quadrature and immutable engine preflight. No third-party HDRI or material assets are bundled. Original fixture generators live in examples/studio/textures; planar runtime colour/normal mapping is described in render-runtime-textures.md.

The showcase PNG maps and RGBE gradient are generated locally before replay with python examples/studio/author_showcase.py. Image outputs are ignored and are not committed source assets; the recipes, generators and provenance remain editable.