mirror of
https://github.com/bherbruck/solidcraft.git
synced 2026-11-16 13:40:58 +00:00
0c9ae27fca
Rename the shortcut back from "SolidCraft CAD" and remove a leftover "SolidCraft CAD.lnk" on install or upgrade so 0.42 installs do not end up with two entries. The packaging lint pins the new name. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
79 lines
5.5 KiB
YAML
79 lines
5.5 KiB
YAML
# Quick static checks for the release pipeline (seconds, no Rust build): workflow syntax, the
|
|
# packaging shell and PowerShell scripts, and the Linux desktop/AppStream/Flatpak metadata.
|
|
# Adapted from PhotoCraft's (storytold/photocraft, Apache-2.0; see ATTRIBUTION.md).
|
|
name: Packaging lint
|
|
|
|
on:
|
|
push:
|
|
branches: [main]
|
|
paths: [".github/workflows/**", "packaging/**", "assets/**"]
|
|
pull_request:
|
|
paths: [".github/workflows/**", "packaging/**", "assets/platforms/**"]
|
|
workflow_dispatch:
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
concurrency:
|
|
# A re-run (attempt 2 or later, often of an older commit) gets a group of its own, so it never cancels the live run for the PR's current head.
|
|
group: packaging-lint-${{ github.ref }}${{ github.run_attempt > 1 && format('-rerun-{0}', github.run_id) || '' }}
|
|
cancel-in-progress: true
|
|
|
|
jobs:
|
|
lint:
|
|
runs-on: blacksmith-2vcpu-ubuntu-2404
|
|
env:
|
|
ACTIONLINT_VERSION: 1.7.12
|
|
steps:
|
|
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
|
|
- name: Install tools
|
|
run: |
|
|
sudo apt-get update
|
|
sudo apt-get install -y --no-install-recommends shellcheck desktop-file-utils appstream libxml2-utils python3-yaml jq
|
|
curl -fsSL "https://github.com/rhysd/actionlint/releases/download/v${ACTIONLINT_VERSION}/actionlint_${ACTIONLINT_VERSION}_linux_amd64.tar.gz" \
|
|
| tar -xz -C "$RUNNER_TEMP" actionlint
|
|
- name: actionlint
|
|
run: '"$RUNNER_TEMP/actionlint" -color'
|
|
- name: shellcheck
|
|
run: shellcheck packaging/*.sh packaging/*/*.sh packaging/linux/AppRun
|
|
- name: Nightly release selection regression
|
|
run: python3 packaging/tests/nightly_test.py
|
|
- name: Windows executable icon validation regression
|
|
run: python3 packaging/tests/windows_icon_test.py
|
|
- name: AppImage CLI wrapper regression
|
|
run: python3 packaging/tests/apprun_test.py
|
|
- name: Flatpak desktop smoke validation regression
|
|
run: python3 packaging/tests/flatpak_test.py
|
|
- name: PowerShell
|
|
shell: pwsh
|
|
run: |
|
|
foreach ($f in Get-ChildItem packaging/windows/*.ps1) {
|
|
$errors = $null
|
|
[System.Management.Automation.Language.Parser]::ParseFile($f.FullName, [ref]$null, [ref]$errors) | Out-Null
|
|
if ($errors) { $errors | ForEach-Object { Write-Output "::error file=$($f.Name)::$_" }; exit 1 }
|
|
Write-Output "ok $($f.Name)"
|
|
}
|
|
- name: XML, desktop entry, AppStream, Flatpak manifest
|
|
run: |
|
|
xmllint --noout assets/platforms/windows/solidcraft.wxs assets/platforms/windows/solidcraft.en-us.wxl assets/platforms/macos/*.plist* assets/platforms/linux/*.xml*
|
|
# An MSI update installs before it removes the old version, so Start menu pins survive (#9366).
|
|
grep -q 'Schedule="afterInstallExecute"' assets/platforms/windows/solidcraft.wxs
|
|
grep -q 'Id="REINSTALLMODE" Value="amus"' assets/platforms/windows/solidcraft.wxs
|
|
# No advertised shortcuts: their Start menu app ID follows the ProductCode, which changes every build, so pins are dropped on update (#9366).
|
|
! grep -q 'Advertise="yes"' assets/platforms/windows/solidcraft.wxs || { echo '::error file=assets/platforms/windows/solidcraft.wxs::Advertise="yes": an advertised shortcut loses its Start menu pin on every update; use Advertise="no" (#9366)'; exit 1; }
|
|
# The Start menu shortcut is named "SolidCraft"; a leftover "SolidCraft CAD.lnk" from 0.42 is removed on install. Upgrading straight from 0.30.1 or older can lose the entry until a repair: accepted.
|
|
grep -q 'Id="StartMenuShortcut" Directory="ProgramMenuFolder" Name="SolidCraft"' assets/platforms/windows/solidcraft.wxs || { echo '::error file=assets/platforms/windows/solidcraft.wxs::the Start menu shortcut must stay Name="SolidCraft"'; exit 1; }
|
|
grep -q 'RemoveFile Id="RemoveStartMenuShortcutCad".*Name="SolidCraft CAD.lnk"' assets/platforms/windows/solidcraft.wxs
|
|
desktop-file-validate assets/platforms/linux/io.tangencylabs.solidcraft.desktop
|
|
# The window's X11 class is its app id; the old ids stay only as the rename shims.
|
|
grep -qx 'StartupWMClass=io.tangencylabs.solidcraft' assets/platforms/linux/io.tangencylabs.solidcraft.desktop
|
|
grep -q '<id>ai.storyteller.solidcraft</id>' assets/platforms/linux/io.tangencylabs.solidcraft.metainfo.xml.in
|
|
grep -q '<id>ai.storyteller.solvecraft</id>' assets/platforms/linux/io.tangencylabs.solidcraft.metainfo.xml.in
|
|
grep -qx 'X-Flatpak-RenamedFrom=ai.storyteller.solidcraft.desktop;ai.storyteller.solvecraft.desktop;' assets/platforms/linux/io.tangencylabs.solidcraft.desktop
|
|
grep -qF -e '--end-of-life-rebase=' packaging/flatpak-site.sh
|
|
sed -e 's/@VERSION@/0.0.0/' -e 's/@DATE@/2026-01-01/' assets/platforms/linux/io.tangencylabs.solidcraft.metainfo.xml.in >"$RUNNER_TEMP/io.tangencylabs.solidcraft.metainfo.xml"
|
|
appstreamcli validate --no-net --explain "$RUNNER_TEMP/io.tangencylabs.solidcraft.metainfo.xml"
|
|
python3 -c "import yaml; m = yaml.safe_load(open('packaging/linux/flatpak/io.tangencylabs.solidcraft.bundle.yml')); assert m['id'] == 'io.tangencylabs.solidcraft' and m['command'] == 'solidcraft'"
|
|
python3 -c "import yaml; m = yaml.safe_load(open('packaging/linux/snap/snapcraft.yaml')); assert m['name'] == 'solidcraft' and m['confinement'] == 'strict' and m['apps']['solidcraft']['command'] == 'usr/bin/solidcraft'"
|
|
python3 -m py_compile packaging/linux/snap-smoke.py
|