mirror of https://github.com/bherbruck/solidcraft.git synced 2026-11-06 20:02:16 +00:00

Files

T

selune 9e6e0b8df1 Render workspace: complete experimental ribbon, resources and effects integration (#5493 ) (#5494 )

* wip(render): reconcile completed material and image pipeline source with 0.20 (#5493)

Source-only integration reference for staged review, not a merge-ready aggregate.
Donor: 0xlillith/solidcraft@aea20b0115.
Upstream: 858e5995d6.

Retain original CPU/material contracts and explicit GPU donor provenance in
docs/render-materials-lab.md (#2067, #2191, #2780, #3306). Preserve released
format migrations and current navigation/startup/shell behavior. New saved
records use pending descriptors. The physical-card descriptor follows the
maintainer's material-engineering-cards naming request, with a legacy-lab
format-29 regression. Replace raw new panel hosts with shared containers.

Repository checks, complete workspace/all-target Clippy, and the independent
physical/resource authoring checks pass for this source. The fresh full local
CI invocation has reached test compilation and is not yet complete. Do not
transfer donor native output or prior test totals to this integration.

Generated review screenshots, video, package ZIP and machine logs remain at
the immutable personal evidence pin. Uncommitted geometric displacement is
backed up separately, not silently included. No kernel/vendor change, direct
main write, release or independent contributor-branch rewrite.

Co-authored-by: Christian Svensson <blue@cmd.nu>

* test(cli): pin the Compact camera-sample admission diagnostic (#5493)

The bounded request still refuses 1024x1024x64 samples before host initialization and writes no output. Update only the stale expected diagnostic to the existing Compact budget wording; production limits and code are unchanged. Exact-tree CLI regression suite: 14 passed, 0 failed. The full repository gate has been invoked separately and is not yet complete.

* Normalize UI container violation paths across platforms

Report repository-relative paths with forward slashes so diagnostics and the existing nested-package regression assertions agree on Windows and Unix. Keep the container detection rules unchanged.

Validation: official ui-containers gate and all seven focused xtask tests passed; rustfmt and diff checks passed. Only xtask/dependencies were compiled; no application build or heavy tests.
(cherry picked from commit 44b58d8e10)

* fix(render): preserve camera contracts and correct acceptance regressions (#5493)

Preserve Design view.apply semantics with a separate strict Render camera command. Retain existing translations when English-only aliases collide; add material-axis entries and camera-specific pitch labels. Compare complete validated engineering cards and retain job handles before cancellation.

Focused and native acceptance is pinned to tree f8a423b21f. Full CI has been invoked separately and is not claimed green. Landing follows the render integration policy in #5493.

* fix(render): resolve showcase licence and upstream resource hygiene (#5493)

Record SychPL's explicit MIT OR Apache-2.0 grant, retaining source/model bytes and the Ubuntu lettering notice. Remove 80 absent attribution rows, personal fork records, dead delivery attributes and three fork/resource-only workflows. Existing xtask assets now performs bounded offline hash checks and rejects orphan render attribution; no parallel draft CI or package installation. Original authoring reproduction remains explicit. Scoped xtask tests, assets, Clippy, formatting and prepared SELENE validation pass; no application or renderer-wide result is inferred.

* fix(render): align saved bounds and progressive sample resolution (#5493)

Address review r4364211669/r4364211677/r4364211681/r4364211691/r4364211695. Persisted light/frame domains respect the existing 1e9 document bound; related LED/rectangle/direction cases use the same bound. Workstation primary resolve shares the 4096 admission cap and film counters use checked conversions. Exact candidate: 485 CPU render tests, 21 render document tests and strict scoped Clippy pass, including positive boundary round trips and 2048/4096 end-to-end checkpoints. No released format/migration edits, relaxed test limits or full-stack acceptance claim.

* wip(render): isolate optional resources and harden sample handling (#5493)

Review work in progress: opt-in encoded render library with reproducible runtime catalog exports; native-only robust dependency through the workspace; checked bloom slices; per-sample point-light diagnostics; independent area-light spatial/film keys. Resource-module binaries in both configurations, generation, Cargo production feature graphs and attribution checks pass. Full engine/render regression and combined acceptance are pending: do not merge this donor as a constituent or treat scoped resource proof as runtime acceptance.

* fix(gpu): preserve donor allocations through the scope-safety repair (#5722)

Port the native-validated #5723 scope-cleanup correction into the experimental donor, retaining its adaptive, volume, aging, photographic and bloom allocations. Same reverse-drain helper and regression cases; the donor combination still needs its own compile/test gate and is not covered retroactively by render-base results.

* claim: #1369

* Reject unknown pending concepts after format folding (#1369)

* test(render): close bounded sampling and bloom review regressions (#5493)

Validate the optional-resource/lighting/dependency donor at its exact tree. Required Vulkan GPU 127/0/3; CPU renderer 487/0; engine Render 72/0; document render 21/0; lean library 7/0; strict scoped Clippy, assets/layers/lists/containers and lean-engine WASM pass. Preserve original failed controller/typing attempts. This is the draft donor/disposition source, not a replacement for constituent render PRs or final main acceptance.

* wip(render): preserve stable aging target validation candidate

Exact staged source from prior review work on donor 3b892eab5e. This is a recovery/review checkpoint, NOT accepted delivery. An actual command-path regression currently fails because the selected executor refuses ordered surface aging. No assertion, capability or admission limit is weakened. Native/UI/full combination acceptance remains pending. Saved/runtime split adds one pending descriptor and retains original file scope; no main/render branch is changed.

* test(render): preserve numeric setup intent at the admitted coordinate bound

Follow up jyviko review on #5494 without weakening the corrected saved-coordinate contract. The positive clicked fixture uses 1e9 instead of inadmissible 2e9; explicit out-of-range cases still refuse, and the full saved setup round-trips through JSON and the native container. Exact-source Render workspace 95/0 and strict all-target UI Clippy pass. This does not incorporate the separately failing stable-aging candidate or claim full current-render acceptance.

* test(render): use the real GPU executor for saved aging

Move successful native cold-reopen Check/Start coverage from the CPU-backed protocol fixture into the production GPU executor tests. Verify capture-index changes preserve the stable target and that enabling aging changes both PNG and raw EXR output. Retain explicit, allocation-free refusal coverage for executors without aging support. Production capabilities and admission checks are unchanged.

* fix(render): persist stable identities for targeted aging (#5493)

Separate saved RenderBodyTarget identities from captured mesh ordinals. Reject legacy ambiguous targets, resolve Check/Start after visibility changes and preserve native reopening, copies and undo. Unsupported executors still refuse; real AMD Vulkan regression completes saved aging after reordered capture.

Source tree 6b84c8ad passes document 23, engine Render 75, GPU effects 5 and Render UI 95 with no failures; scoped strict Clippy, WASM and repository gates pass. Fresh CLI/native reopen and clean/aged GPU exports pass with identical physical totals and inspected actual images. Whole current-render integration is separate.

* fix(render): reconcile combined CPU/GPU contracts on current upstream

Unify captured resources/status and CPU-vs-GPU request schemas after the real two-parent integration; remove obsolete duplicate Vulkan selector and retain combined platform-filter regression. Deduplicate only identical or superseded test definitions, retaining the stronger card metadata and reserved-executor assertions. No assertions, admission limits or feature refusals are weakened.

All targets of render dependencies, GPU, engine, UI, CLI and native app pass cargo check with raytrace-cpu and bundled-render-library at tree c70d00d1. Native executable tests and full current-source acceptance remain pending. This is a private integration rehearsal for subsequent constituent PRs, not an aggregate official render/main merge.

* test(render): retain one complete host lifetime regression set

Deduplicate byte-identical DropProbe/task-lifetime tests and retain the adapted environment/texture ownership regressions with every assertion and complete memory estimate. Keep the registered-geometry admission regression once; only struct field order differed. Replace a one-element diagnostic loop with its equivalent block, preserving all wrap/width assertions.

Test-only integration repair. Formatting and diff checks pass; refreshed executable validation is required. No production behavior, limits, assertions or ignores changed.

* fix(doc): recognize the proven format-29 card descriptor alias

Normalize only the historical format-29 physical-material-cards spelling, and only when material-engineering-cards is registered. Admission and migration de-duplication use the same identity. Unknown concepts, wrong versions and incapable readers still refuse before mutation. Six controlled-history Rust regressions and actual CLI migration/no-clobber acceptance pass. No version, released migration or CI changes. Refs #5793, #1369, #5493.

* test(render): preserve grounding refusal before explicit instance moves

Update the two Render binding fixtures for upstream first-occurrence grounding. Verify grounded movement refuses without changing document/history, then explicitly unground through the public command before the intended move. Retain every target, resource, copy and persistence assertion. Refs #5493.

---------

Co-authored-by: Christian Svensson <blue@cmd.nu>
Co-authored-by: Victor Santos Oliveira <56417388+Vittuu@users.noreply.github.com>
Co-authored-by: cfaulkingham <colin.faulkingham@gmail.com>

2026-10-24 14:21:59 +00:00

8.7 KiB

Raw Permalink Blame History

Starter resource validation

Date: 2026-10-21. Parent catalog checkpoint: 10ada1b45a4eb285ce752ac72f9aaa968ff8b5c4.

This record covers authoring inputs, numerical invariants, format decoding and reproduction. It does not claim a rendered SolidCraft scene or application-ready library. The independent renderer implementation remains a separate delivery.

Submitted payload

Collection	Result
Surface recipes	48 original resources, with 240 PNG maps at 512 × 512
Surface exports	23,879,602 bytes, including 16-bit authoring height
Environment recipes	24 original illumination-only resources
Environment exports	24 RGBE HDR inputs at 1024 × 512; 2,568,767 bytes
HDR dynamic range	22 fields exceed unit radiance; maximum decoded channel 66.5
HDR comparison fields	One exact unit-uniform field and one exact black-vacuum field
Lighting recipes	24 records, 38 calibrated area sources, one finite-angular Sun and eight passive cards
Lighting availability	19 numerical/unbound; three calibration-blocked; two require an existing Sun

Authoring was checked on Linux with Python 3.12.14 and on Windows/Pegasus with Python 3.14.7. Both used NumPy 2.3.5 and Pillow 12.3.0. The submitted PNG encoding is the Windows output. These are authoring tools, not application dependencies. The source and export manifests contain exact SHA-256 receipts. The optional independent HDR comparison executes the installed FFmpeg program without reading or shipping its source.

Checks completed

53 focused checks passed: 21 surface, 13 environment and 19 lighting tests.
All 240 PNG exports decoded and reproduced with identical pixel arrays. Hashes, dimensions, channel depths, color/data roles, paths, positive normal hemisphere and height/normal physical-scale agreement were checked.
All 240 PNG pixel hashes matched between Linux and Windows. Compressed bytes matched for 112 maps; the other 128 differ only in encoding. The Linux encoding occupied 23,993,945 bytes, versus the submitted 23,879,602 bytes. PNG file receipts identify the submitted bytes; decoded-pixel receipts are the cross-platform reproduction authority.
Surface boundary comparisons passed for all admitted patterns. Analytic tests cover both tangent axes, derivative magnitude, scale changes, multiple image resolutions, sRGB anchors, zero-height normals and full 16-bit PNG preservation.
Both plain weave and the separate 2/2 twill pattern were checked for their actual periodic crossing sequence. Wrong cycle parity is rejected.
All 24 HDR files regenerated byte-for-byte and passed strict full-stream decoding. All decoded pixels exactly matched the separate FFmpeg floating-point RGBE decoder. The largest absolute quantization error was 0.46539607; each error also satisfied its own shared-exponent quantization-step bound.
All 24 HDR file hashes also matched across Linux and Windows.
HDR analytic checks cover cardinal orientation, exact latitude solid angle, pole/seam continuity, uniform-field E = pi L, unit directions and black vacuum.
Lighting data regenerated byte-for-byte and matched across Linux and Windows. The worst higher-order area-quadrature difference was 0.01749%, below the declared 0.15% convergence threshold. This is convergence evidence, not a rigorous mathematical error bound.
Independent lighting checks cover six projected disks, a closed-form directional sphere response, inverse-square far field, area/range cancellation under uniform scene scaling, one-sided emission, solar-disk integration, EV ratios, colored emitters and passive cards. Source-color luminance is counted exactly once.
Hostile data cases include duplicate JSON keys/IDs, nonfinite values, booleans, very large integers, unknown fields, malformed types, unsafe paths, oversized inputs, corrupted PNG/HDR streams, false semantic metadata and stale receipts.
Original catalog validator: 0 errors, 0 warnings. Prepared SELENE validator: 0 errors, with awaiting_native_source and runtime_ready: false preserved.
Exact asset attribution and whitespace are checked with the pack validator and the repository checks. No review media, bytecode, cache or native model is part of the resource collection.

The unlit material sheet, HDR field sheet and numerical Lambert-sphere sheet were inspected from ignored target/render-starter-review/. These are diagnostic visualizations, not SolidCraft renderer output. The wood, cork and regolith resources remain visibly procedural approximations; no photorealism or calibrated species/location identification is inferred from those images.

Issues found and corrected during review

Independent review corrected periodic weave admission, separate twill semantics, invalid object/type handling, false map metadata acceptance, seam-evidence checks, oversized integer conversion and a colored-light test that counted color twice. The submitted tests retain coverage of those cases. All 53 checks also passed in the separate Windows environment.

Windows Git was observed converting hashed text sources to CRLF. Scoped .gitattributes now fixes LF for the render authoring sources and catalog data, and explicitly treats PNG/HDR as binary. JSON writers emit canonical UTF-8/LF bytes. No global Git setting or other worktree was changed.

Eight convergence-diagnostic values differed between Linux and Windows by at most 1.01e-15. Their export now reports 12 decimal places, while convergence acceptance continues to use the unrounded result. A threshold-boundary regression checks that reporting precision cannot let a failing calibration pass. Source gains and transforms retain their existing precision.

Two LED/aperture recipes place their source inside/intersecting the opaque 0.25B calibration sphere. STU-018 and STU-019 therefore retain null unresolved gains and an explicit requirement for an aperture/diffuser fixture. STU-024 retains its dependency on the actual existing Sun's response. The generator does not assign invented numbers to make these records look ready.

Repository and runtime gates

Additional Pegasus verification on 2026-10-22 used a separate Windows worktree based on the frozen catalog commit, without changing the renderer implementation or other branches:

53/53 focused Python authoring tests passed again, along with the combined manifest/PNG/HDR/lighting pack validator. The lighting numerical export hash remained 52cac74c3b9ca2d66f0c36734336f498a4b8992d203d3305a9113a7753956617.
The repository attribution checker reported 725 attributed assets; Rust formatting and the targeted icon standards were also checked on Pegasus.
The first cargo xtask ci attempt reached and passed workspace Clippy, WASM checking and many test groups. The icon audit did fail on Windows because the existing requested_icons.txt had been checked out as CRLF whereas the runtime snapshot compared the canonical LF bytes. The entries were identical after line-ending normalization; no artwork or assignments changed.
Added a path-scoped policy in the root .gitattributes to pin the existing icon manifest to LF, restored its exact Git blob, and reran the failing requested_menu_icons_have_artwork_and_match_manifest test: PASS (1/1). The policy is recorded in root attribution and kept outside the closed icon-artwork directory, as required by cargo xtask icons. The complete aggregate cargo xtask ci has not been rerun after that fix; this draft must not be represented as having an end-to-end green repository CI.
FFmpeg was unavailable on Pegasus, so independent HDR decoding was not repeated on Windows. The separate original Linux independent-decoder and reproduction checks are the evidence for that claim.

These resource-specific tests are not automatically invoked by cargo xtask ci. Both the portable authoring suite and the full repository gate are required before a production merge.

Still required for an application release:

Full repository gates on the integrated tree, including exact attribution.
Typed resource binding to the actual renderer revision and its memory budget.
Native CPU/GPU reference renders, common-exposure comparisons, normal handedness and filtering evidence, durable resource ownership and save/reopen checks.
Reviewed near-field LED calibration and existing-Sun binding for blocked rigs.
Actual scene geometry for environments that need parallax or terrain.
Explicit supported optical/layered material variants and their acceptance tests.
Improved SELENE native-source admission before any complete rover demonstration.

The authoring slice can be reviewed and reproduced now. Runtime availability remains false throughout the manifests.

8.7 KiB Raw Permalink Blame History Unescape Escape