mirror of
https://github.com/bherbruck/solidcraft.git
synced 2026-11-16 05:31:02 +00:00
5af8cbe387
* Work in progress on #17197 * Boundary surface: a curve refused for a sharp corner names the corner and how sharply it turns A boundary curve chained from sketch curves that meet at a sharp corner can't be fitted by the smooth spline the surface is built from, so the surface is refused. The refusal named only the curve and its fit error. It now also says where the curve's pieces meet with the largest change of direction and by how much they turn there, measured on the exact segment tangents, so the corner can be found and rounded or the curve split into two sides. * Network surface: measure a joint's turn in solidcore, not the kernel boundary The refusal message's turn angle was computed in crates/kernel with a determinant, dot product and atan2. It now comes from solidcore's Vec2::angle_between through a small solidcore-ops primitive (joint_turn), with a unit test there; the kernel only adapts the chain's tangents. * Network surface: the joint turn is computed in solidcore, ops only forwards solidcore-ops may not call the kernel's vector methods (docs/layers.md section 4), which failed its clippy check. The angle between a joint's two directions now lives in solidcore::query::edge_turn::joint_turn, with its unit tests in tests/tangent_edge.rs; solidcore_ops::joint_turn::joint_turn only forwards to it and keeps its Error::Argument. * Network surface tests: use the imported angle constants