mirror of https://github.com/bherbruck/solidcraft.git synced 2026-11-03 10:35:58 +00:00

Files

T

selune 9e6e0b8df1 Render workspace: complete experimental ribbon, resources and effects integration (#5493 ) (#5494 )

* wip(render): reconcile completed material and image pipeline source with 0.20 (#5493)

Source-only integration reference for staged review, not a merge-ready aggregate.
Donor: 0xlillith/solidcraft@aea20b0115.
Upstream: 858e5995d6.

Retain original CPU/material contracts and explicit GPU donor provenance in
docs/render-materials-lab.md (#2067, #2191, #2780, #3306). Preserve released
format migrations and current navigation/startup/shell behavior. New saved
records use pending descriptors. The physical-card descriptor follows the
maintainer's material-engineering-cards naming request, with a legacy-lab
format-29 regression. Replace raw new panel hosts with shared containers.

Repository checks, complete workspace/all-target Clippy, and the independent
physical/resource authoring checks pass for this source. The fresh full local
CI invocation has reached test compilation and is not yet complete. Do not
transfer donor native output or prior test totals to this integration.

Generated review screenshots, video, package ZIP and machine logs remain at
the immutable personal evidence pin. Uncommitted geometric displacement is
backed up separately, not silently included. No kernel/vendor change, direct
main write, release or independent contributor-branch rewrite.

Co-authored-by: Christian Svensson <blue@cmd.nu>

* test(cli): pin the Compact camera-sample admission diagnostic (#5493)

The bounded request still refuses 1024x1024x64 samples before host initialization and writes no output. Update only the stale expected diagnostic to the existing Compact budget wording; production limits and code are unchanged. Exact-tree CLI regression suite: 14 passed, 0 failed. The full repository gate has been invoked separately and is not yet complete.

* Normalize UI container violation paths across platforms

Report repository-relative paths with forward slashes so diagnostics and the existing nested-package regression assertions agree on Windows and Unix. Keep the container detection rules unchanged.

Validation: official ui-containers gate and all seven focused xtask tests passed; rustfmt and diff checks passed. Only xtask/dependencies were compiled; no application build or heavy tests.
(cherry picked from commit 44b58d8e10)

* fix(render): preserve camera contracts and correct acceptance regressions (#5493)

Preserve Design view.apply semantics with a separate strict Render camera command. Retain existing translations when English-only aliases collide; add material-axis entries and camera-specific pitch labels. Compare complete validated engineering cards and retain job handles before cancellation.

Focused and native acceptance is pinned to tree f8a423b21f. Full CI has been invoked separately and is not claimed green. Landing follows the render integration policy in #5493.

* fix(render): resolve showcase licence and upstream resource hygiene (#5493)

Record SychPL's explicit MIT OR Apache-2.0 grant, retaining source/model bytes and the Ubuntu lettering notice. Remove 80 absent attribution rows, personal fork records, dead delivery attributes and three fork/resource-only workflows. Existing xtask assets now performs bounded offline hash checks and rejects orphan render attribution; no parallel draft CI or package installation. Original authoring reproduction remains explicit. Scoped xtask tests, assets, Clippy, formatting and prepared SELENE validation pass; no application or renderer-wide result is inferred.

* fix(render): align saved bounds and progressive sample resolution (#5493)

Address review r4364211669/r4364211677/r4364211681/r4364211691/r4364211695. Persisted light/frame domains respect the existing 1e9 document bound; related LED/rectangle/direction cases use the same bound. Workstation primary resolve shares the 4096 admission cap and film counters use checked conversions. Exact candidate: 485 CPU render tests, 21 render document tests and strict scoped Clippy pass, including positive boundary round trips and 2048/4096 end-to-end checkpoints. No released format/migration edits, relaxed test limits or full-stack acceptance claim.

* wip(render): isolate optional resources and harden sample handling (#5493)

Review work in progress: opt-in encoded render library with reproducible runtime catalog exports; native-only robust dependency through the workspace; checked bloom slices; per-sample point-light diagnostics; independent area-light spatial/film keys. Resource-module binaries in both configurations, generation, Cargo production feature graphs and attribution checks pass. Full engine/render regression and combined acceptance are pending: do not merge this donor as a constituent or treat scoped resource proof as runtime acceptance.

* fix(gpu): preserve donor allocations through the scope-safety repair (#5722)

Port the native-validated #5723 scope-cleanup correction into the experimental donor, retaining its adaptive, volume, aging, photographic and bloom allocations. Same reverse-drain helper and regression cases; the donor combination still needs its own compile/test gate and is not covered retroactively by render-base results.

* claim: #1369

* Reject unknown pending concepts after format folding (#1369)

* test(render): close bounded sampling and bloom review regressions (#5493)

Validate the optional-resource/lighting/dependency donor at its exact tree. Required Vulkan GPU 127/0/3; CPU renderer 487/0; engine Render 72/0; document render 21/0; lean library 7/0; strict scoped Clippy, assets/layers/lists/containers and lean-engine WASM pass. Preserve original failed controller/typing attempts. This is the draft donor/disposition source, not a replacement for constituent render PRs or final main acceptance.

* wip(render): preserve stable aging target validation candidate

Exact staged source from prior review work on donor 3b892eab5e. This is a recovery/review checkpoint, NOT accepted delivery. An actual command-path regression currently fails because the selected executor refuses ordered surface aging. No assertion, capability or admission limit is weakened. Native/UI/full combination acceptance remains pending. Saved/runtime split adds one pending descriptor and retains original file scope; no main/render branch is changed.

* test(render): preserve numeric setup intent at the admitted coordinate bound

Follow up jyviko review on #5494 without weakening the corrected saved-coordinate contract. The positive clicked fixture uses 1e9 instead of inadmissible 2e9; explicit out-of-range cases still refuse, and the full saved setup round-trips through JSON and the native container. Exact-source Render workspace 95/0 and strict all-target UI Clippy pass. This does not incorporate the separately failing stable-aging candidate or claim full current-render acceptance.

* test(render): use the real GPU executor for saved aging

Move successful native cold-reopen Check/Start coverage from the CPU-backed protocol fixture into the production GPU executor tests. Verify capture-index changes preserve the stable target and that enabling aging changes both PNG and raw EXR output. Retain explicit, allocation-free refusal coverage for executors without aging support. Production capabilities and admission checks are unchanged.

* fix(render): persist stable identities for targeted aging (#5493)

Separate saved RenderBodyTarget identities from captured mesh ordinals. Reject legacy ambiguous targets, resolve Check/Start after visibility changes and preserve native reopening, copies and undo. Unsupported executors still refuse; real AMD Vulkan regression completes saved aging after reordered capture.

Source tree 6b84c8ad passes document 23, engine Render 75, GPU effects 5 and Render UI 95 with no failures; scoped strict Clippy, WASM and repository gates pass. Fresh CLI/native reopen and clean/aged GPU exports pass with identical physical totals and inspected actual images. Whole current-render integration is separate.

* fix(render): reconcile combined CPU/GPU contracts on current upstream

Unify captured resources/status and CPU-vs-GPU request schemas after the real two-parent integration; remove obsolete duplicate Vulkan selector and retain combined platform-filter regression. Deduplicate only identical or superseded test definitions, retaining the stronger card metadata and reserved-executor assertions. No assertions, admission limits or feature refusals are weakened.

All targets of render dependencies, GPU, engine, UI, CLI and native app pass cargo check with raytrace-cpu and bundled-render-library at tree c70d00d1. Native executable tests and full current-source acceptance remain pending. This is a private integration rehearsal for subsequent constituent PRs, not an aggregate official render/main merge.

* test(render): retain one complete host lifetime regression set

Deduplicate byte-identical DropProbe/task-lifetime tests and retain the adapted environment/texture ownership regressions with every assertion and complete memory estimate. Keep the registered-geometry admission regression once; only struct field order differed. Replace a one-element diagnostic loop with its equivalent block, preserving all wrap/width assertions.

Test-only integration repair. Formatting and diff checks pass; refreshed executable validation is required. No production behavior, limits, assertions or ignores changed.

* fix(doc): recognize the proven format-29 card descriptor alias

Normalize only the historical format-29 physical-material-cards spelling, and only when material-engineering-cards is registered. Admission and migration de-duplication use the same identity. Unknown concepts, wrong versions and incapable readers still refuse before mutation. Six controlled-history Rust regressions and actual CLI migration/no-clobber acceptance pass. No version, released migration or CI changes. Refs #5793, #1369, #5493.

* test(render): preserve grounding refusal before explicit instance moves

Update the two Render binding fixtures for upstream first-occurrence grounding. Verify grounded movement refuses without changing document/history, then explicitly unground through the public command before the intended move. Retain every target, resource, copy and persistence assertion. Refs #5493.

---------

Co-authored-by: Christian Svensson <blue@cmd.nu>
Co-authored-by: Victor Santos Oliveira <56417388+Vittuu@users.noreply.github.com>
Co-authored-by: cfaulkingham <colin.faulkingham@gmail.com>

2026-10-24 14:21:59 +00:00

12 KiB

Raw Permalink Blame History

Validation record

The original catalog, preset and prepared-resource review below is dated 2026-10-21. The 2026-10-22 native-source update supersedes its missing-source finding; other historical results retain their original scope.

Current native-source status — 2026-10-22

The owner supplied the improved SELENE-showcase.solidcraft, and the source lock is now pinned_native. SOURCE.md records the verified author commit, SHA-256, retained notices and executor/format boundary. The native package now includes source-container mechanism bindings and reproducible command generators for mechanisms and electronics.

The native package validation record is the authority for the derivative's actual model hash, native executor, sampled mechanism checks, scoped interference and preview exports. RENDER.md records the separately executed product-render checks and whole-model executor limits. Source-container inspection, component fixtures, final-model acceptance and renderer results retain their individual scopes. The broader catalog remains unbound; repository-wide gate results are reported explicitly rather than inferred from the native runs.

The catalog and prepared-resource data validators were rerun for this status update: both passed with 0 errors, and the catalog reported 0 warnings. The prepared-resource result reports native_source_status: pinned_native and runtime_ready: false. Local links in the three updated Markdown documents and the UI contract's native-source paths resolved; whitespace checks passed. These are documentation/data checks, not additional native solver or renderer runs.

Historical package checks — 2026-10-21

The package validator completed with 0 errors and 0 warnings on the authored data:

Collection	Records
Material concepts	600
Lighting concepts	280
Environment concepts	280
Renderer capabilities	120
UX requirements	56
Future simulation requirements	36
Roadmap phases	19
Quality presets	10
Studio presets	24
Environment presets	24
Complete scene presets	24
Current-contract setup examples	6
Analytic physics fixtures	6

Reproduce from the repository root:

python3 docs/render-materials/validate_catalog.py --json

Checks include unique IDs and names, expected series and counts, required data fields, finite numbers, capability/provenance/source references, roadmap dependency cycles, sample and path-depth bounds, output capabilities, light geometry, passive modifiers, unit declarations, physical-vacuum environment rules, scene dependency unions, ground/rock role references and solar-source ownership.

The six current-contract examples were checked against the pinned docs/render-settings.md: command/field shape, backend/mode/format, setup names, dimensions, pixel product, color bytes and exposure/environment bounds. They were not executed in a SolidCraft application. Preflight against a real document must also account for existing setup names and the 32-setup total limit.

Analytic fixture expectations were recomputed for constant-gravity flight, millimeter/SI conversion including inertia and torque, offset release velocity, principal-inertia admissibility and sample mass bookkeeping. These checks validate the specification's arithmetic; they do not test an implemented physics solver.

Six deliberately invalid temporary variants were rejected: a duplicated solar source, an oversized baseline pixel product, an incorrect gravity unit, a missing PNG capability, hidden lunar ambient fill and acceptance of impossible principal inertia. The invalid variants are not committed.

Internal Markdown file links and exact attribution paths were checked. The data and documentation were reviewed for English wording, stable legacy IDs, source ownership, availability claims and clean-room scope. A second review identified and corrected missing quality dependencies, ambiguous temporal budgets, insufficient inertia constraints, inconsistent UX level names and publication sequencing.

Historical source-model verification — 2026-10-21

The historical v7 SELENE native file was read as a container and its document inspected. SHA-256, file size, format, units, component/occurrence inventory, revolute joints, angle limits and selected vial feature/body references were recorded. No native-file rebuild, geometry regeneration, collision simulation or application render was performed during that review. The historical v7 model was not bundled; the currently admitted improved source is described above.

Historical prepared-resource continuation — 2026-10-21

At that review, the prepared package under assets/render/selene/ contained 48 appearance recipes, a 99-command swatch input, 33 semantic roles, 10 stages, 12 shots, 12 mechanism review areas, a five-command read-only preflight, an eleven-state future dynamics sequence, a UI integration flow and two development tools.

Reproduce its read-only data check:

python3 assets/render/selene/tools/validate_prepared.py --json

The check completed with 0 errors. It covers source-state honesty, historical-source exclusion, catalog references and input hashes, exact opaque PBR field/value bounds, swatch construction/assignment consistency, semantic-role references, inherited capability unions, physical-lunar Sun/ambient ownership, camera bounds and motion-state transitions. The full catalog validator also passed again with 0 errors and 0 warnings after all ten SELENE scene specifications were redirected to the improved-source lock.

Thirteen focused adapter checks passed using temporary original synthetic fixtures and the previously inspected historical v7 file: captured-byte identity; blocked pending source; successful reviewed synthetic opaque assignment; unknown target rejection; overlapping assignment rejection; dust-layer rejection in the opaque adapter; mismatched source digest rejection; boolean-opacity rejection; invalid-color rejection; empty-label rejection; legacy-v7 rejection even when relabeled; existing-output preservation; duplicate-native-JSON-key rejection. The synthetic fixture does not establish the improved model's identity. No fixture admission record or generated test output is shipped.

Four mechanism planning calculations were independently recomputed from the documented rounded inputs: actuator stroke and stop, rack travel, candidate gear magnitude and candidate screw travel. These are arithmetic checks, not a replay of the source mechanisms or a physical simulation. The mechanism guide records the coordinate precision and unbound direction/driver assumptions.

An independent review corrected two appearance-to-concept associations, confirmed the explicit layered/anodized surrogate descriptions, and identified input validation and shared-definition scope issues in the preparation tool. The final tool parses the same byte snapshot that it hashes and requires explicit review of all occurrences affected by a body-definition appearance edit.

The improved SELENE-showcase.solidcraft native file was not found in the bounded public-source search performed for that review. Its source lock was then awaiting_native_source; native selectors, runtime mechanism evidence and full scene execution were unresolved. That missing-source finding is superseded by the 2026-10-22 admission recorded above and in SOURCE.md. The opaque swatch script was checked against existing command shapes but was not executed or rendered during the historical review.

Historical redesign-aligned UI continuation — 2026-10-21

The UI specification was reconciled with the implemented upstream design at 728f753b8094e1a54c5cc8b7e453982afa028023 (0.18.4), keeping the personal integration base at 93a2922c5ee272fb605703ae84c05825b4a74607 (0.18.2). All 21 source-record blob pairs in ui-integration.json were checked against Git objects: 17 are identical; the recorded toolbar, navigation, document and shell-composition source files have differences that do not authorize an automatic base update.

The review verified 13 current command/icon registrations, the named UI-kit controls, the theme-token names and the distinction between the one Render tab and its Scene/Image ribbon groups. Existing ws_render, appearance and render_image artwork was previewed at 64, 24 and 16 pixels in light and dark through the repository palette. No SVG, palette or acceptance record changed. These previews are not application screenshots or evidence that the planned UI is implemented.

The catalog and prepared-resource validators passed again with 0 errors; the catalog also reported 0 warnings. Their coverage now includes the unbound UI contract, source-identity field consistency, current tab/picking declarations, disclosure/category rules, exact quality names and references, all twelve per-shot recommendation groups, preserved shot defaults, command reuse/proposal consistency and isolated swatch-opening declarations. The 56 stable UX requirement IDs remain intact. Four deliberately invalid temporary variants were rejected: invented current Render picking, a wrong quality label, a changed shot default and a false swatch runtime-execution claim.

An independent source review corrected the Render tab's selected treatment to render_ink on render_soft, and cross-file review aligned the lunar quality recommendations and six default controls. The primary lunar set is Sun azimuth, Sun elevation, exposure, camera framing, terrain seed and supported dust coverage. Appearance variants stay in the appearance context.

At this review, 99 local Markdown links resolved and the new JSON contract had an exact attribution row. The existing commands and source metadata were inspected, not executed. No new runtime UI, render, screenshot, screen-reader result, usability measurement or platform-parity result is claimed. The acceptance matrix is work for the runtime implementation.

Historical repository gate limitation — 2026-10-21

The required commands cargo xtask ci, cargo xtask assets and cargo xtask icons were attempted in the isolated checkout and could not start:

cargo: command not found

The environment at that review lacked the Rust toolchain, so the PR was left as a draft pending the relevant repository checks on the submitted tree. This records an uncompleted historical gate; it does not describe the current toolchain or establish a later CI outcome. The root attribution file is embedded by the UI and can expand CI's affected scope.

The same three required commands were attempted for the UI continuation and again could not start because cargo is unavailable. No successful Rust gate is inferred from the Python data checks.

The package validator and whitespace review do not substitute for repository CI, renderer reference images, native/WASM execution or physics validation. The historical catalog/UI review produced no application screenshots of new runtime behavior.

Not established by this contribution

Runtime availability of the 1,160 content concepts or 82 future preset specifications.
A production-validated appearance/HDR/terrain asset pack or calibrated source photometry.
Measured optical, mechanical, electrical, thermal or granular properties.
A photorealistic SELENE render, a reachable catch or a physically simulated animation.
Competitive performance, platform parity or a successful full Rust CI run.

These are explicit implementation and validation milestones in the handoff, capability registry and roadmap.

12 KiB Raw Permalink Blame History