Files
solvecraft/docs/render-primary-aa.md
selune 9e6e0b8df1 Render workspace: complete experimental ribbon, resources and effects integration (#5493) (#5494)
* wip(render): reconcile completed material and image pipeline source with 0.20 (#5493)

Source-only integration reference for staged review, not a merge-ready aggregate.
Donor: 0xlillith/solidcraft@aea20b0115.
Upstream: 858e5995d6.

Retain original CPU/material contracts and explicit GPU donor provenance in
docs/render-materials-lab.md (#2067, #2191, #2780, #3306). Preserve released
format migrations and current navigation/startup/shell behavior. New saved
records use pending descriptors. The physical-card descriptor follows the
maintainer's material-engineering-cards naming request, with a legacy-lab
format-29 regression. Replace raw new panel hosts with shared containers.

Repository checks, complete workspace/all-target Clippy, and the independent
physical/resource authoring checks pass for this source. The fresh full local
CI invocation has reached test compilation and is not yet complete. Do not
transfer donor native output or prior test totals to this integration.

Generated review screenshots, video, package ZIP and machine logs remain at
the immutable personal evidence pin. Uncommitted geometric displacement is
backed up separately, not silently included. No kernel/vendor change, direct
main write, release or independent contributor-branch rewrite.

Co-authored-by: Christian Svensson <blue@cmd.nu>

* test(cli): pin the Compact camera-sample admission diagnostic (#5493)

The bounded request still refuses 1024x1024x64 samples before host initialization and writes no output. Update only the stale expected diagnostic to the existing Compact budget wording; production limits and code are unchanged. Exact-tree CLI regression suite: 14 passed, 0 failed. The full repository gate has been invoked separately and is not yet complete.

* Normalize UI container violation paths across platforms

Report repository-relative paths with forward slashes so diagnostics and the existing nested-package regression assertions agree on Windows and Unix. Keep the container detection rules unchanged.

Validation: official ui-containers gate and all seven focused xtask tests passed; rustfmt and diff checks passed. Only xtask/dependencies were compiled; no application build or heavy tests.
(cherry picked from commit 44b58d8e10)

* fix(render): preserve camera contracts and correct acceptance regressions (#5493)

Preserve Design view.apply semantics with a separate strict Render camera command. Retain existing translations when English-only aliases collide; add material-axis entries and camera-specific pitch labels. Compare complete validated engineering cards and retain job handles before cancellation.

Focused and native acceptance is pinned to tree f8a423b21f. Full CI has been invoked separately and is not claimed green. Landing follows the render integration policy in #5493.

* fix(render): resolve showcase licence and upstream resource hygiene (#5493)

Record SychPL's explicit MIT OR Apache-2.0 grant, retaining source/model bytes and the Ubuntu lettering notice. Remove 80 absent attribution rows, personal fork records, dead delivery attributes and three fork/resource-only workflows. Existing xtask assets now performs bounded offline hash checks and rejects orphan render attribution; no parallel draft CI or package installation. Original authoring reproduction remains explicit. Scoped xtask tests, assets, Clippy, formatting and prepared SELENE validation pass; no application or renderer-wide result is inferred.

* fix(render): align saved bounds and progressive sample resolution (#5493)

Address review r4364211669/r4364211677/r4364211681/r4364211691/r4364211695. Persisted light/frame domains respect the existing 1e9 document bound; related LED/rectangle/direction cases use the same bound. Workstation primary resolve shares the 4096 admission cap and film counters use checked conversions. Exact candidate: 485 CPU render tests, 21 render document tests and strict scoped Clippy pass, including positive boundary round trips and 2048/4096 end-to-end checkpoints. No released format/migration edits, relaxed test limits or full-stack acceptance claim.

* wip(render): isolate optional resources and harden sample handling (#5493)

Review work in progress: opt-in encoded render library with reproducible runtime catalog exports; native-only robust dependency through the workspace; checked bloom slices; per-sample point-light diagnostics; independent area-light spatial/film keys. Resource-module binaries in both configurations, generation, Cargo production feature graphs and attribution checks pass. Full engine/render regression and combined acceptance are pending: do not merge this donor as a constituent or treat scoped resource proof as runtime acceptance.

* fix(gpu): preserve donor allocations through the scope-safety repair (#5722)

Port the native-validated #5723 scope-cleanup correction into the experimental donor, retaining its adaptive, volume, aging, photographic and bloom allocations. Same reverse-drain helper and regression cases; the donor combination still needs its own compile/test gate and is not covered retroactively by render-base results.

* claim: #1369

* Reject unknown pending concepts after format folding (#1369)

* test(render): close bounded sampling and bloom review regressions (#5493)

Validate the optional-resource/lighting/dependency donor at its exact tree. Required Vulkan GPU 127/0/3; CPU renderer 487/0; engine Render 72/0; document render 21/0; lean library 7/0; strict scoped Clippy, assets/layers/lists/containers and lean-engine WASM pass. Preserve original failed controller/typing attempts. This is the draft donor/disposition source, not a replacement for constituent render PRs or final main acceptance.

* wip(render): preserve stable aging target validation candidate

Exact staged source from prior review work on donor 3b892eab5e. This is a recovery/review checkpoint, NOT accepted delivery. An actual command-path regression currently fails because the selected executor refuses ordered surface aging. No assertion, capability or admission limit is weakened. Native/UI/full combination acceptance remains pending. Saved/runtime split adds one pending descriptor and retains original file scope; no main/render branch is changed.

* test(render): preserve numeric setup intent at the admitted coordinate bound

Follow up jyviko review on #5494 without weakening the corrected saved-coordinate contract. The positive clicked fixture uses 1e9 instead of inadmissible 2e9; explicit out-of-range cases still refuse, and the full saved setup round-trips through JSON and the native container. Exact-source Render workspace 95/0 and strict all-target UI Clippy pass. This does not incorporate the separately failing stable-aging candidate or claim full current-render acceptance.

* test(render): use the real GPU executor for saved aging

Move successful native cold-reopen Check/Start coverage from the CPU-backed protocol fixture into the production GPU executor tests. Verify capture-index changes preserve the stable target and that enabling aging changes both PNG and raw EXR output. Retain explicit, allocation-free refusal coverage for executors without aging support. Production capabilities and admission checks are unchanged.

* fix(render): persist stable identities for targeted aging (#5493)

Separate saved RenderBodyTarget identities from captured mesh ordinals. Reject legacy ambiguous targets, resolve Check/Start after visibility changes and preserve native reopening, copies and undo. Unsupported executors still refuse; real AMD Vulkan regression completes saved aging after reordered capture.

Source tree 6b84c8ad passes document 23, engine Render 75, GPU effects 5 and Render UI 95 with no failures; scoped strict Clippy, WASM and repository gates pass. Fresh CLI/native reopen and clean/aged GPU exports pass with identical physical totals and inspected actual images. Whole current-render integration is separate.

* fix(render): reconcile combined CPU/GPU contracts on current upstream

Unify captured resources/status and CPU-vs-GPU request schemas after the real two-parent integration; remove obsolete duplicate Vulkan selector and retain combined platform-filter regression. Deduplicate only identical or superseded test definitions, retaining the stronger card metadata and reserved-executor assertions. No assertions, admission limits or feature refusals are weakened.

All targets of render dependencies, GPU, engine, UI, CLI and native app pass cargo check with raytrace-cpu and bundled-render-library at tree c70d00d1. Native executable tests and full current-source acceptance remain pending. This is a private integration rehearsal for subsequent constituent PRs, not an aggregate official render/main merge.

* test(render): retain one complete host lifetime regression set

Deduplicate byte-identical DropProbe/task-lifetime tests and retain the adapted environment/texture ownership regressions with every assertion and complete memory estimate. Keep the registered-geometry admission regression once; only struct field order differed. Replace a one-element diagnostic loop with its equivalent block, preserving all wrap/width assertions.

Test-only integration repair. Formatting and diff checks pass; refreshed executable validation is required. No production behavior, limits, assertions or ignores changed.

* fix(doc): recognize the proven format-29 card descriptor alias

Normalize only the historical format-29 physical-material-cards spelling, and only when material-engineering-cards is registered. Admission and migration de-duplication use the same identity. Unknown concepts, wrong versions and incapable readers still refuse before mutation. Six controlled-history Rust regressions and actual CLI migration/no-clobber acceptance pass. No version, released migration or CI changes. Refs #5793, #1369, #5493.

* test(render): preserve grounding refusal before explicit instance moves

Update the two Render binding fixtures for upstream first-occurrence grounding. Verify grounded movement refuses without changing document/history, then explicitly unground through the public command before the intended move. Retain every target, resource, copy and persistence assertion. Refs #5493.

---------

Co-authored-by: Christian Svensson <blue@cmd.nu>
Co-authored-by: Victor Santos Oliveira <56417388+Vittuu@users.noreply.github.com>
Co-authored-by: cfaulkingham <colin.faulkingham@gmail.com>
2026-10-24 14:21:59 +00:00

5.6 KiB

Bounded primary spatial AA proposal (#620 / existing render-quality work)

Source port on the personal rendering branch's CPU/GPU2 snapshot. Written tests for this recovered unit have not run on this integrated revision; compilation, layout, PNG, performance and full project validation remain the caller's next gate. See advanced CPU integration for the exact source baseline and recovery provenance.

raytrace.primary_samples is a transient request option: omitted/1 retains the legacy fixed-centre route,4 uses a2x2 pixel-box grid,16 uses4x4. Other counts refuse. Default1 is omitted from serialized options to preserve the default request representation. Nothing is added to document/RenderSetup persistence, undo, GPU MSAA, material libraries or optical boundary definitions. The integrated CPU image UI already exposes 1/4/16 primary samples; engine/MCP and the CLI's runtime raytrace options use the same request contract. This recovered follow-up changes the bounded reuse implementation, without introducing saved AA state.

The single-primary branch keeps its former generator, reuse proof, R addition order/divisor, primary-background shortcut, seeds, work debits and encoding. New modes complete ALL SR logical attempts, including primary misses and nonselected surfaces. The current fixed grid certifies repeatability only within one (pixel, spatial ordinal), so a completed nonselected PRIMARY hit may reuse its full direct/environment radiance across R. Each reused R still debits one cancelable scalar continuation, adds coverage once, performs the original ordered radiance addition and finite-bound check, and keeps the original divisor. Selected hits (including null reflections), secondary paths and primary misses retain the uncached route. A completed-state marker uses the existing bounded light cursor; no task fields, allocations or pools are added. The marker is cleared before the next spatial sample or pixel; it never crosses jobs. Future per-R jitter or other varying inputs must revoke the generator proof. The old blanket assertion forbidding every AA birth proof is replaced by fixed-ray invariance, distinct-spatial-ray, hit-classification and actual-consumer reference regressions; observable coverage, progress and refusal assertions are preserved. R remains the existing reflection attempt count (or1 with no active selections), bounded1..64. Null reflected continuations contribute zero and still count in R; they never erase primary coverage. Grid centres are strictly inside the pixel, fixed row-major, without jitter/temporal sampling or a progressive-prefix claim. New reflection keys use checked pixelS+s plus a fixed AA domain xor; the existing sampler receives the same reflection ordinal, bounce and R as before. No PDF or BSDF is changed.

For geometry hit indicator H and scene-linear path radiance L, C=sum(H)/(SR) and P=sum(L)/(SR). New modes compute conditional geometry radiance G=P/C, apply exposure/Reinhard once to G, then composite C*T(G)+(1-C)*decode(background) in display-linear sRGB before one sRGB encoding. All-miss pixels retain the exact background bytes; full coverage omits background operations. Background remains display-referred, not an emitter and not exposure-controlled. Do not averageRGB8, individually tone-mapped paths or tone the premultiplied P. Output alpha stays255; coverage is internal quadrature, not transparency/refraction support.

One ImageTask/PendingPixel/BVH/host pool and one cumulative1e9 WorkBudget remain. AA retains fixed scalar/Vec3 accumulators; reuse adds no fields. Per-R-add radiance limits remain unchanged; spatial normalized sums have a finite1e12 bound. Coverage is checkedu16<=1024. Separate spatial finalization and pixel emission states each debit work and yield; cancellation is checked again just before pixel bytes are emitted. Running progress still counts completed OUTPUT pixels. No partial PNG or samples reduced on exhaustion. Existing384MiB job/512MiB host limits and PNG encoder are retained. A compile-time type-length check and written layout regression require actual ImageTask<=4096 bytes; because no build has run, actual layout is NOT qualified.

Cost can grow with S*R, traversal, lights, HDR and bounces. Retaining exact intra-spatial primary reuse does not establish any work-budget success. Limits can refuse jobs that previously completed. No work/ray equality, speedup, smooth metal, universal antialiasing or final-mode claim follows. Thin/repeated geometry can still alias under fixed quadrature, and reflection noise is a separate issue.

Nine written regressions cover strict options/default serialization; grid and analytic discrete edge coverage; conditional tone/display-linear compositing; actual hit-first/miss-first half-plane traversal acrossR1/4/16/64 with nulls; all-miss bytes and quantum parity; full coverage; cancellation/work exhaustion in later spatial samples/finalization/emission; and S1 isolation/bytes/work with same caps/layout. The blanket birth-proof policy assertion changes as described above; existing observable assertions remain. New actual-consumer tests compare every ordered R accumulator prefix, logical coverage and PNG bytes with the same ImageTask route whose proof is revoked before its first shading completion. Execution, type/layout checks and all acceptance gates are pending. Default-vs-historical exact-build byte/work comparison, engine/host preflight validation, arbitrary projection scenes, allocation/layout and ownership gates, Clippy/wasm and required cargo xtask ci are required before publication. Designer must inspect actual equal-camera edge comparisons; source math is not visual acceptance. No external code/assets/dependencies were added.