mirror of https://github.com/bherbruck/solidcraft.git synced 2026-11-07 12:31:56 +00:00

Files

T

selune 9e6e0b8df1 Render workspace: complete experimental ribbon, resources and effects integration (#5493 ) (#5494 )

* wip(render): reconcile completed material and image pipeline source with 0.20 (#5493)

Source-only integration reference for staged review, not a merge-ready aggregate.
Donor: 0xlillith/solidcraft@aea20b0115.
Upstream: 858e5995d6.

Retain original CPU/material contracts and explicit GPU donor provenance in
docs/render-materials-lab.md (#2067, #2191, #2780, #3306). Preserve released
format migrations and current navigation/startup/shell behavior. New saved
records use pending descriptors. The physical-card descriptor follows the
maintainer's material-engineering-cards naming request, with a legacy-lab
format-29 regression. Replace raw new panel hosts with shared containers.

Repository checks, complete workspace/all-target Clippy, and the independent
physical/resource authoring checks pass for this source. The fresh full local
CI invocation has reached test compilation and is not yet complete. Do not
transfer donor native output or prior test totals to this integration.

Generated review screenshots, video, package ZIP and machine logs remain at
the immutable personal evidence pin. Uncommitted geometric displacement is
backed up separately, not silently included. No kernel/vendor change, direct
main write, release or independent contributor-branch rewrite.

Co-authored-by: Christian Svensson <blue@cmd.nu>

* test(cli): pin the Compact camera-sample admission diagnostic (#5493)

The bounded request still refuses 1024x1024x64 samples before host initialization and writes no output. Update only the stale expected diagnostic to the existing Compact budget wording; production limits and code are unchanged. Exact-tree CLI regression suite: 14 passed, 0 failed. The full repository gate has been invoked separately and is not yet complete.

* Normalize UI container violation paths across platforms

Report repository-relative paths with forward slashes so diagnostics and the existing nested-package regression assertions agree on Windows and Unix. Keep the container detection rules unchanged.

Validation: official ui-containers gate and all seven focused xtask tests passed; rustfmt and diff checks passed. Only xtask/dependencies were compiled; no application build or heavy tests.
(cherry picked from commit 44b58d8e10)

* fix(render): preserve camera contracts and correct acceptance regressions (#5493)

Preserve Design view.apply semantics with a separate strict Render camera command. Retain existing translations when English-only aliases collide; add material-axis entries and camera-specific pitch labels. Compare complete validated engineering cards and retain job handles before cancellation.

Focused and native acceptance is pinned to tree f8a423b21f. Full CI has been invoked separately and is not claimed green. Landing follows the render integration policy in #5493.

* fix(render): resolve showcase licence and upstream resource hygiene (#5493)

Record SychPL's explicit MIT OR Apache-2.0 grant, retaining source/model bytes and the Ubuntu lettering notice. Remove 80 absent attribution rows, personal fork records, dead delivery attributes and three fork/resource-only workflows. Existing xtask assets now performs bounded offline hash checks and rejects orphan render attribution; no parallel draft CI or package installation. Original authoring reproduction remains explicit. Scoped xtask tests, assets, Clippy, formatting and prepared SELENE validation pass; no application or renderer-wide result is inferred.

* fix(render): align saved bounds and progressive sample resolution (#5493)

Address review r4364211669/r4364211677/r4364211681/r4364211691/r4364211695. Persisted light/frame domains respect the existing 1e9 document bound; related LED/rectangle/direction cases use the same bound. Workstation primary resolve shares the 4096 admission cap and film counters use checked conversions. Exact candidate: 485 CPU render tests, 21 render document tests and strict scoped Clippy pass, including positive boundary round trips and 2048/4096 end-to-end checkpoints. No released format/migration edits, relaxed test limits or full-stack acceptance claim.

* wip(render): isolate optional resources and harden sample handling (#5493)

Review work in progress: opt-in encoded render library with reproducible runtime catalog exports; native-only robust dependency through the workspace; checked bloom slices; per-sample point-light diagnostics; independent area-light spatial/film keys. Resource-module binaries in both configurations, generation, Cargo production feature graphs and attribution checks pass. Full engine/render regression and combined acceptance are pending: do not merge this donor as a constituent or treat scoped resource proof as runtime acceptance.

* fix(gpu): preserve donor allocations through the scope-safety repair (#5722)

Port the native-validated #5723 scope-cleanup correction into the experimental donor, retaining its adaptive, volume, aging, photographic and bloom allocations. Same reverse-drain helper and regression cases; the donor combination still needs its own compile/test gate and is not covered retroactively by render-base results.

* claim: #1369

* Reject unknown pending concepts after format folding (#1369)

* test(render): close bounded sampling and bloom review regressions (#5493)

Validate the optional-resource/lighting/dependency donor at its exact tree. Required Vulkan GPU 127/0/3; CPU renderer 487/0; engine Render 72/0; document render 21/0; lean library 7/0; strict scoped Clippy, assets/layers/lists/containers and lean-engine WASM pass. Preserve original failed controller/typing attempts. This is the draft donor/disposition source, not a replacement for constituent render PRs or final main acceptance.

* wip(render): preserve stable aging target validation candidate

Exact staged source from prior review work on donor 3b892eab5e. This is a recovery/review checkpoint, NOT accepted delivery. An actual command-path regression currently fails because the selected executor refuses ordered surface aging. No assertion, capability or admission limit is weakened. Native/UI/full combination acceptance remains pending. Saved/runtime split adds one pending descriptor and retains original file scope; no main/render branch is changed.

* test(render): preserve numeric setup intent at the admitted coordinate bound

Follow up jyviko review on #5494 without weakening the corrected saved-coordinate contract. The positive clicked fixture uses 1e9 instead of inadmissible 2e9; explicit out-of-range cases still refuse, and the full saved setup round-trips through JSON and the native container. Exact-source Render workspace 95/0 and strict all-target UI Clippy pass. This does not incorporate the separately failing stable-aging candidate or claim full current-render acceptance.

* test(render): use the real GPU executor for saved aging

Move successful native cold-reopen Check/Start coverage from the CPU-backed protocol fixture into the production GPU executor tests. Verify capture-index changes preserve the stable target and that enabling aging changes both PNG and raw EXR output. Retain explicit, allocation-free refusal coverage for executors without aging support. Production capabilities and admission checks are unchanged.

* fix(render): persist stable identities for targeted aging (#5493)

Separate saved RenderBodyTarget identities from captured mesh ordinals. Reject legacy ambiguous targets, resolve Check/Start after visibility changes and preserve native reopening, copies and undo. Unsupported executors still refuse; real AMD Vulkan regression completes saved aging after reordered capture.

Source tree 6b84c8ad passes document 23, engine Render 75, GPU effects 5 and Render UI 95 with no failures; scoped strict Clippy, WASM and repository gates pass. Fresh CLI/native reopen and clean/aged GPU exports pass with identical physical totals and inspected actual images. Whole current-render integration is separate.

* fix(render): reconcile combined CPU/GPU contracts on current upstream

Unify captured resources/status and CPU-vs-GPU request schemas after the real two-parent integration; remove obsolete duplicate Vulkan selector and retain combined platform-filter regression. Deduplicate only identical or superseded test definitions, retaining the stronger card metadata and reserved-executor assertions. No assertions, admission limits or feature refusals are weakened.

All targets of render dependencies, GPU, engine, UI, CLI and native app pass cargo check with raytrace-cpu and bundled-render-library at tree c70d00d1. Native executable tests and full current-source acceptance remain pending. This is a private integration rehearsal for subsequent constituent PRs, not an aggregate official render/main merge.

* test(render): retain one complete host lifetime regression set

Deduplicate byte-identical DropProbe/task-lifetime tests and retain the adapted environment/texture ownership regressions with every assertion and complete memory estimate. Keep the registered-geometry admission regression once; only struct field order differed. Replace a one-element diagnostic loop with its equivalent block, preserving all wrap/width assertions.

Test-only integration repair. Formatting and diff checks pass; refreshed executable validation is required. No production behavior, limits, assertions or ignores changed.

* fix(doc): recognize the proven format-29 card descriptor alias

Normalize only the historical format-29 physical-material-cards spelling, and only when material-engineering-cards is registered. Admission and migration de-duplication use the same identity. Unknown concepts, wrong versions and incapable readers still refuse before mutation. Six controlled-history Rust regressions and actual CLI migration/no-clobber acceptance pass. No version, released migration or CI changes. Refs #5793, #1369, #5493.

* test(render): preserve grounding refusal before explicit instance moves

Update the two Render binding fixtures for upstream first-occurrence grounding. Verify grounded movement refuses without changing document/history, then explicitly unground through the public command before the intended move. Retain every target, resource, copy and persistence assertion. Refs #5493.

---------

Co-authored-by: Christian Svensson <blue@cmd.nu>
Co-authored-by: Victor Santos Oliveira <56417388+Vittuu@users.noreply.github.com>
Co-authored-by: cfaulkingham <colin.faulkingham@gmail.com>

2026-10-24 14:21:59 +00:00

8.4 KiB

Raw Permalink Blame History

Physical material integration contract

This resource slice is based on 6d79d44fa403581e4508d7c9df5e163ff85085bf. It does not edit the parallel renderer implementation or the native document format. The native candidate-card schema is in crates/doc/src/physical_material.rs. The personal integration branch separately implements design-owned cards and library v2; capability checks must use the actual executing build.

Three independent representations

Extended reference profile: the authoritative physical data with quantities, individual source values, SI conversions, conditions, ranges, uncertainty, directions and unresolved applicability. It is not a solver material model.
Native schema-1 card: only the supported scalar point properties and complete admitted elastic blocks. Unsupported data remains in the extended profile and is listed in not_projected; it is never silently discarded.
Assigned document material: the application's material object, its explicit mass density, optional physical card and optional appearance. A profile link in the render catalog is not evidence that this object has been created or assigned.

exports/native-cards.json is a bundle of individually valid card objects plus projection metadata. It is not solidcraft-library/1, solidcraft-library/2, or an application command script. Do not pass its whole envelope as a single card.

Supported current commands

The baseline read-only API is:

{"command":"material.properties.validate","params":{"card":"<individual card object>"}}

Replace the placeholder string with the actual JSON object. It validates numerical/structural consistency and reports missing conditions and source review; it does not assign, persist or authenticate the data.

The parallel personal runtime's persistence contract, inspected in its engine source, is material.create / material.edit with an explicit physical_card:

material.create {name, density_g_cm3, physical_card}
material.edit   {material, physical_card}

A host must first verify that its registered command specification supports physical_card; older command implementations may ignore fields they do not know. The generated prepare plan names this prerequisite and is not executed here. It does not issue material.assign, guess body names or create geometry.

On the persistence implementation, editing the physical card does not silently replace the document's mass density. A discrepancy between card density in kg/m3 and assigned density in g/cm3 must be shown and explicitly resolved. The creation plan uses the same selected point density in both fields. A range, missing density or unselected formulation cannot create a falsely precise material.

For an existing body, retain its current physical material until a user explicitly selects a compatible reference profile. Changing a visual finish must retain physical fields, mass, joint geometry, body dimensions and material axes. Conversely, changing an engineering card must not recolor the body or replace its PBR maps. All document mutations must use the engine command/undo transaction, not direct JSON mutation or a Python runtime dependency.

Projection policy

The current native schema permits density, isotropic/orthotropic elasticity, scalar tensile/compressive/yield/shear strengths, thermal conductivity/expansion and specific heat. This exporter deliberately does not manufacture missing constants to fill those fields.

An isotropic block requires a same-source compatible E and Poisson ratio. Where Poisson ratio is explicitly derived from the same source's E and G, the formula and derived status are retained and identified in the native condition text.
A single directional Young modulus is not a complete orthotropic tensor. Wood flexural values and printed XY/Z coupon values stay directional in the extended data; no isotropic substitute is introduced.
Lower/upper bounds and intervals do not become native nominal point values. They remain listed omissions. No midpoint or minimum-as-typical substitution.
Directional thermal data is not copied into three axes. A repeated thermal diagonal is allowed only for a profile explicitly marked as an isotropic reference approximation, which the native state text discloses.
Each native property retains its own temperature, moisture and strain-rate fields. Other source conditions, including an interval or test method, are retained in its state text. Unknown conditions are null, not assumed room values.
Electrical data, hardness scales, radiative properties, porosity and transition temperatures remain in the richer profile. Typed runtime support for these quantities is separate work; preserve the extended data when designing it.

A structurally valid empty card is not a usable numerical material. The bundle labels it extended_data_only; the coverage and native report separate those eleven records from the 48 nonempty partial cards.

Layers, compounds and analogues

bindings.json states whether a concept is a bulk body, layer, deposit, treated surface, composite, textile, panel, granular material, device or assembly. Read both physical_role and every reference's relation before offering assignment.

A constituent reference cannot be directly used as the effective mass density or stiffness of a foam, laminate, populated PCB, honeycomb or multi-layer blanket. Layer properties need thickness/coverage; homogenized properties need an explicit construction and admissible model. Do not turn an unqualified comparison into a default because it is the first reference in a list.

Lunar-like concepts use named terrestrial simulants only where stated. Bulk packing density differs from grain density. Angle of repose is not substituted for an internal friction angle, and terrestrial packing data does not certify vacuum, gravity or thermal behavior on the Moon.

Future library v2 export

The integrated runtime's solidcraft_io::catalog owns library serialization. It computes entry revisions from its compact serde representation of provenance and definition. Do not calculate an assumed equivalent Python hash or hand-write a catalog revision: cross-language float spelling and omitted fields can differ.

The next runtime adapter should construct ValidatedCard through native admission, use the runtime's catalog types, retain provenance and the extended-profile ID, and generate the canonical revision through Entry::new / content_revision. Tests must cover import, undo/redo, saved reopen, unchanged appearance, density comparison and retention of unsupported extended fields. This slice performs none of those document mutations and does not claim them tested.

Validation boundaries

The supplied runner can invoke a trusted installed CLI only for read-only card validation. The report identifies its binary hash and explicitly says that it was not rebuilt by this gate. Numeric admission is not a source-license decision, a physical experiment, a constitutive validation, a safety factor, a whole-app build, or evidence of physics-driven rendering.

Safe native library exporter

tools/export_library.py --acknowledge-reference prepares a non-executing plan for the 46 point-density references and identifies 13 omitted profiles. Omission is explicit: the application requires a scalar mass density, but these profiles have no defensible scalar value. Full source profiles remain authoritative.

With --cli the helper checks the executable's registered command contract before creating a new review folder or running a material mutation. It requires explicit physical-card support, native inspection and library-v2 export. It uses a fresh CLI process, no geometry and no existing user design. The actual application serializes the v2 catalog and its revisions; Python does not approximate serde canonicalization. Every card, source, condition and density is compared before and after a separate-process cold reopen/re-export. The extended unsupported properties remain in this package, not falsely marked as embedded in schema 1.

The helper is an offline authoring/integration tool, not an application dependency. It never runs material.assign or changes a PBR appearance. Passing plan and refusal tests does not imply that modern-runtime persistence was executed; only a successful helper receipt establishes that separate result. Baseline read-only native admission and complete library export are deliberately distinct gates.

8.4 KiB Raw Permalink Blame History