mirror of https://github.com/bherbruck/solidcraft.git synced 2026-11-06 20:02:16 +00:00

Files

T

selune 9e6e0b8df1 Render workspace: complete experimental ribbon, resources and effects integration (#5493 ) (#5494 )

* wip(render): reconcile completed material and image pipeline source with 0.20 (#5493)

Source-only integration reference for staged review, not a merge-ready aggregate.
Donor: 0xlillith/solidcraft@aea20b0115.
Upstream: 858e5995d6.

Retain original CPU/material contracts and explicit GPU donor provenance in
docs/render-materials-lab.md (#2067, #2191, #2780, #3306). Preserve released
format migrations and current navigation/startup/shell behavior. New saved
records use pending descriptors. The physical-card descriptor follows the
maintainer's material-engineering-cards naming request, with a legacy-lab
format-29 regression. Replace raw new panel hosts with shared containers.

Repository checks, complete workspace/all-target Clippy, and the independent
physical/resource authoring checks pass for this source. The fresh full local
CI invocation has reached test compilation and is not yet complete. Do not
transfer donor native output or prior test totals to this integration.

Generated review screenshots, video, package ZIP and machine logs remain at
the immutable personal evidence pin. Uncommitted geometric displacement is
backed up separately, not silently included. No kernel/vendor change, direct
main write, release or independent contributor-branch rewrite.

Co-authored-by: Christian Svensson <blue@cmd.nu>

* test(cli): pin the Compact camera-sample admission diagnostic (#5493)

The bounded request still refuses 1024x1024x64 samples before host initialization and writes no output. Update only the stale expected diagnostic to the existing Compact budget wording; production limits and code are unchanged. Exact-tree CLI regression suite: 14 passed, 0 failed. The full repository gate has been invoked separately and is not yet complete.

* Normalize UI container violation paths across platforms

Report repository-relative paths with forward slashes so diagnostics and the existing nested-package regression assertions agree on Windows and Unix. Keep the container detection rules unchanged.

Validation: official ui-containers gate and all seven focused xtask tests passed; rustfmt and diff checks passed. Only xtask/dependencies were compiled; no application build or heavy tests.
(cherry picked from commit 44b58d8e10)

* fix(render): preserve camera contracts and correct acceptance regressions (#5493)

Preserve Design view.apply semantics with a separate strict Render camera command. Retain existing translations when English-only aliases collide; add material-axis entries and camera-specific pitch labels. Compare complete validated engineering cards and retain job handles before cancellation.

Focused and native acceptance is pinned to tree f8a423b21f. Full CI has been invoked separately and is not claimed green. Landing follows the render integration policy in #5493.

* fix(render): resolve showcase licence and upstream resource hygiene (#5493)

Record SychPL's explicit MIT OR Apache-2.0 grant, retaining source/model bytes and the Ubuntu lettering notice. Remove 80 absent attribution rows, personal fork records, dead delivery attributes and three fork/resource-only workflows. Existing xtask assets now performs bounded offline hash checks and rejects orphan render attribution; no parallel draft CI or package installation. Original authoring reproduction remains explicit. Scoped xtask tests, assets, Clippy, formatting and prepared SELENE validation pass; no application or renderer-wide result is inferred.

* fix(render): align saved bounds and progressive sample resolution (#5493)

Address review r4364211669/r4364211677/r4364211681/r4364211691/r4364211695. Persisted light/frame domains respect the existing 1e9 document bound; related LED/rectangle/direction cases use the same bound. Workstation primary resolve shares the 4096 admission cap and film counters use checked conversions. Exact candidate: 485 CPU render tests, 21 render document tests and strict scoped Clippy pass, including positive boundary round trips and 2048/4096 end-to-end checkpoints. No released format/migration edits, relaxed test limits or full-stack acceptance claim.

* wip(render): isolate optional resources and harden sample handling (#5493)

Review work in progress: opt-in encoded render library with reproducible runtime catalog exports; native-only robust dependency through the workspace; checked bloom slices; per-sample point-light diagnostics; independent area-light spatial/film keys. Resource-module binaries in both configurations, generation, Cargo production feature graphs and attribution checks pass. Full engine/render regression and combined acceptance are pending: do not merge this donor as a constituent or treat scoped resource proof as runtime acceptance.

* fix(gpu): preserve donor allocations through the scope-safety repair (#5722)

Port the native-validated #5723 scope-cleanup correction into the experimental donor, retaining its adaptive, volume, aging, photographic and bloom allocations. Same reverse-drain helper and regression cases; the donor combination still needs its own compile/test gate and is not covered retroactively by render-base results.

* claim: #1369

* Reject unknown pending concepts after format folding (#1369)

* test(render): close bounded sampling and bloom review regressions (#5493)

Validate the optional-resource/lighting/dependency donor at its exact tree. Required Vulkan GPU 127/0/3; CPU renderer 487/0; engine Render 72/0; document render 21/0; lean library 7/0; strict scoped Clippy, assets/layers/lists/containers and lean-engine WASM pass. Preserve original failed controller/typing attempts. This is the draft donor/disposition source, not a replacement for constituent render PRs or final main acceptance.

* wip(render): preserve stable aging target validation candidate

Exact staged source from prior review work on donor 3b892eab5e. This is a recovery/review checkpoint, NOT accepted delivery. An actual command-path regression currently fails because the selected executor refuses ordered surface aging. No assertion, capability or admission limit is weakened. Native/UI/full combination acceptance remains pending. Saved/runtime split adds one pending descriptor and retains original file scope; no main/render branch is changed.

* test(render): preserve numeric setup intent at the admitted coordinate bound

Follow up jyviko review on #5494 without weakening the corrected saved-coordinate contract. The positive clicked fixture uses 1e9 instead of inadmissible 2e9; explicit out-of-range cases still refuse, and the full saved setup round-trips through JSON and the native container. Exact-source Render workspace 95/0 and strict all-target UI Clippy pass. This does not incorporate the separately failing stable-aging candidate or claim full current-render acceptance.

* test(render): use the real GPU executor for saved aging

Move successful native cold-reopen Check/Start coverage from the CPU-backed protocol fixture into the production GPU executor tests. Verify capture-index changes preserve the stable target and that enabling aging changes both PNG and raw EXR output. Retain explicit, allocation-free refusal coverage for executors without aging support. Production capabilities and admission checks are unchanged.

* fix(render): persist stable identities for targeted aging (#5493)

Separate saved RenderBodyTarget identities from captured mesh ordinals. Reject legacy ambiguous targets, resolve Check/Start after visibility changes and preserve native reopening, copies and undo. Unsupported executors still refuse; real AMD Vulkan regression completes saved aging after reordered capture.

Source tree 6b84c8ad passes document 23, engine Render 75, GPU effects 5 and Render UI 95 with no failures; scoped strict Clippy, WASM and repository gates pass. Fresh CLI/native reopen and clean/aged GPU exports pass with identical physical totals and inspected actual images. Whole current-render integration is separate.

* fix(render): reconcile combined CPU/GPU contracts on current upstream

Unify captured resources/status and CPU-vs-GPU request schemas after the real two-parent integration; remove obsolete duplicate Vulkan selector and retain combined platform-filter regression. Deduplicate only identical or superseded test definitions, retaining the stronger card metadata and reserved-executor assertions. No assertions, admission limits or feature refusals are weakened.

All targets of render dependencies, GPU, engine, UI, CLI and native app pass cargo check with raytrace-cpu and bundled-render-library at tree c70d00d1. Native executable tests and full current-source acceptance remain pending. This is a private integration rehearsal for subsequent constituent PRs, not an aggregate official render/main merge.

* test(render): retain one complete host lifetime regression set

Deduplicate byte-identical DropProbe/task-lifetime tests and retain the adapted environment/texture ownership regressions with every assertion and complete memory estimate. Keep the registered-geometry admission regression once; only struct field order differed. Replace a one-element diagnostic loop with its equivalent block, preserving all wrap/width assertions.

Test-only integration repair. Formatting and diff checks pass; refreshed executable validation is required. No production behavior, limits, assertions or ignores changed.

* fix(doc): recognize the proven format-29 card descriptor alias

Normalize only the historical format-29 physical-material-cards spelling, and only when material-engineering-cards is registered. Admission and migration de-duplication use the same identity. Unknown concepts, wrong versions and incapable readers still refuse before mutation. Six controlled-history Rust regressions and actual CLI migration/no-clobber acceptance pass. No version, released migration or CI changes. Refs #5793, #1369, #5493.

* test(render): preserve grounding refusal before explicit instance moves

Update the two Render binding fixtures for upstream first-occurrence grounding. Verify grounded movement refuses without changing document/history, then explicitly unground through the public command before the intended move. Retain every target, resource, copy and persistence assertion. Refs #5493.

---------

Co-authored-by: Christian Svensson <blue@cmd.nu>
Co-authored-by: Victor Santos Oliveira <56417388+Vittuu@users.noreply.github.com>
Co-authored-by: cfaulkingham <colin.faulkingham@gmail.com>

2026-10-24 14:21:59 +00:00

8.1 KiB

Raw Permalink Blame History

Render resource starter pack

Version 1.0.0, authored 2026-10-21. This is a reproducible resource handoff for the personal SolidCraft render/materials fork. Its parent is the catalog checkpoint 10ada1b45a4eb285ce752ac72f9aaa968ff8b5c4, on the fixed lab/render-materials base. It does not update upstream or the application.

What is delivered

Resource	Delivered data	Availability
48 surfaces	240 PNGs at 512 × 512: base color, OpenGL normal, roughness, metallic and 16-bit height	Authored, numerically checked; renderer binding and reference renders pending
24 illumination environments	24 original 1024 × 512 Radiance RGBE HDR inputs	Authored, independently decoded; complete scene geometry and runtime binding pending
24 lighting recipes	Finite-area source transforms and radiance, finite-angular Sun, passive cards and explicit blockers	19 numerical recipes; 3 calibration blockers; 2 require an existing environment-owned Sun

The stable MAT-*, ENV-*, LUZ-* and STU-* concept identities remain in the catalog. This pack supplies authored realizations; it does not change all 1,160 concepts to "available". Neither pack.json nor the child manifests are a native solidcraft-library/1 or solidcraft-library/2 import file. Python is an offline authoring dependency only.

Entry points and ownership

pack.json identifies the three collections and their file contracts.
materials/source/recipes.json is the editable surface authority.
environments/source/recipes.json is the editable environment authority.
lighting/recipe.json pins the existing studio-presets.json authority and defines its numerical calibration; the studio geometry is not duplicated as a second editable authority.
exports/ contains required portable authoring inputs, with one resolution per map. Manifests capture source/generator hashes and payload receipts.
VALIDATION.md records what was actually checked and what remains.

The data covers industrial metals and coatings, automotive finishes, electronic housings and PCB surfaces, FDM/powder printing, wood/DIY, passive LED-associated surfaces, composites, thermal coverings and generic lunar surface studies. Material names express an appearance target. They do not certify composition, strength, thermal/electrical behavior, vacuum compatibility or flight readiness.

Rebuild and check

Use Python 3.11 or newer, NumPy and Pillow in a development environment. The environment decoder comparison additionally uses an installed FFmpeg executable as a separate process; no FFmpeg source, library or binary is bundled or linked. The exact development versions used for the release are in the validation record.

python3 -B assets/render/starter/tools/materials.py build
python3 -B assets/render/starter/tools/environments.py build
python3 -B assets/render/starter/tools/lighting.py build

python3 -B assets/render/starter/tools/validate_pack.py
python3 -B assets/render/starter/tools/materials.py validate --reproduce
python3 -B assets/render/starter/tools/environments.py validate --independent-decode --reproducible
python3 -B assets/render/starter/tools/lighting.py validate
python3 -B -m unittest discover -s assets/render/starter/tools -p 'test_*.py'

For a read-only combined authoring and native Rust check, use:

python -m pip install -r assets/render/starter/tools/requirements.txt
python -B assets/render/starter/tools/check_all.py

See native admission and continuous validation for the 192 texture inputs, 48 separately checked height sources, 24 HDR inputs, coordinate conventions, test coverage and evidence receipts. The dedicated Render resource gate runs these checks for relevant pull requests, including drafts, on Windows and Linux. It does not replace complete cargo xtask ci, application rendering acceptance or persistent resource binding; all runtime availability remains false.

The surface reproduction compares exact decoded pixel arrays; PNG compressed bytes may depend on the encoder build and platform even with the same Pillow version. All 240 decoded images were verified equal on Linux and Windows. Scoped Git attributes preserve LF in hashed text sources and binary map bytes. Environment and lighting reproduction checks compare encoded bytes. Every submitted export also has an exact SHA-256 receipt. Altering a receipt is not a substitute for reviewing and rebuilding a changed recipe.

Optional inspection outputs stay under ignored target/render-starter-review/:

python3 -B assets/render/starter/tools/materials.py preview
python3 -B assets/render/starter/tools/environments.py preview
python3 -B assets/render/starter/tools/lighting.py review

These are numerical data/fixture diagnostics, not screenshots of SolidCraft or proof of photorealistic output. They are not shipped as production resources.

Integration contract

Admit sources with exact hashes and byte/dimension budgets before allocating decoded textures. The current source limit remains 2048 pixels per texture axis and 2048 × 1024 for HDR; the submitted resources are below those limits.
Decode base color as sRGB and scalar/normal channels as linear data. Preserve the OpenGL normal convention and millimeter tile sizes. Renormalize normals after filtering. The 16-bit height exports are authoring data and require an explicit height/displacement adapter; do not send them through the strict eight-bit texture-input path or silently quantize them.
Preserve physical material cards, part dimensions, geometry, poses, joints and motion. An appearance realization does not assign engineering properties.
For HDR, honor explicit linear-sRGB primaries and the documented longitude mapping, source exposure and environment ownership. These probes provide illumination/reflection, not room parallax, support geometry or terrain.
Use a probe or its equivalent analytic emitters as the energy source. Do not duplicate its bright patches with extra lights. Black vacuum supplies exactly zero ambient radiance; a separately owned Sun must be supplied deliberately.
Apply lighting transforms once using the selected subject extent. Keep passive cards non-emissive, distinguish radiance from irradiance and retain blocked sources. Reference EV numbers are not lumens, watts or device values.
Bind each admitted resource to the actual renderer version, then capture common-exposure reference scenes on flat and curved coupons. CPU/GPU agreement, aliasing, filtering, orientation, save/reopen and resource lifetime remain integration acceptance work. Follow the existing Render tab/icon/UI contract.

Opaque coat, anodizing and fibre appearances are marked approximations. There is no glass transmission, layered clearcoat, spectral response, subsurface scattering, sampled emissive material or measured photometry in this surface slice. Such features require their own supported binding and reference evidence.

Clean-room and publication boundary

All new recipes, tools and map fields were authored from original mathematical construction and the project's own contracts. There are no external textures, commercial CAD outputs, sampled proprietary materials, copied implementations, AI-generated beauty images or imported HDR photography. Public format/equation references are cited in the collection documentation. Each non-Markdown file has an exact root ATTRIBUTION.md row under the repository's MIT OR Apache-2.0 choice.

The improved SELENE native source remains awaiting_native_source; this resource pack does not change that lock, substitute the historical v7 model or assert that the improved rover has been rendered. New resources are isolated from the frozen PR #3 review in the stacked assets/render-starter-pack branch. Integrate their attribution additions alongside, and without deleting, the other renderer thread's notices. Full repository gates remain required before application merge.

8.1 KiB Raw Permalink Blame History Unescape Escape