mirror of
https://github.com/bherbruck/solidcraft.git
synced 2026-11-08 21:11:56 +00:00
jyviko
746b43878e
* Layers: a Shared crate class, and cargo xtask shared builds each one on its own (#12935) A Shared crate depends only on other Shared crates, solidcore and external crates (UI toolkits included); any layered or testkit crate may use one. The layer check reports a Shared crate's dependency on an app crate, of any kind. cargo xtask shared checks each Shared crate's manifest (workspace lints, licence, README) and that no include_str! or include_bytes! reaches outside it, then builds and tests it with its Shared dependencies in a scratch workspace of its own. cargo xtask ci runs it after the layer check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LUXeKQRurMYJST9eSZWKzW * UI kit: the widget registry is a shared crate, ui-registry (#12936) The handle, rect and count registry that UI tests, scenarios and the control channel read moves out of scenario into solidcraft-ui-registry, the first Shared crate. The kit publishes into it directly; scenario re-exports it, so scenarios, scripts and the rest of ui-egui are unchanged and every handle keeps its name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LUXeKQRurMYJST9eSZWKzW * Theme: the tab accent takes the tab, the sketch and the tool as data (#12938) TabAccent::publish takes the open tab, whether a sketch is being edited and whether a tool or dialog is active, instead of SolveApp; SolveApp::publish_tab_accent works the three out in one place. scoped_panel_tokens is public, so a host can draw any component in another palette or accent. The theme and its tests no longer name SolveApp, Services or workspace. Accents are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LUXeKQRurMYJST9eSZWKzW * UI kit: Preferences search is a kit module, settings_search (#13256) prefs_search moves whole into ui_kit::settings_search: it filters any settings page the kit draws, and SolidCraft's Preferences window is one use of it. It publishes its handles into the widget registry and reads the same wall clock as before (web_time), so no kit file calls the app for search any more. Every caller uses the new path; state ids, handle names, matches and scores are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LUXeKQRurMYJST9eSZWKzW * UI kit: the kit owns the menu entry and the list width (#13257) Item (a command or ui.* action with its label, shortcut, icon, params, children, swatch and tip) and LIST_W move from context_menu into ui_kit::menu, with the same serde form, so the control channel's menu report is byte-identical. context_menu keeps building SolidCraft's entries (cmd, and act over Item::action) and returns kit Items. No kit file refers to context_menu any more. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LUXeKQRurMYJST9eSZWKzW * UI kit: number parsing and recent colours in the kit, expression support passed in by the host (#13258) parse_number (decimal point or comma, Unicode minus) moves from prefs into the kit's fields, and recent_colors moves whole into ui_kit::recent_colors beside the colour picker. The kit no longer knows the expression language: a host installs an Expressions (is this a literal, is this a unit, complete or step this text) per egui context, and fields read it for label drags and completion. SolidCraft installs DocExpressions, built on doc::expr and params_dialog::complete, when the app first draws into a context. Behaviour in the app is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LUXeKQRurMYJST9eSZWKzW * UI kit: navigation-bar values and the horizontal wheel in the kit (#13259) The bar's edge, size, idle and button-kind values move beside the bar's drawing in ui_kit::navigation as NavigationEdge, NavigationSize, NavigationIdle and NavigationKind (the kit already has a container Edge). Serde names are unchanged, so saved preferences load as before. take_horizontal_wheel moves into the theme picker, its only caller. SolidCraft's slot table stays in navigation_bar. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LUXeKQRurMYJST9eSZWKzW * UI kit: layout mode and card geometry in the kit, input shield set by the host (#13260) LayoutMode (with its per-context publish and current), the card gap and the panic-free clamp move into the kit's containers and panels, and Cards into stages. Cards::new takes the workspace width instead of reading the ribbon's constant. The flag that says a report covers the 3D view is now the kit's (input_blocked, set_input_blocked); the app's CadInput guard sets it, and issue_report's own copy is gone. Serde names are unchanged, so saved preferences load as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LUXeKQRurMYJST9eSZWKzW * UI kit: continuity rows leave the kit, the navigator figure takes its axes as input (#13261) continuity_row and its explained and tip variants are CAD controls over the kernel's Continuity: they move beside their callers in dialogs_surface, still drawn with the kit's choice_row. The Preferences navigator figure takes its axes (screen direction and depth) as NavigatorAxis input; SolidCraft computes them from its default camera. dashed_line is painter geometry and moves into ui_kit::dash with its test. No kit file uses the engine, the record or the viewport outside tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LUXeKQRurMYJST9eSZWKzW * UI kit: length fields take unit scaling and length parsing from the host (#13270) The kit's length field converted millimetres to and from the design's units through three prefs helpers. Those are the host's unit rules, so Expressions gains unit_scale, length_number and parse_length_mm, and length_drag reads them from the context. DocExpressions implements them with the same prefs helpers, so the app is unchanged. With nothing installed the field edits plain millimetres. No kit file calls prefs outside tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LUXeKQRurMYJST9eSZWKzW * Colour: the sRGB rule and the analysis palette are a shared crate, solidcraft-color (#13291) geom's srgb module (the one sRGB transfer function every encode and decode goes through) moves whole into solidcraft-color with its tests, and so does AnalysisColors, the analysis palette the theme fills and the renderer reads. render, doc, io, engine, gpu and ui-egui use the crate; there is no re-export at the old paths. The theme's unused material_color wrapper is removed, so no non-test theme code names solidcraft_engine. Values are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LUXeKQRurMYJST9eSZWKzW * Material editor: the Remove buttons are translated (material.editor.remove) The editor's two Remove buttons called tr("Remove"), which looks up an id, so they read "Remove" in every language. They use a new id, material.editor.remove, whose text in each locale is the one that locale already gives the plain Remove button prefs.network_host_remove (33 of 35 catalogs have it; the other two show English, as now). The label-literal guard found it once the file's import named tr directly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LUXeKQRurMYJST9eSZWKzW * Shared UI crates: ui-text, the message catalogs' machinery as a shared crate (#13290) bidi, Catalog, Locale, lookup, formatting, labels and language choice move from ui-egui's i18n into solidcraft-ui-text, a Shared crate any front end can use. The host installs its catalogs once; with none installed every id reads as itself. SolidCraft's 35 catalogs, the build script that merges them, and the adapters that read engine types (diagnostic, tr_engine_error, and the given-name and browser-label vocabulary as the LocaleNames trait) stay in the app's i18n. The app installs its catalogs when it starts, when an app is built and in the widget test context. Call sites use the crate's path, with no re-export at the old one; messages, ids and fallbacks are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LUXeKQRurMYJST9eSZWKzW * i18n tests: the painted-English sweeps install the catalogs themselves (#13290) no_english_is_painted_where_the_language_has_a_translation and the_sweep_reports_english_only_where_a_translation_exists read translations without installing the app's catalogs, so they passed only when another test in the same process had installed them first (run alone, every id read as itself). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Theme: the icon palette leaves Tokens; the icon renderer owns it (#13304) A theme file's icon palette was a field of Tokens, so the token set depended on the icon roles ui-egui's build script generates. It is now the icon renderer's per-thread state (icon_svg::set_theme_palette), set alongside the theme's palette by theme::set_file_palette, and theme_files resolves it with resolve_icon_palette (the same overlay merge as the tokens) and exports it as an argument. Rendered pixels, theme files and exports are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LUXeKQRurMYJST9eSZWKzW * Shared UI crates: the token contract as a shared crate, solidcraft-theme (#13304) Tokens with SolidCraft's light and dark values in code (palettes.rs moves in from assets/styles/ui, with the eight primary strokes it shared with the icon artwork written as icon_strokes), colour vision, TabAccent, contrast checks, apply/visuals and the per-thread and per-context theme state move into crates/theme, class Shared. It holds no data files and does not depend on theme files or icon roles; with nothing set, components draw with the built-in tokens. The theme system stays in ui-egui's theme module: the custom-theme glue (prepared theme, tab targets and their fade, blur intent), publish_tab (was TabAccent::publish, which now stores its result through TabAccent::set_current and set_published), set_file_palette, ViewportTheme. ui-egui's build script no longer generates the primary-stroke constants; an icon test holds the crate's literals equal to palette.toml's. Call sites use solidcraft_theme paths with no re-export (one rename pass). Tokens, theme files and rendered pixels are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LUXeKQRurMYJST9eSZWKzW * Theme: the icon lint and the docs read palettes.rs at crates/theme (#13304) lint_icons.py compared the icon review page with assets/styles/ui/palettes.rs, which moved into solidcraft-theme; it reads crates/theme/src/palettes.rs now (cargo xtask icons passes again), and the READMEs, docs and test comments name the new path. set_custom and scoped_tokens say they set tokens only, so a host with an icon renderer sets its palette too; the field contrast test applies each built-in theme with set_file_palette, as the app does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LUXeKQRurMYJST9eSZWKzW * Theme: format the field contrast test (#13304) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LUXeKQRurMYJST9eSZWKzW * MCP: the server machinery is a shared crate, solidcraft-mcp-server (#12947) JSON-RPC over stdio, the MCP lifecycle, tool and resource methods, tool definitions with their annotations, the argument check and the text and image results move to crates/mcp-server, which has no engine or GPU dependency and is classed Shared. SolidCraft's tools, instructions, resources and the agent's folders stay in crates/mcp and register into it through the Tools trait; its public API, tools list and replies are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LUXeKQRurMYJST9eSZWKzW * MCP: the shared server tests what it owns, on its own (#12947) Batches (mixed, notifications only, the 1000 limit), an unasked response, the protocol version fallback, null arguments, enum mismatches, the empty default lists and the list-then-call order Tools::call relies on are tested in solidcraft-mcp-server with a fake Tools; the protocol-only lines move out of SolidCraft's wrapper tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Docs: the architecture table lists the shared crates and the MCP split (#12947) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Control: the token files and Effect are a shared crate, solidcraft-control (#12946) The per-launch token, its files, the discovery file and the client's token lookup move from the engine to crates/control, with no engine dependency. Which app they belong to (name, data folder, environment, UTC format, default port) is an `App` value; SolidCraft's is engine::control_auth::APP. `Effect` moves with them; which requests do what stays in the engine's control_pending. Callers switch paths; files and messages are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LUXeKQRurMYJST9eSZWKzW * Control: the loopback control server is shared; SolidCraft gives it its Protocol (#12946) The token-admitted JSON-lines server (framing and line limit, connection cap, control.running/pending/capabilities, busy and timeout replies, control.subscribe events), ControlRequest and the design watch move to solidcraft-control as `server::Hub`. What a request means (its name in messages, its effect, command id, step count, the batch wait, the capabilities) is the app's `server::Protocol`; SolidCraft's is in apps/solidcraft/src/control_server.rs with its listeners and token files. The wire format is unchanged and the server's tests move with it. Also from review: Effect::when_done and the timeout text take the app's word for its document ("design" for SolidCraft), the Listen docs name no SolidCraft preference, and bench_assistant.rs is formatted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LUXeKQRurMYJST9eSZWKzW * Control: the shared server speaks the app's words and listens on loopback only (#12946) The change event, the revision method, the docs path in the unauthorized reply and the document noun come from the app's Protocol; SolidCraft's replies are byte-identical. The design watch is the DocumentWatch. Hub::listen refuses a listener off loopback, so no app can put the channel on the network; SolidCraft binds 127.0.0.1 as before. control_pending.rs is formatted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LUXeKQRurMYJST9eSZWKzW * Control: ui.screenshot and ui.resize are shared over egui (#12946) The window's screenshots in flight (the frame waits, the AO-settled shot, the hidden-window and chat-turn refusals, the 8 s deadline) move from SolveApp to solidcraft_control::screenshot::Shots, with the PNG encoding; ui.resize and the hidden-window test go to window. SolidCraft passes its AO settle, its issue report's frames and its vfs write, so a second app can serve ui.screenshot with the shared crate alone. The issue report and tests reach the queue as app.shots; replies are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Control: ui.screenshot and ui.resize are their own shared crate, solidcraft-control-egui (#12946) d8d35d454 made egui and image dependencies of solidcraft-control, so the headless engine, the CLI and the MCP bridge compiled egui. The screenshot and window modules move unchanged to solidcraft-control-egui; ui-egui uses them from there. cargo tree finds no egui under engine, mcp or control. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Control: the app gives the screenshot reply for no frame (#12946) The shared text named SolidCraft's ui.render. Shots::new takes the app's words; SolidCraft passes its reply unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Control: tests for the screenshot gate, a hidden window and frames nobody waits for (#12946) Shots::issue takes a frame on the third frame and 150 ms after the request, or 500 ms later for a view that keeps moving; a hidden window refuses a request and answers one waiting; with nothing pending the frames that came are dropped. Each fails on a one-line mutation of screenshot.rs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: jyviko <2501648+jyviko@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>